- logback-dev - mailman3.qos.ch

svn commit: r2127 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi
by noreply.ceki＠qos.ch 15 Jan '09

15 Jan '09

Author: ceki Date: Thu Jan 15 19:24:50 2009 New Revision: 2127 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java Log: In relation to LBCORE-83, marking the getFirstFilter method as deprecated. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java Thu Jan 15 19:24:50 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the generic, reliable, fast and flexible logging framework. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core.spi; @@ -26,6 +26,9 @@ /** * Get first filter in the chain. + * + * @deprecated This method will be removed in future versions. Please use + * {@link #getCopyOfAttachedFiltersList()} method instead. */ public Filter getFirstFilter();

1 0

svn commit: r2126 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi
by noreply.ceki＠qos.ch 09 Jan '09

09 Jan '09

Author: ceki Date: Fri Jan 9 19:17:44 2009 New Revision: 2126 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java Log: - javadoc changes Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java Fri Jan 9 19:17:44 2009 @@ -13,21 +13,21 @@ import ch.qos.logback.core.spi.FilterReply; /** - * This class is a context that can be used - * by access to provide the basic functionnalities of a context - * to its components, mainly SocketServer. - * + * A minimal context implementation used by certain logback-access components, + * mainly SocketServer. + * * @author Sébastien Pennec */ -public class AccessContext extends ContextBase implements AppenderAttachable<AccessEvent>, FilterAttachable<AccessEvent> { +public class AccessContext extends ContextBase implements + AppenderAttachable<AccessEvent>, FilterAttachable<AccessEvent> { AppenderAttachableImpl<AccessEvent> aai = new AppenderAttachableImpl<AccessEvent>(); FilterAttachableImpl<AccessEvent> fai = new FilterAttachableImpl<AccessEvent>(); - + public void callAppenders(AccessEvent event) { aai.appendLoopOnAppenders(event); } - + public void addAppender(Appender<AccessEvent> newAppender) { aai.addAppender(newAppender); } @@ -57,7 +57,7 @@ } public void addFilter(Filter<AccessEvent> newFilter) { - fai.addFilter(newFilter); + fai.addFilter(newFilter); } public void clearAllFilters() { @@ -67,7 +67,7 @@ public List<Filter<AccessEvent>> getCopyOfAttachedFiltersList() { return fai.getCopyOfAttachedFiltersList(); } - + public FilterReply getFilterChainDecision(AccessEvent event) { return fai.getFilterChainDecision(event); }

1 0

svn commit: r2125 - in logback/trunk: logback-access/src/main/java/ch/qos/logback/access/jetty logback-access/src/main/java/ch/qos/logback/access/spi logback-access/src/main/java/ch/qos/logback/access/tomcat logback-core/src/main/java/ch/qos/logback/core logback-core/src/main/java/ch/qos/logback/core/spi
by noreply.ceki＠qos.ch 09 Jan '09

09 Jan '09

Author: ceki Date: Fri Jan 9 19:15:02 2009 New Revision: 2125 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java Log: In FiterAttachable interface, renamed getCopyOfFilterList as getCopyOfAttachedFiltersList. Related to LBCORE-83. Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Fri Jan 9 19:15:02 2009 @@ -227,8 +227,8 @@ fai.clearAllFilters(); } - public List<Filter<AccessEvent>> getCopyOfFilterList() { - return fai.getCopyOfFilterList(); + public List<Filter<AccessEvent>> getCopyOfAttachedFiltersList() { + return fai.getCopyOfAttachedFiltersList(); } public FilterReply getFilterChainDecision(AccessEvent event) { Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java Fri Jan 9 19:15:02 2009 @@ -64,8 +64,8 @@ fai.clearAllFilters(); } - public List<Filter<AccessEvent>> getCopyOfFilterList() { - return fai.getCopyOfFilterList(); + public List<Filter<AccessEvent>> getCopyOfAttachedFiltersList() { + return fai.getCopyOfAttachedFiltersList(); } public FilterReply getFilterChainDecision(AccessEvent event) { Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Fri Jan 9 19:15:02 2009 @@ -229,8 +229,8 @@ fai.clearAllFilters(); } - public List<Filter<AccessEvent>> getCopyOfFilterList() { - return fai.getCopyOfFilterList(); + public List<Filter<AccessEvent>> getCopyOfAttachedFiltersList() { + return fai.getCopyOfAttachedFiltersList(); } public FilterReply getFilterChainDecision(AccessEvent event) { Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java Fri Jan 9 19:15:02 2009 @@ -126,8 +126,8 @@ fai.clearAllFilters(); } - public List<Filter<E>> getCopyOfFilterList() { - return fai.getCopyOfFilterList(); + public List<Filter<E>> getCopyOfAttachedFiltersList() { + return fai.getCopyOfAttachedFiltersList(); } public FilterReply getFilterChainDecision(E event) { Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Fri Jan 9 19:15:02 2009 @@ -132,8 +132,8 @@ fai.clearAllFilters(); } - public List<Filter<E>> getCopyOfFilterList() { - return fai.getCopyOfFilterList(); + public List<Filter<E>> getCopyOfAttachedFiltersList() { + return fai.getCopyOfAttachedFiltersList(); } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java Fri Jan 9 19:15:02 2009 @@ -37,7 +37,7 @@ * * @return all attached filters as a list */ - public List<Filter<E>> getCopyOfFilterList(); + public List<Filter<E>> getCopyOfAttachedFiltersList(); /** * Loop through the filters in the chain. As soon as a filter decides on Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java Fri Jan 9 19:15:02 2009 @@ -64,7 +64,7 @@ return FilterReply.NEUTRAL; } - public List<Filter<E>> getCopyOfFilterList() { + public List<Filter<E>> getCopyOfAttachedFiltersList() { return new ArrayList<Filter<E>>(filterList); } }

1 0

svn commit: r2124 - in logback/trunk: logback-access/src/main/java/ch/qos/logback/access/jetty logback-access/src/main/java/ch/qos/logback/access/spi logback-access/src/main/java/ch/qos/logback/access/tomcat logback-core/src/main/java/ch/qos/logback/core logback-core/src/main/java/ch/qos/logback/core/spi
by noreply.ceki＠qos.ch 09 Jan '09

09 Jan '09

Author: ceki Date: Fri Jan 9 19:11:38 2009 New Revision: 2124 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java Log: In response to LBCORE-83, added getCopyOfFilterList() method to the FilterAttachable interface. Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Fri Jan 9 19:11:38 2009 @@ -3,6 +3,7 @@ import java.io.File; import java.util.HashMap; import java.util.Iterator; +import java.util.List; import org.mortbay.jetty.Request; import org.mortbay.jetty.RequestLog; @@ -226,6 +227,10 @@ fai.clearAllFilters(); } + public List<Filter<AccessEvent>> getCopyOfFilterList() { + return fai.getCopyOfFilterList(); + } + public FilterReply getFilterChainDecision(AccessEvent event) { return fai.getFilterChainDecision(event); } Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java Fri Jan 9 19:11:38 2009 @@ -1,6 +1,7 @@ package ch.qos.logback.access.spi; import java.util.Iterator; +import java.util.List; import ch.qos.logback.core.Appender; import ch.qos.logback.core.ContextBase; @@ -63,6 +64,10 @@ fai.clearAllFilters(); } + public List<Filter<AccessEvent>> getCopyOfFilterList() { + return fai.getCopyOfFilterList(); + } + public FilterReply getFilterChainDecision(AccessEvent event) { return fai.getFilterChainDecision(event); } Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Fri Jan 9 19:11:38 2009 @@ -4,6 +4,7 @@ import java.io.IOException; import java.util.HashMap; import java.util.Iterator; +import java.util.List; import java.util.Map; import javax.servlet.ServletContext; @@ -228,6 +229,10 @@ fai.clearAllFilters(); } + public List<Filter<AccessEvent>> getCopyOfFilterList() { + return fai.getCopyOfFilterList(); + } + public FilterReply getFilterChainDecision(AccessEvent event) { return fai.getFilterChainDecision(event); } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java Fri Jan 9 19:11:38 2009 @@ -9,6 +9,8 @@ */ package ch.qos.logback.core; +import java.util.List; + import ch.qos.logback.core.filter.Filter; import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.spi.FilterAttachableImpl; @@ -124,6 +126,10 @@ fai.clearAllFilters(); } + public List<Filter<E>> getCopyOfFilterList() { + return fai.getCopyOfFilterList(); + } + public FilterReply getFilterChainDecision(E event) { return fai.getFilterChainDecision(event); } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Fri Jan 9 19:11:38 2009 @@ -9,6 +9,8 @@ */ package ch.qos.logback.core; +import java.util.List; + import ch.qos.logback.core.filter.Filter; import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.spi.FilterAttachableImpl; @@ -130,6 +132,11 @@ fai.clearAllFilters(); } + public List<Filter<E>> getCopyOfFilterList() { + return fai.getCopyOfFilterList(); + } + + public FilterReply getFilterChainDecision(E event) { return fai.getFilterChainDecision(event); } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachable.java Fri Jan 9 19:11:38 2009 @@ -9,6 +9,8 @@ */ package ch.qos.logback.core.spi; +import java.util.List; + import ch.qos.logback.core.filter.Filter; /** @@ -26,13 +28,21 @@ * Get first filter in the chain. */ public Filter getFirstFilter(); - + public void clearAllFilters(); /** - * Loop through the filters in the chain. As soon as a filter decides on + * Get a copy of all the filters contained within this FilterAttachable + * object. + * + * @return all attached filters as a list + */ + public List<Filter<E>> getCopyOfFilterList(); + + /** + * Loop through the filters in the chain. As soon as a filter decides on * ACCEPT or DENY, then that value is returned. If all of the filters return - * NEUTRAL, then NEUTRAL is returned. + * NEUTRAL, then NEUTRAL is returned. */ public FilterReply getFilterChainDecision(E event); } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/spi/FilterAttachableImpl.java Fri Jan 9 19:11:38 2009 @@ -9,6 +9,8 @@ */ package ch.qos.logback.core.spi; +import java.util.ArrayList; +import java.util.List; import java.util.concurrent.CopyOnWriteArrayList; import ch.qos.logback.core.filter.Filter; @@ -61,4 +63,8 @@ } return FilterReply.NEUTRAL; } + + public List<Filter<E>> getCopyOfFilterList() { + return new ArrayList<Filter<E>>(filterList); + } }

1 0

[JIRA] Created: (LBSITE-23) Typo in documentation of 'Prudent' property: 100'000 entered as 100'00
by Mark Vedder (JIRA) 09 Jan '09

09 Jan '09

Typo in documentation of 'Prudent' property: 100'000 entered as 100'00 ---------------------------------------------------------------------- Key: LBSITE-23 URL: http://jira.qos.ch/browse/LBSITE-23 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: 0.9.14 Environment: n/a Reporter: Mark Vedder Assignee: Logback dev list Priority: Minor In the documentation for the Prudent property of FileAppender (http://logback.qos.ch/manual/appenders.html#prudent) 100'000 is incorrectly entered as 100'00 (missing a zero): "...when prudent mode is off, it takes about 10 microseconds to write a single logging event. ... This translates to logging throughput of 100'00 events per second..." I'm not sure if the following comment is being too pedantic, but the section also sates that with prudent mode on, it takes 30 microseconds to log, which translates to 30'000 events per second. 30 microseconds would be 33'333 events per second. I'm not sure if that is a typo or just an approximation. If it is the latter, it might be helpful to add the such verbiage: "...and approximately 30,000 events per second." Alternatively, using the 33,333 value would make the 3x cost more apparent I think. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

svn commit: r2123 - in logback/trunk/logback-site/src/site/pages: . manual
by noreply.ceki＠qos.ch 09 Jan '09

09 Jan '09

Author: ceki Date: Fri Jan 9 18:46:02 2009 New Revision: 2123 Modified: logback/trunk/logback-site/src/site/pages/manual/appenders.html logback/trunk/logback-site/src/site/pages/news.html Log: - Fixed LBSITE-23 - added blurb in the news about ViewStatusServlet Modified: logback/trunk/logback-site/src/site/pages/manual/appenders.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/appenders.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/appenders.html Fri Jan 9 18:46:02 2009 @@ -540,9 +540,9 @@ takes about 10 microseconds to write a single logging event. When prudent mode is on, it takes approximately 30 microseconds to output a single logging event. This - translates to logging throughput of 100'00 events per second - when prudent mode is off and 30'000 events per second in - prudent mode. + translates to logging throughput of 100'000 events per second + when prudent mode is off and approximately 33'000 events per + second in prudent mode. </p> </td> Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Fri Jan 9 18:46:02 2009 @@ -36,7 +36,13 @@ href="http://jira.qos.ch/browse/LBCLASSIC-89">LBCLASSIC-89</a> reported by Alexis Morillo. </p> - + + <p>Added servleta for viewing internal status messages as an HTML + table. Two separate implementations are available; one for <a + href="manual/joran.html#viewingStatusMessages">logback-classic</a> + and the other for <a + href="access.html#viewingStatusMessages">logback-access</a>.</p> + <p>Added the <code>clear()</code> mthod to the <code>StatusManager</code> interface. After reconfiguration, it may be desirable to clear the status list maintained by a

1 0

[JIRA] Created: (LBCORE-82) StatusMessage viewer for tomcat
by Ceki Gulcu (JIRA) 09 Jan '09

09 Jan '09

StatusMessage viewer for tomcat ------------------------------- Key: LBCORE-82 URL: http://jira.qos.ch/browse/LBCORE-82 Project: logback-core Issue Type: Sub-task Affects Versions: 0.9.14 Reporter: Ceki Gulcu Assignee: Ceki Gulcu Fix For: 0.9.15 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

[JIRA] Resolved: (LBCORE-81) Servlet for viewing status messages
by Ceki Gulcu (JIRA) 09 Jan '09

09 Jan '09

[ http://jira.qos.ch/browse/LBCORE-81?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-81. ------------------------------ Fix Version/s: 0.9.15 Resolution: Fixed Fixed in revision 2121. > Servlet for viewing status messages > ----------------------------------- > > Key: LBCORE-81 > URL: http://jira.qos.ch/browse/LBCORE-81 > Project: logback-core > Issue Type: Improvement > Components: Other > Affects Versions: 0.9.14 > Environment: Operating System: Windows > Platform: PC > Reporter: Ceki Gulcu > Assignee: Ceki Gulcu > Fix For: 0.9.15 > > > Even small errors are hard to debug since there is no output shown by the requestLog implementations. It would be nice to access the Context statii thourgh a servlet or other means. > Ex: an error in the Layout pattern results in no access logs without any other information -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r2122 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty
by noreply.ceki＠qos.ch 09 Jan '09

09 Jan '09

Author: ceki Date: Fri Jan 9 18:32:04 2009 New Revision: 2122 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Log: - removed problematic code Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Fri Jan 9 18:32:04 2009 @@ -4,13 +4,10 @@ import java.util.HashMap; import java.util.Iterator; -import javax.servlet.http.HttpSession; - import org.mortbay.jetty.Request; import org.mortbay.jetty.RequestLog; import org.mortbay.jetty.Response; -import ch.qos.logback.access.AccessConstants; import ch.qos.logback.access.joran.JoranConfigurator; import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.core.Appender; @@ -116,13 +113,6 @@ jettyResponse); AccessEvent accessEvent = new AccessEvent(jettyRequest, jettyResponse, adapter); - - HttpSession s = jettyRequest.getSession(); - if (s != null) { - System.out.println("Setting as session attribute"); - s.setAttribute(AccessConstants.LOGBACK_STATUS_MANAGER_KEY, - getStatusManager()); - } if (getFilterChainDecision(accessEvent) == FilterReply.DENY) { return; }

1 0

svn commit: r2121 - in logback/trunk: logback-access/src/main/java/ch/qos/logback/access logback-access/src/main/java/ch/qos/logback/access/jetty logback-classic/src/main/java/ch/qos/logback/classic logback-site/src/site/pages logback-site/src/site/pages/manual logback-site/src/site/resources/images logback-site/src/site/resources/manual/images/chapter3
by noreply.ceki＠qos.ch 09 Jan '09

09 Jan '09

Author: ceki Date: Fri Jan 9 18:31:17 2009 New Revision: 2121 Added: logback/trunk/logback-site/src/site/resources/images/lbAccessStatus.jpg (contents, props changed) logback/trunk/logback-site/src/site/resources/manual/images/chapter3/lbClassicStatus.jpg (contents, props changed) Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/ViewStatusMessagesServlet.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/ViewStatusMessagesServlet.java logback/trunk/logback-site/src/site/pages/access.html logback/trunk/logback-site/src/site/pages/manual/joran.html Log: Fixing LBCORE-81 and LBCORE-82. - Added StatusMessage viewer servlet for lb-classic called ViewStatusMessagesServlet. - Added StatusMessage viewer servlet for lb-access called ViewStatusMessagesServlet. It works with Tomcat but not Jetty. - Added relevant documentation. Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/ViewStatusMessagesServlet.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/ViewStatusMessagesServlet.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/ViewStatusMessagesServlet.java Fri Jan 9 18:31:17 2009 @@ -9,6 +9,7 @@ */ package ch.qos.logback.access; +import javax.servlet.ServletContext; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -20,8 +21,24 @@ private static final long serialVersionUID = 443878494348593337L; @Override - protected StatusManager getStatusManager(HttpServletRequest req, HttpServletResponse resp) { - return (StatusManager) req.getAttribute(AccessConstants.LOGBACK_STATUS_MANAGER_KEY); + protected StatusManager getStatusManager(HttpServletRequest req, + HttpServletResponse resp) { + + ServletContext sc = getServletContext(); + StatusManager result = (StatusManager) sc + .getAttribute(AccessConstants.LOGBACK_STATUS_MANAGER_KEY); + return result; + +// if (result != null) { +// System.out.println("from ServletContext"); +// return result; +// } else { +// HttpSession httpSession = req.getSession(true); +// +// System.out.println("from httpSession"); +// return (StatusManager) httpSession +// .getAttribute(AccessConstants.LOGBACK_STATUS_MANAGER_KEY); +// } } @Override Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Fri Jan 9 18:31:17 2009 @@ -4,7 +4,7 @@ import java.util.HashMap; import java.util.Iterator; -import javax.servlet.ServletContext; +import javax.servlet.http.HttpSession; import org.mortbay.jetty.Request; import org.mortbay.jetty.RequestLog; @@ -92,7 +92,7 @@ * <appender-ref ref="SMTP" /> * </configuration> * </pre> - + * * @author Ceki Gülcü * @author Sébastien Pennec */ @@ -106,8 +106,7 @@ FilterAttachableImpl<AccessEvent> fai = new FilterAttachableImpl<AccessEvent>(); String filename; boolean started = false; - boolean alreadySetLogbackStatusManager = false; - + public RequestLogImpl() { putObject(CoreConstants.EVALUATOR_MAP, new HashMap()); } @@ -118,18 +117,12 @@ AccessEvent accessEvent = new AccessEvent(jettyRequest, jettyResponse, adapter); - if (!alreadySetLogbackStatusManager) { - alreadySetLogbackStatusManager = true; - ServletContext sc = jettyRequest.getContext(); - // servlet context is always null - if (sc != null) { - sc.setAttribute(AccessConstants.LOGBACK_STATUS_MANAGER_KEY, - getStatusManager()); - } + HttpSession s = jettyRequest.getSession(); + if (s != null) { + System.out.println("Setting as session attribute"); + s.setAttribute(AccessConstants.LOGBACK_STATUS_MANAGER_KEY, + getStatusManager()); } - - jettyRequest.setAttribute( - AccessConstants.LOGBACK_STATUS_MANAGER_KEY, getStatusManager()); if (getFilterChainDecision(accessEvent) == FilterReply.DENY) { return; } Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/ViewStatusMessagesServlet.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/ViewStatusMessagesServlet.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/ViewStatusMessagesServlet.java Fri Jan 9 18:31:17 2009 @@ -21,7 +21,6 @@ private static final long serialVersionUID = 443878494348593337L; - // @Override protected StatusManager getStatusManager(HttpServletRequest req, HttpServletResponse resp) { Modified: logback/trunk/logback-site/src/site/pages/access.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/access.html (original) +++ logback/trunk/logback-site/src/site/pages/access.html Fri Jan 9 18:31:17 2009 @@ -111,9 +111,39 @@ the logback-access configuration file. Here is an example. </p> + <p class="source"><Valve className="ch.qos.logback.access.tomcat.LogbackValve" + quiet="true" filename="c:/my-logback-access.xml"/></p> - <div class="source"><pre><Valve className="ch.qos.logback.access.tomcat.LogbackValve" - quiet="true" filename="c:/my-logback-access.xml"/></pre></div> + <h3><a name="viewingStatusMessages" + href="#viewingStatusMessages">Viewing status messages</a></h3> + + <p>Logback-access ships with a servlet called + <code>ViewStatusMessagesServlet</code>. This servlet prints the + internal status messages of the <code>LogbackValve</code> as an + HTML table. Here is sample output. + </p> + + + <a href="images/lbAccessStatus.jpg"> + <img src="images/lbAccessStatus.jpg" alt="click to enlarge" width="90%"/> + </a> + + <p>To add this servlet to your web-application, add the following + lines to its <em>WEB-INF/web.xml</em> file.</p> + + <p class="source"> <servlet> + <servlet-name>AccessViewStatusMessages</servlet-name> + <servlet-class>ch.qos.logback.access.ViewStatusMessagesServlet</servlet-class> + </servlet> + + <servlet-mapping> + <servlet-name>AccessViewStatusMessages</servlet-name> + <url-pattern>/lbAccessStatus</url-pattern> + </servlet-mapping></p> + + <p>The <code>ViewStatusMessages</code> servlet will available + under the URL <code>http://host/yourWebapp/lbAccessStatus</code> + </p> <a name="jetty"></a> <h1>Logback-access under Jetty</h1> Modified: logback/trunk/logback-site/src/site/pages/manual/joran.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/joran.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/joran.html Fri Jan 9 18:31:17 2009 @@ -409,15 +409,16 @@ errors. </p> - <h3> - <a name="statusListener" href="#statusListener">Listening to - status messages</a> - </h3> - - <p>Logback collects its internal status data in its <code><a - href="../xref/ch/qos/logback/core/status/StatusManager.html">StatusManager</a></code>, - accessible via the LoggerContext. - </p> + <h3><a name="viewingStatusMessages" + href="#viewingStatusMessages">Viewing status messages</a> + </h3> + + + + <p>Logback collects its internal status data in a <code><a + href="../xref/ch/qos/logback/core/status/StatusManager.html">StatusManager</a></code> + object, accessible via the <code>LoggerContext</code>. + </p> <p>Given a <code>StatusManager</code> you an access all the status data associated with a logback context. To keep memory usage at @@ -428,6 +429,39 @@ <em>T</em> messages. At present time <em>H</em>=<em>T</em>=150, although these values may change in future releases.</p> + <p>Logback-classic ships with a servlet called + ViewStatusMessagesServlet. This servlet prints the contents of the + <code>StatusManager</code> associated with the current + <code>LoggerContext</code> as an HTML table. Here is sample output. + </p> + + <a href="images/chapter3/lbClassicStatus.jpg"> + <img src="images/chapter3/lbClassicStatus.jpg" alt="click to enlarge" width="90%"/> + </a> + + <p>To add this servlet to your web-application, add the following + lines to its <em>WEB-INF/web.xml</em> file.</p> + + <p class="source"> <servlet> + <servlet-name>ViewStatusMessages</servlet-name> + <servlet-class>ch.qos.logback.classic.ViewStatusMessagesServlet</servlet-class> + </servlet> + + <servlet-mapping> + <servlet-name>ViewStatusMessages</servlet-name> + <url-pattern>/lbClassicStatus</url-pattern> + </servlet-mapping></p> + + <p>The <code>ViewStatusMessages</code> servlet will viewable under + the URL <code>http://host/yourWebapp/lbClassicStatus</code> + </p> + + <h3> + <a name="statusListener" href="#statusListener">Listening to + status messages</a> + </h3> + + <p>You may also attach a <code>StatusListener</code> to a <code>StatusManager</code> so that you can take immediate action in @@ -477,9 +511,12 @@ <p class="source">java <b>-Dlogback.statusListenerClass</b>=ch.qos.logback.core.status.OnConsoleStatusListener ...</p> - <h2> - <a name="syntax" href="#syntax">Configuration file Syntax</a> - </h2> + + + + <h2> + <a name="syntax" href="#syntax">Configuration file Syntax</a> + </h2> <p>To obtain these different logging behaviors we do not need to recompile code. You can easily configure logback so as to disable Added: logback/trunk/logback-site/src/site/resources/images/lbAccessStatus.jpg ============================================================================== Binary file. No diff available. Added: logback/trunk/logback-site/src/site/resources/manual/images/chapter3/lbClassicStatus.jpg ============================================================================== Binary file. No diff available.

1 0