- logback-dev - mailman3.qos.ch

[JIRA] Issue Comment Edited: (LBCORE-28) rolling policy which starts new file on system startup
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCORE-28?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu edited comment on LBCORE-28 at 10/29/08 9:15 PM: ------------------------------------------------------------ This issue duplicates LBCORE-26. It will be resolved in logback 0.9.12. was (Author: noreply.ceki(a)qos.ch) This issue duplicates LBCORE-26 > rolling policy which starts new file on system startup > ------------------------------------------------------ > > Key: LBCORE-28 > URL: http://jira.qos.ch/browse/LBCORE-28 > Project: logback-core > Issue Type: Improvement > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Hontvári József > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.12 > > > I would add an option to the rolling appender to start a new file not > only when the trigger fires but also when the system is started. > According to the email thread on logback-dev this can be for example an option of the current trigger implementations. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCORE-28) rolling policy which starts new file on system startup
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCORE-28?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-28. ------------------------------ Fix Version/s: 0.9.12 Resolution: Duplicate This issue duplicates LBCORE-26 > rolling policy which starts new file on system startup > ------------------------------------------------------ > > Key: LBCORE-28 > URL: http://jira.qos.ch/browse/LBCORE-28 > Project: logback-core > Issue Type: Improvement > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Hontvári József > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.12 > > > I would add an option to the rolling appender to start a new file not > only when the trigger fires but also when the system is started. > According to the email thread on logback-dev this can be for example an option of the current trigger implementations. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCORE-20) Add cleanup to TimeBasedRollingPolicy
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCORE-20?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-20. ------------------------------ Fix Version/s: 0.9.11 Resolution: Duplicate Thank you Andy. This issue duplicates LBCORE-11. Moreover, it has been solved in logback 0.9.11 > Add cleanup to TimeBasedRollingPolicy > ------------------------------------- > > Key: LBCORE-20 > URL: http://jira.qos.ch/browse/LBCORE-20 > Project: logback-core > Issue Type: Improvement > Components: Appender > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Andy Gerweck > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.11 > > > The TimeBasedRollingPolicy class is very convenient for complex applications, but it still leaves us with the task of manually deleting old log files. It would be very nice if, like FixedWindowRollingPolicy, TimeBasedRollingPolicy had an option to keep only up to _n_ time windows. > E.g., I'd like to configure LOGBack to keep the last 30 days (or last 3 months, rotated monthly) of files with the TimeBasedRollingPolicy. I could use the FixedWindowROollingPolicy for this, but it's more cumbersome and I prefer to have the date in the file name. > Software should do the tricky stuff once for everybody to reuse. :-) Thanks again for the excellent LOGBack, I can't rave enough about how much an improvement it, along with SLF4J, is. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCORE-34) Improve WriterAppender
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCORE-34?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-34. ------------------------------ Fix Version/s: 0.9.12 Resolution: Fixed fixed as suggested in revision 1914 > Improve WriterAppender > ---------------------- > > Key: LBCORE-34 > URL: http://jira.qos.ch/browse/LBCORE-34 > Project: logback-core > Issue Type: Improvement > Components: Appender > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Anders Hammar > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.12 > > > Reviewing the ch.qos.logback.core.WriterAppender class, I see that the attributes are 'protected' (not 'private'). However, there are set and get methods for most of them (but not all). > I suggest making the attributes private and create setters and getters for all of them (there is no getWriter() for instance). This would prevent subclasses from incorrectly working directly against the attributes (for instance, not using the setWriter() would cause errors). If some 'public' getters are not desirable, at least 'protected' ones should be provided. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1914 - in logback/trunk/logback-core/src: main/java/ch/qos/logback/core test/java/ch/qos/logback/core/appender
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 21:03:58 2008 New Revision: 1914 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppender.java Log: The writer field in WriterAppender has been marked as private, as suggested by Anders Hammar in LBCORE-34 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java Wed Oct 29 21:03:58 2008 @@ -13,6 +13,7 @@ import java.io.File; import java.io.FileOutputStream; import java.io.IOException; +import java.io.Writer; import ch.qos.logback.core.status.ErrorStatus; import ch.qos.logback.core.status.InfoStatus; @@ -87,14 +88,14 @@ public void start() { int errors = 0; if (fileName != null) { - addInfo("filename set to ["+fileName+"]"); - + addInfo("filename set to [" + fileName + "]"); + // In case both bufferedIO and immediateFlush are set, the former // takes priority because 'immediateFlush' is set to true by default. // If the user explicitly set bufferedIO, then we should follow her // directives. if (bufferedIO) { - immediateFlush = false; + setImmediateFlush(false); addStatus(new InfoStatus( "Setting immediateFlush to false on account of bufferedIO option", this)); @@ -118,22 +119,20 @@ } /** - * - * Sets and opens the file where the log output will go. The specified - * file must be writable. + * Sets and opens the file where the log output will go. The + * specified file must be writable. * - * - * If there was already an opened file, then the previous file is closed + * If there was already an opened file, then the previous file is closed * first. * - * - * Do not use this method directly. To configure a FileAppender or one of - * its subclasses, set its properties one by one and then call start(). + * Do not use this method directly. To configure a FileAppender or one + * of its subclasses, set its properties one by one and then call start(). * * @param filename - * The path to the log file. + * The path to the log file. * @param append - * If true will append to fileName. Otherwise will truncate fileName. + * If true will append to fileName. Otherwise will truncate + * fileName. * @param bufferedIO * @param bufferSize * @@ -141,21 +140,20 @@ * */ public synchronized void openFile() throws IOException { - closeWriter(); - File file = new File(fileName); - if(FileUtil.mustCreateParentDirectories(file)) { + if (FileUtil.mustCreateParentDirectories(file)) { boolean result = FileUtil.createMissingParentDirectories(file); - if(!result) { - addError("Failed to create parent directories for ["+file.getAbsolutePath()+"]"); + if (!result) { + addError("Failed to create parent directories for [" + + file.getAbsolutePath() + "]"); } } - - this.writer = createWriter(new FileOutputStream(fileName, append)); + + Writer w = createWriter(new FileOutputStream(fileName, append)); if (bufferedIO) { - this.writer = new BufferedWriter(this.writer, bufferSize); + w = new BufferedWriter(w, bufferSize); } - writeHeader(); + setWriter(w); } public boolean isBufferedIO() { Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/WriterAppender.java Wed Oct 29 21:03:58 2008 @@ -1,12 +1,13 @@ /** - * Logback: the reliable, generic, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ + package ch.qos.logback.core; import java.io.IOException; @@ -39,7 +40,7 @@ * The <code>immediateFlush</code> variable is set to <code>true</code> by * default. */ - protected boolean immediateFlush = true; + private boolean immediateFlush = true; /** * The encoding to use when opening an InputStream. @@ -47,18 +48,18 @@ * The <code>encoding</code> variable is set to <code>null</null> by default * which results in the use of the system's default encoding. */ - protected String encoding; + private String encoding; /** * This is the {@link Writer Writer} where we will write to. */ - protected Writer writer; + private Writer writer; /** * The layout variable does not need to be set if the appender implementation * has its own layout. */ - protected Layout<E> layout; + private Layout<E> layout; /** * The default constructor does nothing. Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppender.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppender.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppender.java Wed Oct 29 21:03:58 2008 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core.appender; @@ -15,11 +15,8 @@ public class DummyAppender<E> extends WriterAppender<E> { - DummyAppender(Writer writer) { - this.writer = writer; + this.setWriter(writer); } - - - + }

1 0

svn commit: r1913 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 20:13:40 2008 New Revision: 1913 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Log: added a minor comment Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Wed Oct 29 20:13:40 2008 @@ -27,6 +27,7 @@ // reading SynchronizedCollection source code, we learn that the mutex is the // returned synchronized list, we make use of this fact in getCopyOfStatusList + // protected access was requested in http://jira.qos.ch/browse/LBCORE-36 final protected List<Status> statusList = Collections .synchronizedList(new ArrayList<Status>()); int level = Status.INFO; @@ -34,6 +35,7 @@ // reading SynchronizedCollection source code, we learn that the mutex is the // returned synchronized list, we make use of this fact in // getCopyOfStatusListnerList + // protected access was requested in http://jira.qos.ch/browse/LBCORE-36 final protected List<StatusListener> statusListenerList = Collections .synchronizedList(new ArrayList<StatusListener>());

1 0

svn commit: r1912 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 20:13:12 2008 New Revision: 1912 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java Log: comment change Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java Wed Oct 29 20:13:12 2008 @@ -40,6 +40,7 @@ * @param statusManager * the new status manager */ + // added in response to http://jira.qos.ch/browse/LBCORE-35 public void setStatusManager(StatusManager statusManager) { if (sm == null) { throw new IllegalArgumentException("null StatusManager not allowed");

1 0

[JIRA] Resolved: (LBCORE-36) Make BasicStatusManager more sub-class friendly
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCORE-36?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-36. ------------------------------ Fix Version/s: 0.9.12 Resolution: Fixed statusList and statusListenerList fields are now "protected" > Make BasicStatusManager more sub-class friendly > ----------------------------------------------- > > Key: LBCORE-36 > URL: http://jira.qos.ch/browse/LBCORE-36 > Project: logback-core > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Anders Hammar > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.12 > > > To allow for more implementation specific sub-classes of BasicStatusManager, class attribute should be 'protected' (or add setters and getters). In the current implementation, a sub-class cannot (for instance) modify the statusList (to clear the statuses or such). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1911 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 20:11:18 2008 New Revision: 1911 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Log: LBCORE-36 Making BasicStatusManager more sub-class friendly Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Wed Oct 29 20:11:18 2008 @@ -27,14 +27,14 @@ // reading SynchronizedCollection source code, we learn that the mutex is the // returned synchronized list, we make use of this fact in getCopyOfStatusList - final List<Status> statusList = Collections + final protected List<Status> statusList = Collections .synchronizedList(new ArrayList<Status>()); int level = Status.INFO; // reading SynchronizedCollection source code, we learn that the mutex is the // returned synchronized list, we make use of this fact in // getCopyOfStatusListnerList - final List<StatusListener> statusListenerList = Collections + final protected List<StatusListener> statusListenerList = Collections .synchronizedList(new ArrayList<StatusListener>()); /**

1 0

[JIRA] Resolved: (LBCORE-35) Possibility to change StatusManger impl in subclass of ContextBase
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCORE-35?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-35. ------------------------------ Fix Version/s: 0.9.12 Resolution: Fixed Added a setter for status manager in revision 1910 > Possibility to change StatusManger impl in subclass of ContextBase > ------------------------------------------------------------------ > > Key: LBCORE-35 > URL: http://jira.qos.ch/browse/LBCORE-35 > Project: logback-core > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Anders Hammar > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.12 > > > I'd like the possibility to change the StatusManager implementation in a subclass of ch.qos.logback.core.ContextBase. As the sm attribute isn't 'protected' and there is no set method, this isn't possible without overriding the getStatusManger() method. > A simple solution would be to add a 'protected' constructor that takes the StatusManager as argument. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0