- logback-dev - mailman3.qos.ch

svn commit: r1910 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 20:07:39 2008 New Revision: 1910 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java Log: LBCORE-35 Added a setter for the StatusManager. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java Wed Oct 29 20:07:39 2008 @@ -17,17 +17,36 @@ public class ContextBase implements Context { private String name; - StatusManager sm = new BasicStatusManager(); + private StatusManager sm = new BasicStatusManager(); // TODO propertyMap should be observable so that we can be notified // when it changes so that a new instance of propertyMap can be // serialized. For the time being, we ignore this shortcoming. Map<String, String> propertyMap = new HashMap<String, String>(); Map<String, Object> objectMap = new HashMap<String, Object>(); - + public StatusManager getStatusManager() { return sm; } + /** + * Set the {@link StatusManager} for this context. Note that by default this + * context is initialized with a {@link BasicStatusManager}. A null value for + * the 'statusManager' argument is not allowed. + * + * + * A malicious attacker can set the status manager to a dummy instance, + * disabling internal error reporting. + * + * @param statusManager + * the new status manager + */ + public void setStatusManager(StatusManager statusManager) { + if (sm == null) { + throw new IllegalArgumentException("null StatusManager not allowed"); + } + this.sm = statusManager; + } + public Map<String, String> getCopyOfPropertyMap() { return new HashMap<String, String>(propertyMap); } @@ -48,7 +67,6 @@ objectMap.put(key, value); } - public String getName() { return name; }

1 0

[JIRA] Created: (LBCLASSIC-59) LogbackErrorListener
by Anton Tagunov (JIRA) 29 Oct '08

29 Oct '08

LogbackErrorListener -------------------- Key: LBCLASSIC-59 URL: http://jira.qos.ch/browse/LBCLASSIC-59 Project: logback-classic Issue Type: Improvement Reporter: Anton Tagunov Assignee: Logback dev list Priority: Minor Presently we can only poll StatusManager for errors. It would be nice to be able to subscribe to these messages. One idea was to allow custom StatusManager implementations. This sounds like a nice and sane idea in its own right. However I feel that providing subscription to error events and allowing users to provide alternative StatusManager implementations are orthogonal concerns. In fact I feel that application should be able to subscribe to logback errors no matter what StatusManager is used stock or custom. In other words I suggest it to be part of StatusManager interface/contract to provide subscriptions. Which brings me back to the idea that it would be best to provide subscription (listener) facility in the standards StatusManager. On yet another account http://jira.qos.ch/browse/LBCLASSIC-58 may be enough for most practical users. And I suspect that the most common LogbackErrorListener implementation will simply log to System.out. In any case we badly need to get these errors out of Logback. BTW an alternative implemenation of LogbackListener might log to a file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

5 5

svn commit: r1909 - in logback/trunk: logback-core/src/main/java/ch/qos/logback/core logback-examples/src/main/java/chapter3 logback-site/src/site/pages
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 19:42:44 2008 New Revision: 1909 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java logback/trunk/logback-examples/src/main/java/chapter3/MyApp1.java logback/trunk/logback-examples/src/main/java/chapter3/MyApp2.java logback/trunk/logback-examples/src/main/java/chapter3/MyApp3.java logback/trunk/logback-site/src/site/pages/news.html Log: - changes in comments - copyright notices Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Wed Oct 29 19:42:44 2008 @@ -24,15 +24,16 @@ // This method is synchronized on the instance. // Code int count = 0; - - // reading SynchronizedCollection the mutex is the returned - // synchronized list, we make use of this fact in getCopyOfStatusList + + // reading SynchronizedCollection source code, we learn that the mutex is the + // returned synchronized list, we make use of this fact in getCopyOfStatusList final List<Status> statusList = Collections .synchronizedList(new ArrayList<Status>()); int level = Status.INFO; - // reading SynchronizedCollection the mutex is the returned - // synchronized list, we make use of this fact in getCopyOfStatusListnerList + // reading SynchronizedCollection source code, we learn that the mutex is the + // returned synchronized list, we make use of this fact in + // getCopyOfStatusListnerList final List<StatusListener> statusListenerList = Collections .synchronizedList(new ArrayList<StatusListener>()); @@ -54,13 +55,13 @@ statusList.add(newStatus); fireStatusAddEvent(newStatus); } - + private void fireStatusAddEvent(Status status) { synchronized (statusListenerList) { - for(StatusListener sl : statusListenerList) { + for (StatusListener sl : statusListenerList) { sl.addStatusEvent(status); - } - } + } + } } public List<Status> getCopyOfStatusList() { Modified: logback/trunk/logback-examples/src/main/java/chapter3/MyApp1.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter3/MyApp1.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter3/MyApp1.java Wed Oct 29 19:42:44 2008 @@ -1,7 +1,7 @@ /** - * Logback: the reliable, generic, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free Modified: logback/trunk/logback-examples/src/main/java/chapter3/MyApp2.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter3/MyApp2.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter3/MyApp2.java Wed Oct 29 19:42:44 2008 @@ -20,8 +20,9 @@ final static Logger logger = LoggerFactory.getLogger(MyApp2.class); public static void main(String[] args) { - // print logback's internal status + // assume SLF4J is bound to logback in the current environment LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + // print logback's internal status StatusPrinter.print(lc); logger.info("Entering application."); Modified: logback/trunk/logback-examples/src/main/java/chapter3/MyApp3.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/chapter3/MyApp3.java (original) +++ logback/trunk/logback-examples/src/main/java/chapter3/MyApp3.java Wed Oct 29 19:42:44 2008 @@ -1,13 +1,12 @@ /** - * Logback: the reliable, generic, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2008, QOS.ch + * Copyright (C) 2000-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ - package chapter3; /** @@ -26,7 +25,7 @@ final static Logger logger = LoggerFactory.getLogger(MyApp3.class); public static void main(String[] args) { - // assume logback is in use + // assume SLF4J is bound to logback in the current environment LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); try { Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Wed Oct 29 19:42:44 2008 @@ -32,6 +32,20 @@ property files from classpath resources. + Fixed <a href="http://jira.qos.ch/browse/LBCLASSIC-69">bug + LBCLASSIC-69</a> reported by Anton Tagunov. The + LevelToSyslogSeverity now correctly handles the TRACE level. + + + Fixed <a href="http://jira.qos.ch/browse/LBCLASSIC-57">bug + LBCLASSIC-57</a> reported by Anton Tagunov. + + + Fixed <a + href="http://jira.qos.ch/browse/LBCLASSIC-59">improvement request + LBCLASSIC-59</a> orignally made by Anton Tagunov. + + <hr width="80%" align="center" /> <h3>28th of October 2008 - Release of version 0.9.11</h3> @@ -66,7 +80,7 @@ Fixed <a href="http://jira.qos.ch/browse/LBCLASSIC-56">bug - LBCLASSIC-56c</a> originally reported by Michel Colette. Backslash + LBCLASSIC-56</a> originally reported by Michel Colette. Backslash characters are now correctly interpreted in filename patterns.

1 0

svn commit: r1908 - in logback/trunk: logback-core/src/main/java/ch/qos/logback/core/status logback-examples/src/main/java/chapter3 logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 19:42:07 2008 New Revision: 1908 Added: logback/trunk/logback-examples/src/main/java/chapter3/AddStatusListenerApp.java logback/trunk/logback-examples/src/main/java/chapter3/onConsoleStatusListener.xml Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusListener.java logback/trunk/logback-site/src/site/pages/manual/joran.html Log: LBCLASSIC-59 - documentation on status listeners Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusListener.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusListener.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusListener.java Wed Oct 29 19:42:07 2008 @@ -1,5 +1,20 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.core.status; +/** + * A StatusListener registered with logback context's {@link StatusManager} will + * receive notification of every incoming {@link Status status} message. + * + * @author Ceki Gülcü + */ public interface StatusListener { void addStatusEvent(Status status); } Added: logback/trunk/logback-examples/src/main/java/chapter3/AddStatusListenerApp.java ============================================================================== --- (empty file) +++ logback/trunk/logback-examples/src/main/java/chapter3/AddStatusListenerApp.java Wed Oct 29 19:42:07 2008 @@ -0,0 +1,37 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package chapter3; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.core.joran.spi.JoranException; +import ch.qos.logback.core.status.OnConsoleStatusListener; +import ch.qos.logback.core.status.StatusManager; + +public class AddStatusListenerApp { + + public static void main(String[] args) throws JoranException { + + + LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + StatusManager statusManager = lc.getStatusManager(); + OnConsoleStatusListener onConsoleListener = new OnConsoleStatusListener(); + statusManager.add(onConsoleListener); + + Logger logger = LoggerFactory.getLogger("myApp"); + logger.info("Entering application."); + + Foo foo = new Foo(); + foo.doIt(); + logger.info("Exiting application."); + } +} Added: logback/trunk/logback-examples/src/main/java/chapter3/onConsoleStatusListener.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-examples/src/main/java/chapter3/onConsoleStatusListener.xml Wed Oct 29 19:42:07 2008 @@ -0,0 +1,19 @@ +<?xml version="1.0" encoding="UTF-8" ?> + +<configuration debug="false"> + + <statusListener class="ch.qos.logback.core.status.OnConsoleStatusListener" /> + + <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> + <layout class="ch.qos.logback.classic.PatternLayout"> + <Pattern> + %d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n + </Pattern> + </layout> + </appender> + + <root level="debug"> + <appender-ref ref="STDOUT" /> + </root> + +</configuration> \ No newline at end of file Modified: logback/trunk/logback-site/src/site/pages/manual/joran.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/joran.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/joran.html Wed Oct 29 19:42:07 2008 @@ -94,7 +94,7 @@ </ol> The third and last step is meant to provide a default (but very - basic) logging functionnality in the absence of a configuration + basic) logging functionality in the absence of a configuration file. @@ -160,7 +160,7 @@ In order to run the examples in this chapter, you need to make - sure that certain jar files are present on the classpath. Please + sure that certain jar files are present on the class path. Please refer to the <a href="../setup.html">setup page</a> for further details. @@ -203,8 +203,8 @@ As mentioned earlier, logback will try to configure itself using the files logback-test.xml or logback.xml if - found on the classpath. Here is a configuration file equivalent to - the one established by <code>BasicConfigrator</code> we've just + found on the class path. Here is a configuration file equivalent to + the one established by <code>BasicConfigurator</code> we've just seen. @@ -227,7 +227,7 @@ After you have renamed sample0.xml as logback.xml (or logback-test.xml) place it into a - directory accesible from the classpath. Running the MyApp1 + directory accessible from the class path. Running the MyApp1 application should give identical results to its previous run. If and only if there are errors during the parsing of the @@ -246,9 +246,9 @@ <div class="source"><pre> public static void main(String[] args) { - logger.info("Entering application."); - // print logback's internal status + // assume SLF4J is bound to logback in the current environment LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + // print logback's internal status StatusPrinter.print(lc); ... }</pre></div> @@ -271,7 +271,7 @@ At the end of this output, you can recognize the lines that were printed in the previous example. You should also notice the logback's internal messages, a.k.a. <code>Status</code> objects, - which allow convient access to logback's internal state. + which allow convenient access to logback's internal state. Instead of invoking <code>StatusPrinter</code> programmatically @@ -282,7 +282,7 @@ configuration file, as shown below. Please note that this debug attribute relates only to the status data. It does not affect logback's configuration - otherwise, in particuler with respect to logger levels. (Put + otherwise, in particular with respect to logger levels. (Put differently, no, the root logger will not be set to <code>DEBUG</code>.) @@ -320,7 +320,7 @@ configuration file cannot be read. If the configuration file is found but is ill-formed, then logback will detect the error condition and automatically print its internal status on the - console. However, if the configration file cannot be found, since + console. However, if the configuration file cannot be found, since this is not necessarily an error condition, logback will not automatically print its status data. Programmatically invoking <code>StatusPrinter.print()</code>, as as in MyApp2 @@ -345,10 +345,10 @@ Logback relies on a configuration library called Joran which is part of logback-core. Logback's default configuration mechanism invokes JoranConfigurator on the default configuration files it - finds on the claspath. For whatever reason if you wish to override - logback's default configuration meachanism, you can do so by - invoking JoranConfigurator directly. The next application, - MyApp3, invokes JoranConfirator on a configuration file + finds on the class path. For whatever reason if you wish to + override logback's default configuration mechanism, you can do so + by invoking JoranConfigurator directly. The next application, + MyApp3, invokes JoranConfigurator on a configuration file passed as parameter. Example 3.: Invoking @@ -369,7 +369,7 @@ final static Logger logger = LoggerFactory.getLogger(MyApp3.class); public static void main(String[] args) { - // assume logback is in use + // assume SLF4J is bound to logback in the current environment LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); try { @@ -400,6 +400,65 @@ status data is printed in case errors occur. + <h3> + <a name="statusListener" href="#statusListener">Listening to + status messages</a> + </h3> + + Logback collects its internal status data in its <code><a + href="../xref/ch/qos/logback/core/status/StatusManager.html">StatusManager</a></code>, + accessible via the LoggerContext. + + + Given a <code>StatusManager</code> you an access all the status + data associated with a logback context. You may also attach a + <code>StatusListener</code> to a <code>StatusManager</code> so that + you can take immediate action in response to status messages, + especially to messages occuring after logback + configuration. Registering a status listener is a convenient way to + supervise logback's internal state without human intervention. + + + Logback ships with a <code>StatusListener</code> implementation + called <code><a + href="../xref/ch/qos/logback/core/status/OnConsoleStatusListener.html">OnConsoleStatusListener</a></code> + which, as its name indicates, prints all new incoming + status messages on the console. + + + Here is <a + href="../xref/chapter3/AddStatusListenerApp.html">sample code</a> + to register a OnConsoleStatusListener instance with the + StatusManager. + + + LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + StatusManager statusManager = lc.getStatusManager(); + OnConsoleStatusListener onConsoleListener = new OnConsoleStatusListener(); + statusManager.add(onConsoleListener); + + Note that the registered status listener will receive status + events subsequent to its registration. It will not receive prior + messages. + + It is also possible to register one or more status listeners + within a configuration file. Here is an example. + + Example 3.: Registering a status listener (logback-examples/src/main/java/chapter3/onConsoleStatusListener.xml) + + <configuration> + <statusListener class="ch.qos.logback.core.status.OnConsoleStatusListener" /> + + ... the rest of the configuration file +</configuration> + + One may also register a status listener by setting the + "logback.statusListenerClass" Java system property to the name of + the listener class you wish to register. For example, + + + java -Dlogback.statusListenerClass=ch.qos.logback.core.status.OnConsoleStatusListener ... + <h2> <a name="syntax" href="#syntax">Configuration file Syntax</a> </h2> @@ -419,8 +478,8 @@ As shall become clear, the syntax of logback configuration files is extremely flexible. As such, it is not possible specify the - allowed syntax with a DTD file or an XML Schema. Nevertheles, the - very basic structure of configration can be desribed as, + allowed syntax with a DTD file or an XML Schema. Nevertheless, the + very basic structure of configuration can be described as, <configuration> element, followed by zero or more <appender> elements, followed by by zero or more <logger> elements, followed by at most one <root> element. The following diagram illustrates @@ -436,7 +495,7 @@ A logger is configured using the <code>logger</code> element. A logger element takes exactly one mandatory name atttribute, an optional name attribute, an optional level attribute, and an optional aditivity attribute, which admits the values true or false. The value of the Configuring the roor logger, or the <code><root></code> + <h4>Configuring the root logger, or the <code><root></code> element</h4>

1 0

svn commit: r1907 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 19:12:00 2008 New Revision: 1907 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java Log: System.out.print is more appropriate as StatusPrinter.buildStr already appends a line separator Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java Wed Oct 29 19:12:00 2008 @@ -1,12 +1,28 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.core.status; import ch.qos.logback.core.util.StatusPrinter; +/** + * Print all new incoming status messages on the console. + * + * @author Ceki Gülcü + * + */ public class OnConsoleStatusListener implements StatusListener { + public void addStatusEvent(Status status) { StringBuilder sb = new StringBuilder(); StatusPrinter.buildStr(sb, "", status); - System.out.println(sb); + System.out.print(sb); } }

1 0

svn commit: r1906 - logback/trunk
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 17:57:06 2008 New Revision: 1906 Modified: logback/trunk/pom.xml Log: next release of logback should depend on SLF4J 1.5.6 Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Wed Oct 29 17:57:06 2008 @@ -36,7 +36,7 @@ <properties>  - <slf4j.version>1.5.5</slf4j.version> + <slf4j.version>1.5.6-SNAPSHOT</slf4j.version> <slf4j.ext.version>1.0-alpha0</slf4j.ext.version> <consolePlugin.version>1.1.0</consolePlugin.version> </properties>

1 0

svn commit: r1905 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 17:26:43 2008 New Revision: 1905 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java Log: - removing the "test" prefix from test methods. These are not needed for Junit4. - added copyright notice Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/util/InitializationTest.java Wed Oct 29 17:26:43 2008 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.util; @@ -45,7 +54,7 @@ // this test works only if logback-test.xml or logback.xml files are on the classpath. // However, this is something we try to avoid in order to simplify the life // of users trying to follows the manual and logback-examples from an IDE - public void testAutoconfig() { + public void atoconfig() { Appender appender = root.getAppender("STDOUT"); assertNotNull(appender); assertTrue(appender instanceof ConsoleAppender); @@ -56,7 +65,7 @@ // this test works only if logback-test.xml or logback.xml files are on the classpath. // However, this is something we try to avoid in order to simplify the life // of users trying to follows the manual and logback-examples from an IDE - public void testReset() throws JoranException { + public void reset() throws JoranException { { new ContextInitializer(lc).autoConfig(); Appender appender = root.getAppender("STDOUT"); @@ -71,7 +80,7 @@ } @Test - public void testAutoConfigFromSystemProperties() throws JoranException { + public void autoConfigFromSystemProperties() throws JoranException { doAutoConfigFromSystemProperties(TeztConstants.TEST_DIR_PREFIX + "input/autoConfig.xml"); doAutoConfigFromSystemProperties("autoConfigAsResource.xml"); // test passing a URL. note the relative path syntax with file:src/test/... @@ -87,7 +96,7 @@ } @Test - public void teztAutoStatusListener() throws JoranException { + public void autoStatusListener() throws JoranException { System.setProperty(ContextInitializer.STATUS_LISTENER_CLASS, TrivialStatusListener.class.getName()); List<StatusListener> sll = lc.getStatusManager().getCopyOfStatusListenerList(); assertEquals(0, sll.size()); @@ -97,7 +106,7 @@ } @Test - public void teztAutoOnConsoleStatusListener() throws JoranException { + public void autoOnConsoleStatusListener() throws JoranException { System.setProperty(ContextInitializer.STATUS_LISTENER_CLASS, ContextInitializer.SYSOUT); List<StatusListener> sll = lc.getStatusManager().getCopyOfStatusListenerList(); assertEquals(0, sll.size());

1 0

[JIRA] Resolved: (LBCLASSIC-51) Use of BasicStatusManager.iterator() without synchronization in ch.qos.logback.classic.jmx.Configurator
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-51?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-51. --------------------------------- Fix Version/s: 0.9.10 Resolution: Fixed > Use of BasicStatusManager.iterator() without synchronization in ch.qos.logback.classic.jmx.Configurator > ------------------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-51 > URL: http://jira.qos.ch/browse/LBCLASSIC-51 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Joern Huxhorn > Assignee: Ceki Gulcu > Fix For: 0.9.10 > > > We sometimes receive strange exceptions in our webapp: > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: Exception in thread "Thread-6" java.lang.ArrayIndexOutOfBoundsException > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.lang.System.arraycopy(Native Method) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.util.ArrayList.ensureCapacity(ArrayList.java:170) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.util.ArrayList.add(ArrayList.java:351) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.BasicStatusManager.add(BasicStatusManager.java:38) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.spi.ContextAwareBase.addStatus(ContextAwareBase.java:59) > [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.spi.ContextAwareBase.addInfo(ContextAwareBase.java:64) > I just tried to analyze the problem and found out that ch.qos.logback.classic.jmx.Configurator is simply using the iterator of the status manager without synchronizing, as it's documented in BasicStatusManager. > So instead of > public List<String> getStatuses() { > List<String> list = new ArrayList<String>(); > Iterator<Status> it = context.getStatusManager().iterator(); > while(it.hasNext()) { > list.add(it.next().toString()); > } > return list; > } > it should probably be > public List<String> getStatuses() { > List<String> list = new ArrayList<String>(); > StatusManager sm = context.getStatusManager(); > Iterator<Status> it = sm.iterator(); > synchronized(sm) { > while(it.hasNext()) { > list.add(it.next().toString()); > } > } > return list; > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Issue Comment Edited: (LBCLASSIC-57) SyslogAppender fails sporadically
by Ceki Gulcu (JIRA) 29 Oct '08

29 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-57?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu edited comment on LBCLASSIC-57 at 10/29/08 4:57 PM: --------------------------------------------------------------- Hello Anton, Would setting a hard (non-configurable) limit of say 250KB work for you? BTW, thank you for taking the time to find the root cause of the problem. was (Author: noreply.ceki(a)qos.ch) Hello Anton, Would setting a hard (non-configurable) limit of say 250KB work for you? > SyslogAppender fails sporadically > --------------------------------- > > Key: LBCLASSIC-57 > URL: http://jira.qos.ch/browse/LBCLASSIC-57 > Project: logback-classic > Issue Type: Bug > Environment: $ uname -a > Linux ... 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:56:44 EST 2007 x86_64 x86_64 x86_64 GNU/Linux > $ java -version > java version "1.6.0_03" > Java(TM) SE Runtime Environment (build 1.6.0_03-b05) > Java HotSpot(TM) Server VM (build 1.6.0_03-b05, mixed mode) > multiprocessor PC box > Reporter: Anton Tagunov > Assignee: Logback dev list > > * several JVM-s per Linux box > * 5 SyslogAppender-s logging to syslog-ng on 127.0.0.1 > Once in a while one of the SyslogAppender-s (the busiest one with longest messages) stops logging completely > Other SyslogAppender-ss continue working fine. > /usr/sbin/tcpdump has confirmed upd packets reach > syslog-ng port via 'lo' network interface for remaining appends > /usr/sbin/tcpdump has confirmed NO udp packets reach > syslog-ng port via 'lo' network interface for the failing appender > We have JMX enabled. JConsole does show StatusManager messages. > There are no error messages there. > Just the messages emitted during initial logback configuration > from logback.xml on the classpath. > We had invoked 'reload()' method via JMX. > StatusMananger messages observed via JMX show that reload had happened. > Full re-configuration had happened. > All 5 SyslogAppenders had been apparently re-created. > Yet NO udp messages had come from the SyslogAppender > replacing those which had previously failed. > Reloading did not help at all. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1904 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net
by noreply.ceki＠qos.ch 29 Oct '08

29 Oct '08

Author: ceki Date: Wed Oct 29 16:59:16 2008 New Revision: 1904 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Log: LBCLASSIC-57 Setting a message size limit of 256K. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Wed Oct 29 16:59:16 2008 @@ -28,6 +28,7 @@ public abstract class SyslogAppenderBase<E> extends AppenderBase<E> { final static String SYSLOG_LAYOUT_URL = CoreGlobal.CODES_URL + "#syslog_layout"; + final static int MSG_SIZE_LIMIT = 256*1024; Layout<E> layout; int facility; @@ -77,6 +78,9 @@ try { String msg = layout.doLayout(eventObject); + if(msg != null && msg.length() > MSG_SIZE_LIMIT) { + msg = msg.substring(0, MSG_SIZE_LIMIT); + } sw.write(msg); sw.flush(); postProcess(eventObject, sw);

1 0