- logback-dev - mailman3.qos.ch

svn commit: r1859 - logback/trunk/logback-examples
by noreply.ceki＠qos.ch 22 Oct '08

22 Oct '08

Author: ceki Date: Wed Oct 22 19:34:05 2008 New Revision: 1859 Modified: logback/trunk/logback-examples/pom.xml Log: indentation changes only Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Wed Oct 22 19:34:05 2008 @@ -1,11 +1,13 @@ -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> +<project xmlns="http://maven.apache.org/POM/4.0.0" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> <version>0.9.10-SNAPSHOT</version> </parent> - + <modelVersion>4.0.0</modelVersion> <groupId>ch.qos.logback</groupId> @@ -15,49 +17,47 @@ <name>Logback Examples Module</name> <url>http://logback.qos.ch</url> - <description> - Logback: the generic, reliable, fast and flexible logging library for Java. + <description> + Logback: the generic, reliable, fast and flexible logging + library for Java. </description> <licenses> <license> - <name> GNU Lesser General Public License</name> - <url>http://www.gnu.org/licenses/lgpl.html</url> + <name>GNU Lesser General Public License</name> + <url>http://www.gnu.org/licenses/lgpl.html</url> </license> </licenses> <dependencies> - + <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> </dependency> - + <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-classic</artifactId> </dependency> - + <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-access</artifactId> </dependency> - + <dependency> - <groupId>org.slf4j</groupId> - <artifactId>slf4j-ext</artifactId> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-ext</artifactId> </dependency> - + <dependency> <groupId>javax.servlet</groupId> <artifactId>servlet-api</artifactId> <scope>compile</scope> <optional>true</optional> </dependency> - - </dependencies> - - + </dependencies> <build> <resources> @@ -76,31 +76,30 @@ </configuration> </plugin> - <plugin> - <artifactId>maven-antrun-plugin</artifactId> - <executions> - <execution> - <phase>package</phase> - <configuration> - <tasks> - <property name="slf4jJAR" - value="${settings.localRepository}/org/slf4j/slf4j-api/${slf4j.version}/slf4j-api-${slf4j.version}.jar"/> - <echo>Copying ${slf4jJAR} to lib/</echo> - <delete> - <fileset dir="lib/" includes="slf4j-*SNAPSHOT.jar"/> - </delete> - <copy file="${slf4jJAR}" todir="lib/"/> - </tasks> - </configuration> - <goals> - <goal>run</goal> - </goals> - </execution> - </executions> - </plugin> - - - </plugins> + <plugin> + <artifactId>maven-antrun-plugin</artifactId> + <executions> + <execution> + <phase>package</phase> + <configuration> + <tasks> + <property name="slf4jJAR" + value="${settings.localRepository}/org/slf4j/slf4j-api/${slf4j.version}/slf4j-api-${slf4j.version}.jar" /> + <echo>Copying ${slf4jJAR} to lib/</echo> + <delete> + <fileset dir="lib/" + includes="slf4j-*SNAPSHOT.jar" /> + </delete> + <copy file="${slf4jJAR}" todir="lib/" /> + </tasks> + </configuration> + <goals> + <goal>run</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> </build> </project> \ No newline at end of file

1 0

svn commit: r1858 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect
by noreply.ceki＠qos.ch 22 Oct '08

22 Oct '08

Author: ceki Date: Wed Oct 22 11:04:21 2008 New Revision: 1858 Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle.sql - copied, changed from r1857, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Removed: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/db2l.sql logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Log: - Removed superfluous file db2l.sql - renamed oracle9i.sql as oracle.sql Copied: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle.sql (from r1857, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql) ============================================================================== --- /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle.sql Wed Oct 22 11:04:21 2008 @@ -1,8 +1,9 @@ -- This SQL script creates the required tables by ch.qos.logback.classic.db.DBAppender -- --- It is intended for Oracle 9i databases. Tested on version 9.2 +-- It is intended for Oracle 9i, 10g and 11g databases. Tested on version 9.2, 10g and +-- 11g. --- The following lines are useful in cleaning any previous tables +-- The following lines are useful in cleaning any previously existing tables --drop TRIGGER logging_event_id_seq_trig; --drop SEQUENCE logging_event_id_seq; @@ -29,6 +30,11 @@ ); +-- the / suffix may or may not be needed depending on your SQL Client +-- Some SQL Clients, e.g. SQuirrel SQL has trouble with the following +-- trigger creation command, while SQLPlus (the basic SQL Client which +-- ships with Oracle) has no trouble at all. + CREATE TRIGGER logging_event_id_seq_trig BEFORE INSERT ON logging_event FOR EACH ROW @@ -38,7 +44,6 @@ FROM DUAL; END; / --- the / suffix may or may not be needed depending on your SQL Client CREATE TABLE logging_event_property

1 0

[JIRA] Created: (LBGENERAL-23) add support for package version & jar name in the stack trace
by James Strachan (JIRA) 21 Oct '08

21 Oct '08

add support for package version & jar name in the stack trace ------------------------------------------------------------- Key: LBGENERAL-23 URL: http://jira.qos.ch/browse/LBGENERAL-23 Project: logback-general Issue Type: New Feature Reporter: James Strachan Assignee: Logback dev list add support for this patch... https://issues.apache.org/bugzilla/show_bug.cgi?id=45721 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 7

[JIRA] Commented: (LBCORE-15) Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03
by Ceki Gulcu (JIRA) 21 Oct '08

21 Oct '08

[ http://jira.qos.ch/browse/LBCORE-15?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu commented on LBCORE-15: ---------------------------------- I have tested the existing code on Oracle 11g (version 11.1.0.6.0) and it seems to work just fine. I'll see if I can reproduce it with Oracle 10g. > Problems getting autogenerated Keys in Oracle with Oracle JDBC 10.2.03 > ---------------------------------------------------------------------- > > Key: LBCORE-15 > URL: http://jira.qos.ch/browse/LBCORE-15 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Klaus Unger > Assignee: Logback dev list > Priority: Blocker > > I've encountered troubles logging StackTrace/MDC entries with die DBAppender on our plattform! We are using Oracle 9.2.0.6.0 on a Solaris Box with Oracle JDBC Driver 10.2.0.3! > I've debugged the processing of LogMessages into DBAppenderBase.append()! > There I found a call "con.prepareStatement(getInsertSQL())" which is followed by a call "subAppend(...)" > As far as I understand Oracle Drivers return generatedKeys only, if you use the right prepareStatement() methods, which is in my understanding the following: > PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) > throws SQLException > @see http://java.sun.com/j2se/1.5.0/docs/api/java/sql/Connection.html#prepareSta… > which is available since JDK 1.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1857 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect
by noreply.ceki＠qos.ch 21 Oct '08

21 Oct '08

Author: ceki Date: Tue Oct 21 23:25:22 2008 New Revision: 1857 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Log: minor comment Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect/oracle9i.sql Tue Oct 21 23:25:22 2008 @@ -38,6 +38,8 @@ FROM DUAL; END; / +-- the / suffix may or may not be needed depending on your SQL Client + CREATE TABLE logging_event_property (

1 0

svn commit: r1856 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 20 Oct '08

20 Oct '08

Author: ceki Date: Mon Oct 20 22:04:18 2008 New Revision: 1856 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java Log: Adapt to JUnit4 style Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PackageTest.java Mon Oct 20 22:04:18 2008 @@ -16,7 +16,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); suite.addTestSuite(LoggerContextTest.class); - suite.addTestSuite(LoggerPerfTest.class); + suite.addTest(new JUnit4TestAdapter(LoggerPerfTest.class)); suite.addTest(new JUnit4TestAdapter(DynamicLoggerContextTest.class)); suite.addTest(new JUnit4TestAdapter(PatternLayoutTest.class)); suite.addTestSuite(BasicLoggerTest.class);

1 0

svn commit: r1854 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 20 Oct '08

20 Oct '08

Author: ceki Date: Mon Oct 20 21:55:35 2008 New Revision: 1854 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Log: Related to LBCORE-58 Unsynchronized means no synchronization keyword in the doAppend method. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Mon Oct 20 21:55:35 2008 @@ -57,7 +57,7 @@ static final int ALLOWED_REPEATS = 5; - public synchronized void doAppend(E eventObject) { + public void doAppend(E eventObject) { // WARNING: The guard check MUST be the first statement in the // doAppend() method.

1 0

svn commit: r1853 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 20 Oct '08

20 Oct '08

Author: ceki Date: Mon Oct 20 21:51:43 2008 New Revision: 1853 Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java Log: LBCORE-58 UnsynchronizedAppenderBase is based on Ralph Goers contribution in LBCORE-58. Note that AppenderBase remains unchanged. Appenders which need to handle synchronization on their own can do so by deriving from UnsynchronizedAppenderBase. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/AppenderBase.java Mon Oct 20 21:51:43 2008 @@ -13,12 +13,13 @@ import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.spi.FilterAttachable; import ch.qos.logback.core.spi.FilterAttachableImpl; -import ch.qos.logback.core.spi.FilterReply; +import ch.qos.logback.core.spi.FilterReply; import ch.qos.logback.core.status.WarnStatus; /** - * This class is used to manage base functionnalities of all appenders. + * Sets a skeleton implementation for appenders. * + * <p> * For more information about this appender, please refer to the online manual at * http://logback.qos.ch/manual/appenders.html#AppenderBase * Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/UnsynchronizedAppenderBase.java Mon Oct 20 21:51:43 2008 @@ -0,0 +1,144 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ +package ch.qos.logback.core; + +import ch.qos.logback.core.filter.Filter; +import ch.qos.logback.core.spi.ContextAwareBase; +import ch.qos.logback.core.spi.FilterAttachable; +import ch.qos.logback.core.spi.FilterAttachableImpl; +import ch.qos.logback.core.spi.FilterReply; +import ch.qos.logback.core.status.WarnStatus; + +/** + * Similar to AppenderBase except that derived appenders need to handle + * thread synchronization on their own. + * + * @author Ceki Gülcü + * @author Ralph Goers + */ +abstract public class UnsynchronizedAppenderBase<E> extends ContextAwareBase implements + Appender<E>, FilterAttachable { + + protected boolean started = false; + + // using a ThreadLocal instead of a boolean add 75 nanoseconds per + // doAppend invocation. This is tolerable as doAppend takes at least a few microseconds + // on a real appender + /** + * The guard prevents an appender from repeatedly calling its own doAppend + * method. + */ + private ThreadLocal<Boolean> guard = new ThreadLocal<Boolean>() { + protected Boolean initialValue() { + return false; + } + }; + + /** + * Appenders are named. + */ + protected String name; + + private FilterAttachableImpl fai = new FilterAttachableImpl(); + + public String getName() { + return name; + } + + private int statusRepeatCount = 0; + private int exceptionCount = 0; + + static final int ALLOWED_REPEATS = 5; + + public synchronized void doAppend(E eventObject) { + // WARNING: The guard check MUST be the first statement in the + // doAppend() method. + + // prevent re-entry. + if (guard.get()) { + return; + } + + try { + guard.set(true); + + if (!this.started) { + if (statusRepeatCount++ < ALLOWED_REPEATS) { + addStatus(new WarnStatus( + "Attempted to append to non started appender [" + name + "].", + this)); + } + return; + } + + if (getFilterChainDecision(eventObject) == FilterReply.DENY) { + return; + } + + // ok, we now invoke derived class' implementation of append + this.append(eventObject); + + } catch (Exception e) { + if (exceptionCount++ < ALLOWED_REPEATS) { + addError("Appender [" + name + "] failed to append.", e); + } + } finally { + guard.set(false); + } + } + + abstract protected void append(E eventObject); + + /** + * Set the name of this appender. + */ + public void setName(String name) { + this.name = name; + } + + public void start() { + started = true; + } + + public void stop() { + started = false; + } + + public boolean isStarted() { + return started; + } + + public String toString() { + return this.getClass().getName() + "[" + name + "]"; + } + + public void addFilter(Filter newFilter) { + fai.addFilter(newFilter); + } + + public Filter getFirstFilter() { + return fai.getFirstFilter(); + } + + public void clearAllFilters() { + fai.clearAllFilters(); + } + + public FilterReply getFilterChainDecision(Object event) { + return fai.getFilterChainDecision(event); + } + + public Layout<E> getLayout() { + return null; + } + + public void setLayout(Layout<E> layout) { + } +}

1 0

[JIRA] Commented: (LBCORE-63) Deadlock when running on multiple core processors
by Ceki Gulcu (JIRA) 20 Oct '08

20 Oct '08

[ http://jira.qos.ch/browse/LBCORE-63?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu commented on LBCORE-63: ---------------------------------- Hi Ralph, I have applied your patch on my work copy. However, I suspect using ReadLocks on read operations on AppenderAttachableImpl (appenderOnLoop, getAppender, isAttached, iteratorForAppenders) and WriteLocks on write operations (addAppender, detachAndStopAllAppenders, detachAppender) would be safer although appenderOnLoop would be a bit slower and still free of interference among threads. Nevertheless, I will commit a variant of your patch in the next few minutes. > Deadlock when running on multiple core processors > ------------------------------------------------- > > Key: LBCORE-63 > URL: http://jira.qos.ch/browse/LBCORE-63 > Project: logback-core > Issue Type: Sub-task > Affects Versions: 0.9.9 > Environment: Operating System: Windows > Platform: PC > Reporter: Toni Heimala > Assignee: Ceki Gulcu > Priority: Blocker > Attachments: patch.txt, patch2.txt, patch3.txt > > > When you run logging into same file from many threads on a system that has more than one physical processor (Dual Core for example), a deadlock will occur after a while. This can not be reproduced on HyperThreading processors. Here's an example program that will demonstrate the behavior: > ----------------------------- > Main.java > ----------------------------- > import java.util.Date; > import java.util.concurrent.ScheduledThreadPoolExecutor; > import java.util.concurrent.TimeUnit; > import org.slf4j.Logger; > import org.slf4j.LoggerFactory; > import ch.qos.logback.classic.LoggerContext; > import ch.qos.logback.classic.joran.JoranConfigurator; > import ch.qos.logback.core.joran.spi.JoranException; > public class Main extends Thread > { > private final static String LOGGER_CONFIGURATION_FILE = "logger.xml"; > private final Logger logger = LoggerFactory.getLogger(Main.class); > > private final long start; > > public Main() > throws JoranException > { > start = new Date().getTime(); > LoggerContext lc = (LoggerContext)LoggerFactory.getILoggerFactory(); > JoranConfigurator configurator = new JoranConfigurator(); > lc.shutdownAndReset(); > configurator.setContext(lc); > configurator.doConfigure(LOGGER_CONFIGURATION_FILE); > } > > public void start() > { > ScheduledThreadPoolExecutor ex1 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex2 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex3 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex4 = new ScheduledThreadPoolExecutor(1); > ScheduledThreadPoolExecutor ex5 = new ScheduledThreadPoolExecutor(1); > ex1.scheduleAtFixedRate(new Task("EX1"), 10, 10, TimeUnit.MICROSECONDS); > ex2.scheduleAtFixedRate(new Task("EX2"), 10, 10, TimeUnit.MICROSECONDS); > ex3.scheduleAtFixedRate(new Task("EX3"), 10, 10, TimeUnit.MICROSECONDS); > ex4.scheduleAtFixedRate(new Task("EX4"), 10, 10, TimeUnit.MICROSECONDS); > ex5.scheduleAtFixedRate(new Task("EX5"), 10, 10, TimeUnit.MICROSECONDS); > > super.start(); > } > > public void run() > { > try > { > while(true) > { > logger.debug("[MAIN] {}", new Date().getTime() - start); > Thread.sleep(10); > } > } > catch (InterruptedException e) > { > logger.info("[MAIN]: Interrupted: {}", e.getMessage()); > } > } > > public static void main(String[] args) > { > try > { > Main main = new Main(); > main.start(); > } > catch (JoranException e) > { > System.out.println("Failed to load application: " + e.getMessage()); > } > } > } > ------------------------------- > Task.java > ------------------------------- > import java.util.Date; > import org.slf4j.Logger; > import org.slf4j.LoggerFactory; > public class Task implements Runnable > { > private final Logger logger = LoggerFactory.getLogger(Task.class); > private final Logger logger_main = LoggerFactory.getLogger(Main.class); > private final String name; > private final long start; > > public Task(final String name) > { > this.name = name; > start = new Date().getTime(); > } > public void run() > { > logger.debug("[{}] {}", name, new Date().getTime() - start); > logger_main.debug("[MAIN] - [{}] {}", name, new Date().getTime() - start); > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1851 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran
by noreply.ceki＠qos.ch 20 Oct '08

20 Oct '08

Author: ceki Date: Mon Oct 20 20:38:21 2008 New Revision: 1851 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java Log: - prevent concurrent configurations of the same Context Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java Mon Oct 20 20:38:21 2008 @@ -93,7 +93,10 @@ recorder.setContext(context); recorder.recordEvents(inputSource); buildInterpreter(); - interpreter.play(recorder.saxEventList); + // disallow simultaneous configurations of the same context + synchronized (context) { + interpreter.play(recorder.saxEventList); + } } public void doConfigure(final List<SaxEvent> eventList)

1 0