- logback-dev - mailman3.qos.ch

[JIRA] Resolved: (LBCLASSIC-48) SyslogStartConverter specifies hour as 1-12 not 0-23
by Ceki Gulcu (JIRA) 18 Oct '08

18 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-48?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-48. --------------------------------- Fix Version/s: 0.9.10 Resolution: Fixed Thanks Peter. Fixed as you suggested. > SyslogStartConverter specifies hour as 1-12 not 0-23 > ---------------------------------------------------- > > Key: LBCLASSIC-48 > URL: http://jira.qos.ch/browse/LBCLASSIC-48 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: Mac OS > Platform: All > Reporter: peter royal > Assignee: Logback dev list > Priority: Critical > Fix For: 0.9.10 > > Attachments: Syslog.diff > > > SyslogStartConverter uses 'hh' (hour in am/pm, 1-12) in its date format when it should be using 'HH' (hour in day, 0-23) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1849 - in logback/trunk: logback-classic/src/main/java/ch/qos/logback/classic/net logback-core/src/main/java/ch/qos/logback/core/net
by noreply.ceki＠qos.ch 18 Oct '08

18 Oct '08

Author: ceki Date: Sat Oct 18 21:44:13 2008 New Revision: 1849 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Log: - cosmetic changes Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java Sat Oct 18 21:44:13 2008 @@ -85,7 +85,6 @@ } } catch (IOException e) { } - } } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Sat Oct 18 21:44:13 2008 @@ -1,3 +1,13 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + package ch.qos.logback.core.net; import java.io.IOException; @@ -8,6 +18,13 @@ import ch.qos.logback.core.CoreGlobal; import ch.qos.logback.core.Layout; +/** + * Base class for SyslogAppender. + * + * @author Ceki G&uumllcü + * + * @param <E> + */ public abstract class SyslogAppenderBase<E> extends AppenderBase<E> { final static String SYSLOG_LAYOUT_URL = CoreGlobal.CODES_URL + "#syslog_layout";

1 0

svn commit: r1848 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern
by noreply.ceki＠qos.ch 18 Oct '08

18 Oct '08

Author: ceki Date: Sat Oct 18 21:43:11 2008 New Revision: 1848 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java Log: Fixing date format as suggested in LBCLASSIC-48 by Peter Royal. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/SyslogStartConverter.java Sat Oct 18 21:43:11 2008 @@ -41,7 +41,8 @@ localHostName = getLocalHostname(); try { - simpleFormat = new SimpleDateFormat("MMM dd hh:mm:ss", new DateFormatSymbols(Locale.US)); + // hours should be in 0-23, see also http://jira.qos.ch/browse/LBCLASSIC-48 + simpleFormat = new SimpleDateFormat("MMM dd HH:mm:ss", new DateFormatSymbols(Locale.US)); } catch (IllegalArgumentException e) { addError("Could not instantiate SimpleDateFormat", e); errorCount++;

1 0

svn commit: r1847 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net
by noreply.ceki＠qos.ch 18 Oct '08

18 Oct '08

Author: ceki Date: Sat Oct 18 21:31:14 2008 New Revision: 1847 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java Log: The prefixPattern variable is internal to the buildLayout() method. This change is related to LBCORE-52. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SyslogAppender.java Sat Oct 18 21:31:14 2008 @@ -31,15 +31,13 @@ */ public class SyslogAppender extends SyslogAppenderBase<LoggingEvent> { - String prefixPattern; - PatternLayout prefixLayout; - static final public String DEFAULT_SUFFIX_PATTERN = "[%thread] %logger %msg"; - public Layout<LoggingEvent> buildLayout(String facilityStr) { + PatternLayout prefixLayout = new PatternLayout(); - prefixPattern = "%syslogStart{" + facilityStr + "}%nopex"; - prefixLayout = new PatternLayout(); + public Layout<LoggingEvent> buildLayout(String facilityStr) { + String prefixPattern = "%syslogStart{" + facilityStr + "}%nopex"; + prefixLayout.getInstanceConverterMap().put("syslogStart", SyslogStartConverter.class.getName()); prefixLayout.setPattern(prefixPattern);

1 0

svn commit: r1846 - in logback/trunk/logback-core/src/test: input/joran/skip java/ch/qos/logback/core/joran java/ch/qos/logback/core/joran/action/ext
by noreply.ceki＠qos.ch 18 Oct '08

18 Oct '08

Author: ceki Date: Sat Oct 18 21:09:55 2008 New Revision: 1846 Modified: logback/trunk/logback-core/src/test/input/joran/skip/badEnd2.xml logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java Log: LBCLASSIC-63 LBCORE-38 Test that Joran does continues processing in presence of errors and that it registers status messages Modified: logback/trunk/logback-core/src/test/input/joran/skip/badEnd2.xml ============================================================================== --- logback/trunk/logback-core/src/test/input/joran/skip/badEnd2.xml (original) +++ logback/trunk/logback-core/src/test/input/joran/skip/badEnd2.xml Sat Oct 18 21:09:55 2008 @@ -8,7 +8,7 @@ <badEnd type="ActionException"> <touch/> </badEnd> -  +  <touch/> </isolate> Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java Sat Oct 18 21:09:55 2008 @@ -1,7 +1,7 @@ /** * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 1999-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free @@ -11,8 +11,10 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; import java.util.HashMap; +import java.util.List; import javax.xml.parsers.SAXParser; import javax.xml.parsers.SAXParserFactory; @@ -24,15 +26,18 @@ import ch.qos.logback.core.joran.action.Action; import ch.qos.logback.core.joran.action.NOPAction; import ch.qos.logback.core.joran.action.ext.BadBeginAction; +import ch.qos.logback.core.joran.action.ext.BadEndAction; import ch.qos.logback.core.joran.action.ext.HelloAction; import ch.qos.logback.core.joran.action.ext.TouchAction; +import ch.qos.logback.core.joran.spi.ActionException; import ch.qos.logback.core.joran.spi.Pattern; +import ch.qos.logback.core.status.Status; +import ch.qos.logback.core.status.StatusManager; import ch.qos.logback.core.util.Constants; -import ch.qos.logback.core.util.StatusPrinter; /** - * Test the way Interpreter skips elements in case of exceptions thrown by - * Actions. + * Test the way Interpreter skips child elements in case of exceptions thrown by + * Actions. It also tests addition of status messages in case of exceptions. * * @author Ceki Gulcu */ @@ -40,66 +45,67 @@ HashMap<Pattern, Action> rulesMap = new HashMap<Pattern, Action>(); Context context = new ContextBase(); + StatusManager sm = context.getStatusManager(); SAXParser createParser() throws Exception { SAXParserFactory spf = SAXParserFactory.newInstance(); return spf.newSAXParser(); } - void doTest(String filename) throws Exception { + void doTest(String filename, Integer expectedInt, Class exceptionClass) + throws Exception { rulesMap.put(new Pattern("test"), new NOPAction()); rulesMap.put(new Pattern("test/badBegin"), new BadBeginAction()); rulesMap.put(new Pattern("test/badBegin/touch"), new TouchAction()); + rulesMap.put(new Pattern("test/badEnd"), new BadEndAction()); + rulesMap.put(new Pattern("test/badEnd/touch"), new TouchAction()); + rulesMap.put(new Pattern("test/hello"), new HelloAction()); + + rulesMap.put(new Pattern("test/isolate"), new NOPAction()); + rulesMap.put(new Pattern("test/isolate/badEnd"), new BadEndAction()); + rulesMap.put(new Pattern("test/isolate/badEnd/touch"), new TouchAction()); + rulesMap.put(new Pattern("test/isolate/touch"), new TouchAction()); rulesMap.put(new Pattern("test/hello"), new HelloAction()); TrivialConfigurator tc = new TrivialConfigurator(rulesMap); tc.setContext(context); - tc .doConfigure(Constants.TEST_DIR_PREFIX - + "input/joran/skip/"+filename); + tc.doConfigure(Constants.TEST_DIR_PREFIX + "input/joran/skip/" + filename); - String str = context.getProperty("hello"); + String str = context.getProperty(HelloAction.PROPERTY_KEY); assertEquals("Hello John Doe.", str); - Object i = (String) context.getObject(TouchAction.KEY); - assertNull(i); - - StatusPrinter.print(context); + Integer i = (Integer) context.getObject(TouchAction.KEY); + if (expectedInt == null) { + assertNull(i); + } else { + assertEquals(expectedInt, i); + } + + // check the existence of an ERROR status + List<Status> statusList = sm.getCopyOfStatusList(); + Status s0 = statusList.get(0); + assertEquals(Status.ERROR, s0.getLevel()); + assertTrue(s0.getThrowable().getClass() == exceptionClass); } - /** - * Tests that whenever an action throws a RuntimeException, processing of - * child elements is skipped. - */ @Test public void testSkippingRuntimeExInBadBegin() throws Exception { - doTest("badBegin1.xml"); + doTest("badBegin1.xml", null, IllegalStateException.class); } - /** - * Tests that whenever an action throws a RuntimeException, processing of - * child elements is skipped. - */ @Test public void testSkippingActionExInBadBegin() throws Exception { - doTest("badBegin2.xml"); + doTest("badBegin2.xml", null, ActionException.class); } - /** - * A RuntimeException thrown by the end() method of an action will be caught without - * further consequences (as there are no children). - */ @Test public void testSkippingRuntimeExInBadEnd() throws Exception { - doTest("badEnd1.xml"); + doTest("badEnd1.xml", new Integer(2), IllegalStateException.class); } - /** - * An ActionException thrown by the end() method of an action will be caught without - * further consequences (as there are no children). - */ @Test public void testSkippingActionExInBadEnd() throws Exception { - doTest("badEnd2.xml"); + doTest("badEnd2.xml", new Integer(2), ActionException.class); } } Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java Sat Oct 18 21:09:55 2008 @@ -22,7 +22,7 @@ public class BadEndAction extends Action { static String EXCEPTION_TYPE = "type"; - static final int RUNTIME_EDXCEPTION = 0; + static final int RUNTIME_EXCEPTION = 0; static final int ACTION_EXCEPTION = 1; int type; @@ -30,7 +30,7 @@ public void begin(InterpretationContext ec, String name, Attributes attributes) { String exType = attributes.getValue(EXCEPTION_TYPE); - type = RUNTIME_EDXCEPTION; + type = RUNTIME_EXCEPTION; if("ActionException".equals(exType)) { type = ACTION_EXCEPTION; } Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java Sat Oct 18 21:09:55 2008 @@ -19,6 +19,8 @@ public class HelloAction extends Action { + static final public String PROPERTY_KEY = "name"; + public HelloAction() { } /** @@ -27,7 +29,7 @@ */ public void begin(InterpretationContext ec, String name, Attributes attributes) { String str = "Hello "+attributes.getValue("name")+"."; - ec.getContext().putProperty("hello", str); + ec.getContext().putProperty(PROPERTY_KEY, str); } /**

1 0

[JIRA] Resolved: (LBCORE-47) JMS Appender Fails - Odd Interaction with Commons Logging
by Ceki Gulcu (JIRA) 17 Oct '08

17 Oct '08

[ http://jira.qos.ch/browse/LBCORE-47?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-47. ------------------------------ Resolution: Fixed Problem fixed with the release of SLF4J 1.5.4. > JMS Appender Fails - Odd Interaction with Commons Logging > --------------------------------------------------------- > > Key: LBCORE-47 > URL: http://jira.qos.ch/browse/LBCORE-47 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: todd orr > Assignee: Ceki Gulcu > Priority: Blocker > Attachments: testbed.zip > > > I'm not sure exactly what's going on, but I've been able to determine that the JMS appender doesn't work under certain circumstances due to some interaction with commons logging. > Here is my maven POM: > <?xml version="1.0" encoding="UTF-8"?> > <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> > <modelVersion>4.0.0</modelVersion> > <groupId>foo.bar</groupId> > <artifactId>testbed</artifactId> > <name>Testbed</name> > <packaging>jar</packaging> > <version>0.1-SNAPSHOT</version> > <build> > <plugins> > <plugin> > <artifactId>maven-compiler-plugin</artifactId> > <configuration> > <source>1.5</source> > <target>1.5</target> > </configuration> > </plugin> > </plugins> > </build> > <dependencies> > <dependency> > <groupId>org.apache.activemq</groupId> > <artifactId>activemq-core</artifactId> > <version>5.0.0</version> > <exclusions> > <exclusion> > <groupId>commons-logging</groupId> > <artifactId>commons-logging</artifactId> > </exclusion> > <exclusion> > <groupId>commons-logging</groupId> > <artifactId>commons-logging-api</artifactId> > </exclusion> > </exclusions> > </dependency> > <dependency> > <groupId>org.slf4j</groupId> > <artifactId>slf4j-api</artifactId> > <version>1.4.3</version> > </dependency> > <dependency> > <groupId>org.slf4j</groupId> > <artifactId>jcl104-over-slf4j</artifactId> > <version>1.4.3</version> > </dependency> > <dependency> > <groupId>ch.qos.logback</groupId> > <artifactId>logback-core</artifactId> > <version>0.9.9</version> > </dependency> > <dependency> > <groupId>ch.qos.logback</groupId> > <artifactId>logback-classic</artifactId> > <version>0.9.9</version> > </dependency> > </dependencies> > </project> > Here is my logback config: > <configuration debug="true"> > <appender name="STDOUT" > class="ch.qos.logback.core.ConsoleAppender"> > <layout class="ch.qos.logback.classic.PatternLayout"> > <Pattern> > %d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n > </Pattern> > </layout> > </appender> >  > <root> > <level value="TRACE" /> > <appender-ref ref="STDOUT" /> > </root> > </configuration> > Uncommenting the QUEUE appender results in the following stack trace: > Failed to instantiate [ch.qos.logback.classic.LoggerContext] > Reported exception: > java.lang.ExceptionInInitializerError > at org.apache.activemq.ActiveMQConnectionFactory.<init>(ActiveMQConnectionFactory.java:88) > at org.apache.activemq.ActiveMQConnectionFactory.<init>(ActiveMQConnectionFactory.java:121) > at org.apache.activemq.ActiveMQConnectionFactory.<init>(ActiveMQConnectionFactory.java:117) > at org.apache.activemq.jndi.ActiveMQInitialContextFactory.createConnectionFactory(ActiveMQInitialContextFactory.java:201) > at org.apache.activemq.jndi.ActiveMQInitialContextFactory.createConnectionFactory(ActiveMQInitialContextFactory.java:140) > at org.apache.activemq.jndi.ActiveMQInitialContextFactory.getInitialContext(ActiveMQInitialContextFactory.java:65) > at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:667) > at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:247) > at javax.naming.InitialContext.init(InitialContext.java:223) > at javax.naming.InitialContext.<init>(InitialContext.java:197) > at ch.qos.logback.core.net.JMSAppenderBase.buildJNDIContext(JMSAppenderBase.java:49) > at ch.qos.logback.classic.net.JMSQueueAppender.start(JMSQueueAppender.java:89) > at ch.qos.logback.core.joran.action.AppenderAction.end(AppenderAction.java:89) > at ch.qos.logback.core.joran.spi.Interpreter.callEndAction(Interpreter.java:310) > at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:173) > at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:154) > at ch.qos.logback.core.joran.spi.EventPlayer.play(EventPlayer.java:48) > at ch.qos.logback.core.joran.spi.Interpreter.play(Interpreter.java:336) > at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:96) > at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:74) > at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:38) > at ch.qos.logback.classic.util.ContextInitializer.configureByResource(ContextInitializer.java:23) > at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:34) > at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:43) > at org.slf4j.impl.StaticLoggerBinder.initialize(StaticLoggerBinder.java:62) > at org.slf4j.impl.StaticLoggerBinder.<init>(StaticLoggerBinder.java:53) > at org.slf4j.impl.StaticLoggerBinder.<clinit>(StaticLoggerBinder.java:48) > at org.slf4j.LoggerFactory.<clinit>(LoggerFactory.java:60) > at foo.bar.testbed.LoggerTester.main(LoggerTester.java:9) > Caused by: java.lang.IllegalStateException: Logging factory implementation cannot be null. See also http://www.slf4j.org/codes.html#null_LF > at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:86) > at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:155) > at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:131) > at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:204) > at org.apache.activemq.ActiveMQPrefetchPolicy.<clinit>(ActiveMQPrefetchPolicy.java:30) > ... 29 more > Failed to instantiate logger [ch.qos.logback.classic.selector.ContextSelector] > Reported exception: > java.lang.IllegalStateException: contextSelector cannot be null. See also http://logback.qos.ch/codes.html#null_CS > at org.slf4j.impl.StaticLoggerBinder.getLoggerFactory(StaticLoggerBinder.java:98) > at org.slf4j.LoggerFactory.<clinit>(LoggerFactory.java:60) > at foo.bar.testbed.LoggerTester.main(LoggerTester.java:9) > Exception in thread "main" java.lang.IllegalStateException: Logging factory implementation cannot be null. See also http://www.slf4j.org/codes.html#null_LF > at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:101) > at foo.bar.testbed.LoggerTester.main(LoggerTester.java:9) > However, removing the SLF4J commons bridge and un-excluding the commons libs from activemq results in the correct behavior. At this point the commons logging is not running through SLF4J at this point. So this is not desirable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1845 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:47:24 2008 New Revision: 1845 Modified: logback/trunk/logback-site/src/site/pages/news.html Log: refer to the correct issue Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Fri Oct 17 23:47:24 2008 @@ -103,7 +103,7 @@ Fixed issue <a - href="http://jira.qos.ch/browse/LBCORE-27">LBCORE-55</a> reported by + href="http://jira.qos.ch/browse/LBCORE-55">LBCORE-55</a> reported by Natan Cox. <code>WriterAppender</code> now outputs its presentation footer and file footer in the the correct order.

1 0

svn commit: r1844 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:45:58 2008 New Revision: 1844 Modified: logback/trunk/logback-site/src/site/pages/news.html Log: various updates Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Fri Oct 17 23:45:58 2008 @@ -29,7 +29,7 @@ <hr width="80%" align="center" /> - <h3>XXth of September 2008 - Release of version 0.9.10</h3> + <h3>XXth of October 2008 - Release of version 0.9.10</h3> In case of errors during initialization, logback-classic now automatically prints out its internal status. This has been @@ -60,6 +60,8 @@ developpers list. +  + Fixed issue <a href="http://jira.qos.ch/browse/LBCORE-48">LBCORE-48</a>. During rollover, compression of large files would bring all logging to a @@ -77,16 +79,44 @@ href="http://jira.qos.ch/browse/LBCORE-42">LBCORE-42</a>. If the parent directory of the log file does not exist, then FileAppender will create it, including any necessary but nonexistent parent - directories. + directories. + + + Fixed issue <a + href="http://jira.qos.ch/browse/LBCORE-17">LBCORE-17</a> reported by + Thorbjørn Ravn Andersen. Logback now relies on Geronimo JMS + API specifications instead of Sun's JMS API specification, the + latter requiring manual installation. With Geronimo JMS, logback can + be built using Maven without needing to manually install any + dependencies. + + + Fixed issue <a + href="http://jira.qos.ch/browse/LBCORE-23">LBCORE-23</a>. In + PatternLayout, parenthesis can be used to group conversion + patterns. It follows that the '(' and ')' carry special meaning and + need to be escaped to be used as literals. This is now properly + documented. + + + <a href="http://jira.qos.ch/browse/LBCORE-32">LBCORE-32</a> + + + Fixed issue <a + href="http://jira.qos.ch/browse/LBCORE-27">LBCORE-55</a> reported by + Natan Cox. <code>WriterAppender</code> now outputs its presentation + footer and file footer in the the correct order. Fixed issue <a href="http://jira.qos.ch/browse/LBCORE-27">LBCORE-27</a> reported by - Peter Royal. SMTPAppender now outputs its presentation footer and - file footer in the the correct order. + Peter Royal. <code>SMTPAppender</code> now outputs its presentation + footer and file footer in the the correct order. +  + Fixed issue <a href="http://jira.qos.ch/browse/LBCLASSIC-67">LBCLASSIC-67</a> reported by Alessandro Fustini. SMTPAppender now correctly @@ -114,17 +144,7 @@ command and SSL connections. - Fixed issue <a - href="http://jira.qos.ch/browse/LBCORE-17">LBCORE-17</a> - reported by Thorbjørn Ravn Andersen. Logback now relies on - Geronimo JMS API specifications instead of Sun's JMS API - specification, the latter requiring manual installation. With - Geronimo JMS, logback can be built using Maven without needing to - manually install any dependencies. - - - <a href="http://jira.qos.ch/browse/LBCORE-32">LBCORE-32</a> - + <a href="http://jira.qos.ch/browse/LBCLASSIC-53">LBCLASSIC-53</a>

1 0

svn commit: r1843 - logback/trunk
by noreply.ceki＠qos.ch 17 Oct '08

17 Oct '08

Author: ceki Date: Fri Oct 17 23:45:34 2008 New Revision: 1843 Modified: logback/trunk/pom.xml Log: SLF4J 1.5.5 has been released Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Fri Oct 17 23:45:34 2008 @@ -36,7 +36,7 @@ <properties>  - <slf4j.version>1.5.4-SNAPSHOT</slf4j.version> + <slf4j.version>1.5.5</slf4j.version> <slf4j.ext.version>1.0-alpha0</slf4j.ext.version> <consolePlugin.version>1.1.0</consolePlugin.version> </properties>

1 0

[JIRA] Created: (LBCORE-55) getPresentationFooter and getFileFooter are swapped
by Natan Cox (JIRA) 17 Oct '08

17 Oct '08

getPresentationFooter and getFileFooter are swapped --------------------------------------------------- Key: LBCORE-55 URL: http://jira.qos.ch/browse/LBCORE-55 Project: logback-core Issue Type: Bug Components: Appender Reporter: Natan Cox Assignee: Logback dev list If I look into the code I can see in WriterAppender writeFooter String h = layout.getFileFooter(); if ((h != null) && (this.writer != null)) { try { this.writer.write(h); String pf = layout.getPresentationFooter(); if (pf != null) { this.writer.write(pf); } And if I look into HTMLLayoutBase I see getFileFooter => </body></html> getPresentationFooter => </table> which means we are first closing the HTML and then the TABLE? Fix: String pf = layout.getPresentationFooter(); if ((pf != null) && (this.writer != null)) { try { this.writer.write(pf); String h = layout.getFileFooter(); if (h != null) { this.writer.write(h); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1