[JIRA] (LOGBACK-718) Support Eclipse buddy policy for loading logback.xml
Hi Gunnar, Ekke, FYI, since a few days, we started publishing a composite p2 repository at http://logback.qos.ch/p2/. It contains two child repositories, called "proper" and "beagle". The "beagle" repo publishes the logback-beagle plugin which is a console-like view for logging. The "proper" repository publishes bundles for slf4j-api, logback-core and logback-classic. OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ? Your comments are most welcome, [1] http://devblog.virtage.com/2012/07/logback-and-eclipse-attaching-logback-xml... -- Ceki http://twitter.com/#!/ceki
Am 10.07.2012 14:10, schrieb ceki:
OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ?
Supporting it does no harm. It's Equinox specific, though. Thus, I'd recommend the fragment approach. BTW, an interesting feature would be supporting multiple logback.xml "fragments", i.e. handle (merge?) appenders/logger configuration from multiple buddies/fragments/applications. -Gunnar -- Gunnar Wagenknecht gunnar@wagenknecht.org http://wagenknecht.org/
Hi, I think also that, the fragment approach is the better one. Eclipse-BuddyPolicy is Equinox specific and deprecated, the generic OSGi pendant is Bundle-BuddyPolicy.
BTW, an interesting feature would be supporting multiple logback.xml "fragments", i.e. handle (merge?) appenders/logger configuration from multiple buddies/fragments/applications. Hm, interessant thought ... logger/appender naming conflics could be resolved by enhancing names with plugin/fragments ids.
Christian 2012/7/10 Gunnar Wagenknecht <gunnar@wagenknecht.org>:
Am 10.07.2012 14:10, schrieb ceki:
OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ?
Supporting it does no harm. It's Equinox specific, though. Thus, I'd recommend the fragment approach.
BTW, an interesting feature would be supporting multiple logback.xml "fragments", i.e. handle (merge?) appenders/logger configuration from multiple buddies/fragments/applications.
-Gunnar
-- Gunnar Wagenknecht gunnar@wagenknecht.org http://wagenknecht.org/
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
Christian, Gunnar, Thank you both for your answers. I think two different but mostly equivalent ways for providing logback.xml will increase user confusion. We can add Bundle-BuddyPolicy in the future if the need arises. BYW, logback already fully supports file inclusion. See [1]. [1] http://logback.qos.ch/manual/configuration.html#fileInclusion -- Ceki http://twitter.com/#!/ceki On 10.07.2012 15:28, Christian Trutz wrote:
Hi,
I think also that, the fragment approach is the better one. Eclipse-BuddyPolicy is Equinox specific and deprecated, the generic OSGi pendant is Bundle-BuddyPolicy.
BTW, an interesting feature would be supporting multiple logback.xml "fragments", i.e. handle (merge?) appenders/logger configuration from multiple buddies/fragments/applications. Hm, interessant thought ... logger/appender naming conflics could be resolved by enhancing names with plugin/fragments ids.
Christian
2012/7/10 Gunnar Wagenknecht <gunnar@wagenknecht.org>:
Am 10.07.2012 14:10, schrieb ceki:
OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ?
Supporting it does no harm. It's Equinox specific, though. Thus, I'd recommend the fragment approach.
BTW, an interesting feature would be supporting multiple logback.xml "fragments", i.e. handle (merge?) appenders/logger configuration from multiple buddies/fragments/applications.
-Gunnar
Hello guys, I asked at equinox-dev and it seems there's no Bundle-BuddyPolicy header in OSGi standard (my question listed in [1] and). Moreover there's nothing wrong with Eclipse-BuddyPolicy (except it's Eclipse-specific). It should be deprecated - at least as far as I know. Whether it's good idea to include this Equinox specific header is different question. My personal state is to include it because * other OSGi frameworks will ignore this header * for Equinox OSGi it doesn't mean any significant load * users wishing to go "buddy classloading policy" way will not have to edit manually unpack JAR, modify MANIFEST.MF headers and pack it as JAR again. [1] http://dev.eclipse.org/mhonarc/lists/equinox-dev/msg07228.html -- Have a nice day! Libor Jelinek http://devblog.virtage.com/libor-jelinek/ On Tue, Jul 10, 2012 at 2:10 PM, ceki <ceki@qos.ch> wrote:
Hi Gunnar, Ekke,
FYI, since a few days, we started publishing a composite p2 repository at http://logback.qos.ch/p2/. It contains two child repositories, called "proper" and "beagle". The "beagle" repo publishes the logback-beagle plugin which is a console-like view for logging. The "proper" repository publishes bundles for slf4j-api, logback-core and logback-classic.
OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ?
Your comments are most welcome,
[1] http://devblog.virtage.com/**2012/07/logback-and-eclipse-** attaching-logback-xml/<http://devblog.virtage.com/2012/07/logback-and-eclipse-attaching-logback-xml/>
-- Ceki http://twitter.com/#!/ceki
Forwarding Libor Jelinek's message for your information. -------- Original Message -------- Return-Path: <ljelinek@virtage.com> Subject: Re: [logback-dev] [JIRA] (LOGBACK-718) Support Eclipse buddy policy for loading logback.xml To: ceki <ceki@qos.ch> Cc: logback developers list <logback-dev@qos.ch> Content-Type: multipart/alternative; boundary=bcaec5015e77073a9404c48075c8 X-Gm-Message-State: ALoCoQn6gDPEV49ZVeKAYdWOD3eSojTZr3EPEVpUC2nehFFSoKVHwkfLz988caxf7NbrmHBi+26D Hello guys, I asked at equinox-dev and it seems there's no Bundle-BuddyPolicy header in OSGi standard (my question listed in [1] and). Moreover there's nothing wrong with Eclipse-BuddyPolicy (except it's Eclipse-specific). It should be deprecated - at least as far as I know. Whether it's good idea to include this Equinox specific header is different question. My personal state is to include it because * other OSGi frameworks will ignore this header * for Equinox OSGi it doesn't mean any significant load * users wishing to go "buddy classloading policy" way will not have to edit manually unpack JAR, modify MANIFEST.MF headers and pack it as JAR again. [1] http://dev.eclipse.org/mhonarc/lists/equinox-dev/msg07228.html -- Have a nice day! Libor Jelinek http://devblog.virtage.com/libor-jelinek/ On Tue, Jul 10, 2012 at 2:10 PM, ceki <ceki@qos.ch <mailto:ceki@qos.ch>> wrote: Hi Gunnar, Ekke, FYI, since a few days, we started publishing a composite p2 repository at http://logback.qos.ch/p2/. It contains two child repositories, called "proper" and "beagle". The "beagle" repo publishes the logback-beagle plugin which is a console-like view for logging. The "proper" repository publishes bundles for slf4j-api, logback-core and logback-classic. OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ? Your comments are most welcome, [1] http://devblog.virtage.com/__2012/07/logback-and-eclipse-__attaching-logback... <http://devblog.virtage.com/2012/07/logback-and-eclipse-attaching-logback-xml/> -- Ceki http://twitter.com/#!/ceki
Dammit! A typo - it SHOULD NOT BE deprecated. Ceki, please re-post it also. Thanks a good night to Switzerland! Libor On Tue, Jul 10, 2012 at 11:31 PM, Libor Jelinek <ljelinek@virtage.com>wrote:
Hello guys, I asked at equinox-dev and it seems there's no Bundle-BuddyPolicy header in OSGi standard (my question listed in [1] and).
Moreover there's nothing wrong with Eclipse-BuddyPolicy (except it's Eclipse-specific). It should be deprecated - at least as far as I know.
Whether it's good idea to include this Equinox specific header is different question. My personal state is to include it because * other OSGi frameworks will ignore this header * for Equinox OSGi it doesn't mean any significant load * users wishing to go "buddy classloading policy" way will not have to edit manually unpack JAR, modify MANIFEST.MF headers and pack it as JAR again.
[1] http://dev.eclipse.org/mhonarc/lists/equinox-dev/msg07228.html
-- Have a nice day! Libor Jelinek http://devblog.virtage.com/libor-jelinek/
On Tue, Jul 10, 2012 at 2:10 PM, ceki <ceki@qos.ch> wrote:
Hi Gunnar, Ekke,
FYI, since a few days, we started publishing a composite p2 repository at http://logback.qos.ch/p2/. It contains two child repositories, called "proper" and "beagle". The "beagle" repo publishes the logback-beagle plugin which is a console-like view for logging. The "proper" repository publishes bundles for slf4j-api, logback-core and logback-classic.
OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ?
Your comments are most welcome,
[1] http://devblog.virtage.com/**2012/07/logback-and-eclipse-** attaching-logback-xml/<http://devblog.virtage.com/2012/07/logback-and-eclipse-attaching-logback-xml/>
-- Ceki http://twitter.com/#!/ceki
Hi Libor, sorry for my incorrect information. You're absolutely right, there is no Bundle-BuddyPolicy header. Christian Am 11.07.2012 um 00:23 schrieb Libor Jelinek:
Dammit! A typo - it SHOULD NOT BE deprecated.
Ceki, please re-post it also.
Thanks a good night to Switzerland! Libor
On Tue, Jul 10, 2012 at 11:31 PM, Libor Jelinek <ljelinek@virtage.com> wrote: Hello guys, I asked at equinox-dev and it seems there's no Bundle-BuddyPolicy header in OSGi standard (my question listed in [1] and).
Moreover there's nothing wrong with Eclipse-BuddyPolicy (except it's Eclipse-specific). It should be deprecated - at least as far as I know.
Whether it's good idea to include this Equinox specific header is different question. My personal state is to include it because * other OSGi frameworks will ignore this header * for Equinox OSGi it doesn't mean any significant load * users wishing to go "buddy classloading policy" way will not have to edit manually unpack JAR, modify MANIFEST.MF headers and pack it as JAR again.
[1] http://dev.eclipse.org/mhonarc/lists/equinox-dev/msg07228.html
-- Have a nice day! Libor Jelinek http://devblog.virtage.com/libor-jelinek/
On Tue, Jul 10, 2012 at 2:10 PM, ceki <ceki@qos.ch> wrote: Hi Gunnar, Ekke,
FYI, since a few days, we started publishing a composite p2 repository at http://logback.qos.ch/p2/. It contains two child repositories, called "proper" and "beagle". The "beagle" repo publishes the logback-beagle plugin which is a console-like view for logging. The "proper" repository publishes bundles for slf4j-api, logback-core and logback-classic.
OSGi bundles still need a way to pass logback-classic a configuration file. Several technical for achieving this are explained by Libor Jelinek at [1]. I think logback-classic should support Eclipse buddy policy. Would you have any objections if I added "Eclipse-BuddyPolicy: registered" to logback-classic.jar's MANIFEST ?
Your comments are most welcome,
[1] http://devblog.virtage.com/2012/07/logback-and-eclipse-attaching-logback-xml...
-- Ceki http://twitter.com/#!/ceki
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev
participants (7)
-
ceki -
Ceki Gulcu (JIRA) -
Christian Trutz -
Christian Trutz -
Gunnar Wagenknecht -
Libor Jelinek -
Libor Jelinek (JIRA)