February 2010 - slf4j-dev - mailman3.qos.ch

[Bug 168] New: Category.log(String FQCN, Priority p, Object msg, Throwable t) method throws UnsupportedOperationException
by bugzilla-daemon＠pixie.qos.ch 25 Feb '10

25 Feb '10

http://bugzilla.slf4j.org/show_bug.cgi?id=168 Summary: Category.log(String FQCN, Priority p, Object msg, Throwable t) method throws UnsupportedOperationException Product: SLF4J Version: 1.5.x Platform: PC OS/Version: Windows NT Status: NEW Severity: major Priority: P1 Component: log4j-over-slf4j AssignedTo: slf4j-dev(a)qos.ch ReportedBy: listid(a)qos.ch Seth Call reports: http://www.qos.ch/pipermail/slf4j-user/2010-February/000889.html It appears that but not certain that a logback appender is invoking a library using log4j during its initialization which retrieves a NOPLogger. See http://www.qos.ch/pipermail/slf4j-user/2010-February/000892.html Solution is to change the Category.log(String FQCN, Priority p, Object msg, Throwable t) method from public void log(String FQCN, Priority p, Object msg, Throwable t) { int levelInt = priorityToLevelInt(p); differentiatedLog(null, FQCN, levelInt, msg, t); } public void log(String FQCN, Priority p, Object msg, Throwable t) { int levelInt = priorityToLevelInt(p); if (locationAwareLogger != null) { locationAwareLogger.log(null, FQCN, levelInt, convertToString(msg), t); } else { throw new UnsupportedOperationException("The logger [" + slf4jLogger + "] does not seem to be location aware."); } } -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

Release of SLF4J version 1.5.11
by Ceki Gülcü 25 Feb '10

25 Feb '10

Hello all, I am happy to announce the immediate availability of SLF4J version 1.5.11 consisting of bug fixes and minor enhancements. It is totally compatible with SLF4J version 1.5.10. Please refer to the the news page for precise details. http://www.slf4j.org/news.html You can download SLF4J, including full source code, class files and documentation on our download page, shown below. http://www.slf4j.org/download.html You can receive SLF4J related announcements by subscribing to the SLF4J announce mailing list. To subscribe to QOS.ch announce list, please visit the following URL. http://www.qos.ch/mailman/listinfo/announce -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch, master, updated. v1.5.9.RC1-23-gdae55b8
by git-noreply＠pixie.qos.ch 25 Feb '10

25 Feb '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via dae55b822906cbb5b701e6f58199e9b50c0e2df8 (commit) from 99c9eb8a756df79e94234f00a348b0ee6222098e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=dae55b822906cbb5b701e6f581… http://github.com/ceki/slf4j/commit/dae55b822906cbb5b701e6f58199e9b50c0e2df8 commit dae55b822906cbb5b701e6f58199e9b50c0e2df8 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Feb 25 12:42:32 2010 +0100 - preparing release 1.5.11 - added code to detect the simultaneous presence of both log4j-over-slf4j.jar and slf4j-log4j12.jar. See also http://slf4j.org/codes.html#log4jDelegationLoop - added code to detect the simultaneous presence of both jcl-over-slf4j.jar and slf4j-jcl.jar. See also http://slf4j.org/codes.html#jclDelegationLoop - Fixed http://bugzilla.slf4j.org/show_bug.cgi?id=168 diff --git a/integration/pom.xml b/integration/pom.xml index b5e2ef7..baff429 100644 --- a/integration/pom.xml +++ b/integration/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/jcl-over-slf4j/pom.xml b/jcl-over-slf4j/pom.xml index cac58f7..0d67bbb 100644 --- a/jcl-over-slf4j/pom.xml +++ b/jcl-over-slf4j/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/jcl104-over-slf4j/pom.xml b/jcl104-over-slf4j/pom.xml index 5ce0a74..f8f8d4e 100644 --- a/jcl104-over-slf4j/pom.xml +++ b/jcl104-over-slf4j/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/jul-to-slf4j/pom.xml b/jul-to-slf4j/pom.xml index 2bf3d27..a5b759b 100644 --- a/jul-to-slf4j/pom.xml +++ b/jul-to-slf4j/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/log4j-over-slf4j/pom.xml b/log4j-over-slf4j/pom.xml index 9cd2586..2f6d2d3 100644 --- a/log4j-over-slf4j/pom.xml +++ b/log4j-over-slf4j/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java index 279111e..0d5d765 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java @@ -45,6 +45,8 @@ public class Category { protected org.slf4j.Logger slf4jLogger; private org.slf4j.spi.LocationAwareLogger locationAwareLogger; + + private static Marker FATAL_MARKER = MarkerFactory.getMarker("FATAL"); Category(String name) { diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/Log4jLoggerFactory.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/Log4jLoggerFactory.java index fb3a70e..d8d0ad7 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/Log4jLoggerFactory.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/Log4jLoggerFactory.java @@ -18,6 +18,8 @@ package org.apache.log4j; import java.util.Hashtable; +import org.slf4j.helpers.Util; + /** * This class is a factory that creates and maintains org.apache.log4j.Loggers * wrapping org.slf4j.Loggers. @@ -32,12 +34,30 @@ class Log4jLoggerFactory { // String, Logger private static Hashtable log4jLoggers = new Hashtable(); + private static final String LOG4J_DELEGATION_LOOP_URL = "http://www.slf4j.org/codes.html#log4jDelegationLoop"; + + // check for delegation loops + static { + try { + Class.forName("org.slf4j.impl.Log4jLoggerFactory"); + String part1 = "Detected both log4j-over-slf4j.jar AND slf4j-log4j12.jar on the class path, preempting StackOverflowError. "; + String part2 = "See also " + LOG4J_DELEGATION_LOOP_URL + + " for more details."; + + Util.reportFailure(part1); + Util.reportFailure(part2); + throw new IllegalStateException(part1 + part2); + } catch (ClassNotFoundException e) { + // this is the good case + } + } + public static synchronized Logger getLogger(String name) { if (log4jLoggers.containsKey(name)) { return (org.apache.log4j.Logger) log4jLoggers.get(name); } else { Logger log4jLogger = new Logger(name); - + log4jLoggers.put(name, log4jLogger); return log4jLogger; } diff --git a/osgi-over-slf4j/pom.xml b/osgi-over-slf4j/pom.xml index ff81748..84197ba 100644 --- a/osgi-over-slf4j/pom.xml +++ b/osgi-over-slf4j/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/pom.xml b/pom.xml index b0514fb..192f5e8 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> <packaging>pom</packaging> <name>SLF4J</name> diff --git a/slf4j-api/pom.xml b/slf4j-api/pom.xml index e93733d..c272650 100644 --- a/slf4j-api/pom.xml +++ b/slf4j-api/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java b/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java index 6dd10e4..068d3df 100644 --- a/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java +++ b/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java @@ -85,7 +85,7 @@ public final class LoggerFactory { * compatibility. Thus, 1.5.7-SNAPSHOT, 1.5.7.RC0 are compatible with 1.5.7. */ static private final String[] API_COMPATIBILITY_LIST = new String[] { - "1.5.5", "1.5.6", "1.5.7", "1.5.8", "1.5.9", "1.5.10" }; + "1.5.5", "1.5.6", "1.5.7", "1.5.8", "1.5.9", "1.5.10", "1.5.11" }; // private constructor prevents instantiation private LoggerFactory() { diff --git a/slf4j-api/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/slf4j-api/src/main/java/org/slf4j/impl/StaticLoggerBinder.java index 89b97da..169b747 100644 --- a/slf4j-api/src/main/java/org/slf4j/impl/StaticLoggerBinder.java +++ b/slf4j-api/src/main/java/org/slf4j/impl/StaticLoggerBinder.java @@ -61,7 +61,7 @@ public class StaticLoggerBinder { * The value of this field is usually modified with each release. */ // to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.10"; // !final + public static String REQUESTED_API_VERSION = "1.5.11"; // !final private StaticLoggerBinder() { throw new UnsupportedOperationException("This code should have never made it into the jar"); diff --git a/slf4j-ext/pom.xml b/slf4j-ext/pom.xml index 636f9b0..8c16a11 100644 --- a/slf4j-ext/pom.xml +++ b/slf4j-ext/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-jcl/pom.xml b/slf4j-jcl/pom.xml index edaaa0a..088560b 100644 --- a/slf4j-jcl/pom.xml +++ b/slf4j-jcl/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-jcl/src/main/java/org/slf4j/impl/JCLLoggerFactory.java b/slf4j-jcl/src/main/java/org/slf4j/impl/JCLLoggerFactory.java index fddaf91..c3ce664 100644 --- a/slf4j-jcl/src/main/java/org/slf4j/impl/JCLLoggerFactory.java +++ b/slf4j-jcl/src/main/java/org/slf4j/impl/JCLLoggerFactory.java @@ -39,6 +39,7 @@ import java.util.Map; import org.apache.commons.logging.LogFactory; import org.slf4j.ILoggerFactory; import org.slf4j.Logger; +import org.slf4j.helpers.Util; /** * JCLLoggerFactory is an implementation of {@link ILoggerFactory} returning the @@ -48,6 +49,24 @@ import org.slf4j.Logger; */ public class JCLLoggerFactory implements ILoggerFactory { + private static final String JCL_DELEGATION_LOOP_URL = "http://www.slf4j.org/codes.html#jclDelegationLoop"; + + // check for delegation loops + static { + try { + Class.forName("org.apache.commons.logging.impl.SLF4JLogFactory"); + String part1 = "Detected both jcl-over-slf4j.jar AND slf4j-jcl.jar on the class path, preempting StackOverflowError. "; + String part2 = "See also " + JCL_DELEGATION_LOOP_URL + + " for more details."; + + Util.reportFailure(part1); + Util.reportFailure(part2); + throw new IllegalStateException(part1 + part2); + } catch (ClassNotFoundException e) { + // this is the good case + } + } + // key: name (String), value: a JCLLoggerAdapter; Map loggerMap; diff --git a/slf4j-jcl/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/slf4j-jcl/src/main/java/org/slf4j/impl/StaticLoggerBinder.java index 2b2514a..9fea2be 100644 --- a/slf4j-jcl/src/main/java/org/slf4j/impl/StaticLoggerBinder.java +++ b/slf4j-jcl/src/main/java/org/slf4j/impl/StaticLoggerBinder.java @@ -65,7 +65,7 @@ public class StaticLoggerBinder implements LoggerFactoryBinder { */ //to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.10"; + public static String REQUESTED_API_VERSION = "1.5.11"; // Binding specific code: private static final String loggerFactoryClassStr = JCLLoggerFactory.class diff --git a/slf4j-jdk14/pom.xml b/slf4j-jdk14/pom.xml index 8ca8ef6..1cc86d1 100644 --- a/slf4j-jdk14/pom.xml +++ b/slf4j-jdk14/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-jdk14/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/slf4j-jdk14/src/main/java/org/slf4j/impl/StaticLoggerBinder.java index c4d2073..92e9db8 100644 --- a/slf4j-jdk14/src/main/java/org/slf4j/impl/StaticLoggerBinder.java +++ b/slf4j-jdk14/src/main/java/org/slf4j/impl/StaticLoggerBinder.java @@ -66,7 +66,7 @@ public class StaticLoggerBinder implements LoggerFactoryBinder { * The value of this field is usually modified with each release. */ // to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.10"; // !final + public static String REQUESTED_API_VERSION = "1.5.11"; // !final private static final String loggerFactoryClassStr = org.slf4j.impl.JDK14LoggerFactory.class.getName(); diff --git a/slf4j-log4j12/pom.xml b/slf4j-log4j12/pom.xml index e8a6548..070e32f 100644 --- a/slf4j-log4j12/pom.xml +++ b/slf4j-log4j12/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-log4j12/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/slf4j-log4j12/src/main/java/org/slf4j/impl/StaticLoggerBinder.java index 6cf6d23..2e86c52 100644 --- a/slf4j-log4j12/src/main/java/org/slf4j/impl/StaticLoggerBinder.java +++ b/slf4j-log4j12/src/main/java/org/slf4j/impl/StaticLoggerBinder.java @@ -66,7 +66,7 @@ public class StaticLoggerBinder implements LoggerFactoryBinder { * against. The value of this field is usually modified with each release. */ // to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.10"; // !final + public static String REQUESTED_API_VERSION = "1.5.11"; // !final private static final String loggerFactoryClassStr = Log4jLoggerFactory.class .getName(); diff --git a/slf4j-migrator/pom.xml b/slf4j-migrator/pom.xml index 69392d0..768a9b0 100644 --- a/slf4j-migrator/pom.xml +++ b/slf4j-migrator/pom.xml @@ -7,7 +7,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-nop/pom.xml b/slf4j-nop/pom.xml index fed1241..01f7781 100644 --- a/slf4j-nop/pom.xml +++ b/slf4j-nop/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-nop/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/slf4j-nop/src/main/java/org/slf4j/impl/StaticLoggerBinder.java index 109e415..4c14792 100644 --- a/slf4j-nop/src/main/java/org/slf4j/impl/StaticLoggerBinder.java +++ b/slf4j-nop/src/main/java/org/slf4j/impl/StaticLoggerBinder.java @@ -66,7 +66,7 @@ public class StaticLoggerBinder implements LoggerFactoryBinder { * The value of this field is usually modified with each release. */ // to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.10"; // !final + public static String REQUESTED_API_VERSION = "1.5.11"; // !final private static final String loggerFactoryClassStr = NOPLoggerFactory.class.getName(); diff --git a/slf4j-osgi-integration-test/pom.xml b/slf4j-osgi-integration-test/pom.xml index 8ea99dc..8951a13 100644 --- a/slf4j-osgi-integration-test/pom.xml +++ b/slf4j-osgi-integration-test/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-osgi-test-bundle/pom.xml b/slf4j-osgi-test-bundle/pom.xml index 723382e..97c09a2 100644 --- a/slf4j-osgi-test-bundle/pom.xml +++ b/slf4j-osgi-test-bundle/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-simple/pom.xml b/slf4j-simple/pom.xml index cb5c89c..f582310 100644 --- a/slf4j-simple/pom.xml +++ b/slf4j-simple/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-simple/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/slf4j-simple/src/main/java/org/slf4j/impl/StaticLoggerBinder.java index 5bc87a4..064cb9e 100644 --- a/slf4j-simple/src/main/java/org/slf4j/impl/StaticLoggerBinder.java +++ b/slf4j-simple/src/main/java/org/slf4j/impl/StaticLoggerBinder.java @@ -58,7 +58,7 @@ public class StaticLoggerBinder implements LoggerFactoryBinder { * against. The value of this field is usually modified with each release. */ // to avoid constant folding by the compiler, this field must *not* be final - public static String REQUESTED_API_VERSION = "1.5.10"; // !final + public static String REQUESTED_API_VERSION = "1.5.11"; // !final private static final String loggerFactoryClassStr = SimpleLoggerFactory.class.getName(); diff --git a/slf4j-site/pom.xml b/slf4j-site/pom.xml index c17dacd..68116ff 100644 --- a/slf4j-site/pom.xml +++ b/slf4j-site/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.5.10</version> + <version>1.5.11</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-site/src/site/pages/codes.html b/slf4j-site/src/site/pages/codes.html index 2c72e02..f5d7ed2 100644 --- a/slf4j-site/src/site/pages/codes.html +++ b/slf4j-site/src/site/pages/codes.html @@ -1,11 +1,13 @@ <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/2000/REC-xhtml1-20000126/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> -<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" /> -<title>SLF4J Error Codes</title> -<link rel="stylesheet" type="text/css" media="screen" href="css/site.css" /> + <meta http-equiv="content-type" content="text/html; charset=iso-8859-1" /> + <title>SLF4J Error Codes</title> + <link rel="stylesheet" type="text/css" media="screen" href="css/site.css" /> + <link rel="stylesheet" type="text/css" href="css/prettify.css" /> </head> -<body> +<body onload="prettyPrint()"> + <script type="text/javascript" src="js/prettify.js"></script> <script type="text/javascript">prefix='';</script> <script src="templates/header.js" type="text/javascript"></script> @@ -13,6 +15,7 @@ <script src="templates/left.js" type="text/javascript"></script> </div> + <div id="content"> <center> @@ -151,7 +154,7 @@ <em>slf4j-simple-${version}.jar</em> and <em>slf4j-nop-${version}.jar</em> on the class path and you wish to use the nop (no-operation) binding, then remove - <em>slf4j-simple-${version}.jar</em> from the class parh.</p> + <em>slf4j-simple-${version}.jar</em> from the class path.</p>  @@ -168,7 +171,102 @@ an effective remedy. </p> - +  + + <h3> + <a name="log4jDelegationLoop" + href="#log4jDelegationLoop">Detected both log4j-over-slf4j.jar + AND slf4j-log4j12.jar on the class path, preempting + <code>StackOverflowError</code>.</a> + </h3> + + <p>The purpose of slf4j-log4j12 module is to delegate or redirect + calls made to an SLF4J logger to log4j. The purpose of the + log4j-over-slf4j module is to redirect calls made to a log4j + logger to SLF4J. If both <em>slf4j-log4j12.jar</em> and + <em>log4j-over-slf4j.jar</em> are present on the class path, a + <code>StackOverflowError</code> will inevitably occur immediately + after the first invocation of an SLF4J or a log4j logger. + </p> + + <p>Here is how the exception might look like:</p> + + <pre class="prettyprint source">Exception in thread "main" java.lang.StackOverflowError + at java.util.Hashtable.containsKey(Hashtable.java:306) + at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:36) + at org.apache.log4j.LogManager.getLogger(LogManager.java:39) + at org.slf4j.impl.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:73) + at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:249) + at org.apache.log4j.Category.<init>(Category.java:53) + at org.apache.log4j.Logger..<init>(Logger.java:35) + at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:39) + at org.apache.log4j.LogManager.getLogger(LogManager.java:39) + at org.slf4j.impl.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:73) + at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:249) + at org.apache.log4j.Category..<init>(Category.java:53) + at org.apache.log4j.Logger..<init>(Logger.java:35) + at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:39) + at org.apache.log4j.LogManager.getLogger(LogManager.java:39) + subsequent lines omitted...</pre> + + <p>As of SLF4J version 1.5.11, the code preempts the inevitable + stack overflow error by throwing an exception with details about + the actual cause of the problem. This is deemed to be better than + leaving the user wondering about the reasons of the + <code>StackOverflowError</code>. + </p> + + <p>For more background on this topic see <a + href="legacy.html">Bridging legacy APIs</a>. + </p> + +  + + + <h3> + <a name="jclDelegationLoop" href="#jclDelegationLoop">Detected + both jcl-over-slf4j.jar AND slf4j-jcl.jar on the class path, + preempting <code>StackOverflowError</code>.</a> + </h3> + + <p>The purpose of slf4j-jcl module is to delegate or redirect + calls made to an SLF4J logger to jakarta commons logging + (JCL). The purpose of the jcl-over-slf4j module is to redirect + calls made to a JCL logger to SLF4J. If both + <em>slf4j-jcl.jar</em> and <em>jcl-over-slf4j.jar</em> are present + on the class path, then a <code>StackOverflowError</code> will + inevitably occur immediately after the first invocation of an + SLF4J or a JCL logger. + </p> + + <p>Here is how the exception might look like:</p> + + <pre class="prettyprint source">Exception in thread "main" java.lang.StackOverflowError + at java.lang.String.hashCode(String.java:1482) + at java.util.HashMap.get(HashMap.java:300) + at org.slf4j.impl.JCLLoggerFactory.getLogger(JCLLoggerFactory.java:67) + at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:249) + at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:155) + at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:289) + at org.slf4j.impl.JCLLoggerFactory.getLogger(JCLLoggerFactory.java:69) + at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:249) + at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:155) + subsequent lines omitted...</pre> + + + <p>As of SLF4J version 1.5.11, the code preempts the inevitable + stack overflow error by throwing an exception with details about + the actual cause of the problem. This is deemed to be better than + leaving the user wondering about the reasons of the + <code>StackOverflowError</code>. + </p> + + <p>For more background on this topic see <a + href="legacy.html">Bridging legacy APIs</a>. + </p> + +  + <h3> <a name="no_static_mdc_binder" href="#no_static_mdc_binder">Failed to load class diff --git a/slf4j-site/src/site/pages/legacy.html b/slf4j-site/src/site/pages/legacy.html index a5ba376..fa8d54d 100644 --- a/slf4j-site/src/site/pages/legacy.html +++ b/slf4j-site/src/site/pages/legacy.html @@ -101,10 +101,10 @@ <p>Please note that <em>jcl-over-slf4j.jar</em> and <em>slf4j-jcl.jar</em> cannot be deployed at the same time. The - former jar file will cause JCL to delegate the choice of the logging - system to SLF4J and the latter jar file will cause SLF4J to delegate - the choice of the logging system to JCL, resulting in an infinite - loop. + former jar file will cause JCL to delegate the choice of the + logging system to SLF4J and the latter jar file will cause SLF4J + to delegate the choice of the logging system to JCL, resulting in + an <a href="codes.html#jclDelegationLoop">infinite loop</a>. </p> @@ -184,9 +184,10 @@ <p>The presence of <em>slf4j-logj12.jar</em>, that is the log4j binding for SLF4J, will force all SLF4J calls to be delegated to log4j. The presence of <em>log4j-over-slf4j.jar</em> will in turn - delegate all log4j API calls to their SLF4J equivalents. If both are - present simultaneously, slf4j calls will be delegated to log4j, and - log4j calls redirected to SLF4j, resulting in an endless loop. + delegate all log4j API calls to their SLF4J equivalents. If both + are present simultaneously, slf4j calls will be delegated to + log4j, and log4j calls redirected to SLF4j, resulting in an <a + href="codes.html#log4jDelegationLoop">endless loop</a>. </p> <h3><a name="jul-to-slf4j" href="jul-to-slf4j">JUL to SLF4J</a></h3> diff --git a/slf4j-site/src/site/pages/news.html b/slf4j-site/src/site/pages/news.html index 8b04327..b5a8c71 100644 --- a/slf4j-site/src/site/pages/news.html +++ b/slf4j-site/src/site/pages/news.html @@ -27,7 +27,20 @@ <hr noshade="noshade" size="1"/> - <h3>March xx, 2010 - Release of SLF4J 1.5.11</h3> + <h3>February 25th, 2010 - Release of SLF4J 1.5.11</h3> + + + <p>Users yet unfamiliar with SLF4J sometimes unknowingly place both + <em>log4j-over-slf4j.jar</em> and <em>slf4j-log4j12.jar</em> + simultanously on the class path causing stack overflow + errors. Simultaneously placing both <em>jcl-over-slf4j.jar</em> and + <em>slf4j-jcl.jar</em> on the class path, is another occurrence of + the same general problem. As of this version, SLF4J preempts the + inevitable stack overflow error by throwing an exception with + details about the actual cause of the problem. This is deemed to be + better than leaving the user wondering about the reasons of the + <code>StackOverflowError</code>. + </p> <p>Fixed <a href="http://bugzilla.slf4j.org/show_bug.cgi?id=168">bug 168</a>. In case log4j-over-slf4j is used and a logback appender ----------------------------------------------------------------------- Summary of changes: integration/pom.xml | 2 +- jcl-over-slf4j/pom.xml | 2 +- jcl104-over-slf4j/pom.xml | 2 +- jul-to-slf4j/pom.xml | 2 +- log4j-over-slf4j/pom.xml | 2 +- .../src/main/java/org/apache/log4j/Category.java | 2 + .../java/org/apache/log4j/Log4jLoggerFactory.java | 22 ++++- osgi-over-slf4j/pom.xml | 2 +- pom.xml | 2 +- slf4j-api/pom.xml | 2 +- .../src/main/java/org/slf4j/LoggerFactory.java | 2 +- .../java/org/slf4j/impl/StaticLoggerBinder.java | 2 +- slf4j-ext/pom.xml | 2 +- slf4j-jcl/pom.xml | 2 +- .../main/java/org/slf4j/impl/JCLLoggerFactory.java | 19 ++++ .../java/org/slf4j/impl/StaticLoggerBinder.java | 2 +- slf4j-jdk14/pom.xml | 2 +- .../java/org/slf4j/impl/StaticLoggerBinder.java | 2 +- slf4j-log4j12/pom.xml | 2 +- .../java/org/slf4j/impl/StaticLoggerBinder.java | 2 +- slf4j-migrator/pom.xml | 2 +- slf4j-nop/pom.xml | 2 +- .../java/org/slf4j/impl/StaticLoggerBinder.java | 2 +- slf4j-osgi-integration-test/pom.xml | 2 +- slf4j-osgi-test-bundle/pom.xml | 2 +- slf4j-simple/pom.xml | 2 +- .../java/org/slf4j/impl/StaticLoggerBinder.java | 2 +- slf4j-site/pom.xml | 2 +- slf4j-site/src/site/pages/codes.html | 110 ++++++++++++++++++- slf4j-site/src/site/pages/legacy.html | 15 ++-- slf4j-site/src/site/pages/news.html | 15 +++- 31 files changed, 193 insertions(+), 40 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch, master, updated. v1.5.9.RC1-22-g99c9eb8
by git-noreply＠pixie.qos.ch 25 Feb '10

25 Feb '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 99c9eb8a756df79e94234f00a348b0ee6222098e (commit) from 25120e32fd761df284df417b7ebfa1cb8560fba7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=99c9eb8a756df79e94234f00a3… http://github.com/ceki/slf4j/commit/99c9eb8a756df79e94234f00a348b0ee6222098e commit 99c9eb8a756df79e94234f00a348b0ee6222098e Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Feb 25 09:24:33 2010 +0100 - addded links to projects using slf4j in index.html - fixed http://bugzilla.slf4j.org/show_bug.cgi?id=168 diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java index c85e7b2..279111e 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/Category.java @@ -31,8 +31,7 @@ import org.slf4j.spi.LocationAwareLogger; * Log4j's <code>trace</code>, <code>debug()</code>, <code>info()</code>, * <code>warn()</code>, <code>error()</code> printing methods are directly * mapped to their SLF4J equivalents. Log4j's <code>fatal()</code> printing - * method is mapped to SLF4J's <code>error()</code> method with a FATAL - * marker. + * method is mapped to SLF4J's <code>error()</code> method with a FATAL marker. * * @author Sébastien Pennec * @author Ceki Gülcü @@ -148,7 +147,7 @@ public class Category { * SLF4J equivalent, except for FATAL which is mapped as ERROR. * * @param p - * the priority to check against + * the priority to check against * @return true if this logger is enabled for the given level, false * otherwise. */ @@ -281,30 +280,22 @@ public class Category { LocationAwareLogger.ERROR_INT, message, t); } - + // See also http://bugzilla.slf4j.org/show_bug.cgi?id=168 public void log(String FQCN, Priority p, Object msg, Throwable t) { int levelInt = priorityToLevelInt(p); - if (locationAwareLogger != null) { - locationAwareLogger.log(null, FQCN, levelInt, convertToString(msg), t); - } else { - throw new UnsupportedOperationException("The logger [" + slf4jLogger - + "] does not seem to be location aware."); - } + differentiatedLog(null, FQCN, levelInt, msg, t); } public void log(Priority p, Object message, Throwable t) { int levelInt = priorityToLevelInt(p); - differentiatedLog(null, CATEGORY_FQCN, levelInt, - message, t); + differentiatedLog(null, CATEGORY_FQCN, levelInt, message, t); } public void log(Priority p, Object message) { int levelInt = priorityToLevelInt(p); - differentiatedLog(null, CATEGORY_FQCN, levelInt, - message, null); + differentiatedLog(null, CATEGORY_FQCN, levelInt, message, null); } - private int priorityToLevelInt(Priority p) { switch (p.level) { case Level.TRACE_INT: diff --git a/slf4j-site/src/site/pages/index.html b/slf4j-site/src/site/pages/index.html index 2805885..0aea6bb 100644 --- a/slf4j-site/src/site/pages/index.html +++ b/slf4j-site/src/site/pages/index.html @@ -46,6 +46,110 @@ href="legacy.html">legacy APIs</a>. </p> + <h3>Projects depending on SLF4J</h3> + + <p>Here is a non-exhaustive list of projects known to depend on + SLF4J, in alphabetical order: + </p> + + <table border="0"> + <tr> + <td valign="top"> + <ul> + <li><a href="http://arhiva.apache.org/">Apache Archiva</a></li> + <li><a href="http://directory.apache.org/">Apache Directory</a></li> + <li><a href="http://mina.apache.org/ftpserver/">Apache FTPServer</a></li> + <li><a href="http://geronimo.apache.org/">Apache Geronimo</a></li> + <li><a href="http://incubator.apache.org/graffito/">Apache Graffito</a></li> + <li><a href="http://jackrabbit.apache.org/">Apache Jackrabbit</a></li> + <li><a href="http://mina.apache.org/">Apache Mina</a></li> + <li><a href="http://cwiki.apache.org/qpid/">Apache Qpid</a></li> + <li><a href="http://incubator.apache.org/sling/site/index.html">Apache Sling</a></li> + <li><a href="http://lucene.apache.org/solr/">Apache Solr</a></li> + </ul> + </td> + + <td valign="top"> + <ul> + <li><a href="http://tapestry.apache.org/">Apache Tapestry</a></li> + <li><a href="http://incubator.apache.org/wicket/">Apache Wicket</a></li> + <li><a href="http://aperture.sourceforge.net/">Aperture</a></li> + <li><a href="http://apogee.nuxeo.org/">Apogee</a></li> + <li><a href="http://www.jfrog.org/sites/artifactory/latest/">Artifactory</a></li> + <li><a href="http://docs.safehaus.org/display/ASYNCWEB/Home">AsyncWeb</a></li> + <li><a href="http://www.bitronix.be/">Bitronix</a></li> + <li><a href="http://www.dbunit.org/">DbUnit</a></li> + <li><a href="http://displaytag.sourceforge.net/11/">Display tag</a></li> + <li><a href="http://groovy.codehaus.org/GMaven">GMaven</a></li> + </ul> + + </td> + + <td valign="top"> + <ul> + <li><a href="http://www.gradle.org/">Gradle</a></li> + <li><a href="http://www.icegreen.com/greenmail/">GreenMail</a></li> + <li><a href="http://gumtree.codehaus.org/">GumTree</a></li> + <li><a href="http://www.h2database.com/">H2 Database</a></li> + <li><a href="http://ha-jdbc.sourceforge.net/">HA-JDBC</a></li> + <li><a href="http://www.hibernate.org/">Hibernate</a></li> + <li><a href="http://code.google.com/p/igenko/">Igenko</a></li> + <li><a href="http://jabsorb.org/">Jabsorb</a></li> + <li><a href="http://jetty.mortbay.org/">Jetty v6</a></li> + <li><a href="http://www.topmind.biz/html/index.php">jLynx</a></li> + </ul> + </td> + </tr> + + <tr> + + <td valign="top"> + <ul> + <li><a href="http://code.google.com/p/jmesa/">JMesa</a></li> + <li><a href="http://www.artofsolving.com/opensource/jodconverter">JODConverter</a></li> + <li><a href="http://jtrac.info/dependencies.html">JTrac</a></li> + <li><a href="http://jwebunit.sourceforge.net/2.x/">JWebUnit 2.x</a></li> + <li><a href="http://www.jquantlib.org/index.php/Main_Page">JQuantLib</a></li> + <li><a href="http://www.liferay.com/web/guest/home">LIFERAY</a></li> + <li><a href="http://liftweb.net/">Lift</a></li> + <li><a href="http://log4jdbc.sourceforge.net">log4jdbc</a></li> + <li><a href="http://www.magnolia.info/en/magnolia.html">Magnolia</a></li> + <li><a href="http://mrcp4j.sourceforge.net/">MRCP4J</a></li> + </ul> + </td> + + + <td valign="top"> + <ul> + <li><a href="http://www.mindquarry.com/">Mindquarry</a></li> + <li><a href="http://mugshot.org/">Mugshot</a></li> + <li><a href="http://mule.codehaus.org/display/MULE/Home">Mule</a></li> + <li><a href="http://nexus.sonatype.org/repository.html">Nexus</a></li> + <li><a href="http://www.novocode.com/naf/">Novocode</a></li> + <li><a href="http://www.unidata.ucar.edu/software/netcdf-java/">NetCDF</a></li> + <li><a href="http://code.google.com/p/openmeetings/">OpenMeetings</a></li> + <li><a href="http://www.openrdf.org/">OpenRDF</a></li> + <li><a href="http://docs.safehaus.org/display/PENROSE/Home">Penrose</a></li> + <li><a href="http://sonar.codehaus.org/">Sonar</a></li> + </ul> + </td> + + <td valign="top"> + <ul> + <li><a href="http://pzfilereader.sourceforge.net/">PZFileReader</a></li> + <li><a href="http://www.quickfixj.org/">QuickFIX/J</a></li> + <li><a href="http://smsj.sourceforge.net/dependencies.html">SMSJ</a></li> + <li><a href="http://www.springframework.org/osgi">Spring-OSGi</a></li> + <li><a href="http://static.springsource.org/s2-dmserver/2.0.x/user-guide/htmlsingle/user…">SpringSource dm Server™</a></li> + <li><a href="http://streambase.com/">StreamBase</a></li> + <li><a href="http://www.timefinder.de/">TimeFinder</a></li> + <li><a href="http://www.wtfigo.org/index.html">WTFIGO</a></li> + <li><a href="http://yaslibrary.sourceforge.net/index.shtml">YASL</a></li> + <li><a href="http://xooctory.xoocode.org/">Xooctory</a></li> + </ul> + </td> + </tr> + </table> <script src="templates/footer.js" type="text/javascript"></script> </div> diff --git a/slf4j-site/src/site/pages/news.html b/slf4j-site/src/site/pages/news.html index 924b058..8b04327 100644 --- a/slf4j-site/src/site/pages/news.html +++ b/slf4j-site/src/site/pages/news.html @@ -25,6 +25,19 @@ announce</a> mailing list. </p> + <hr noshade="noshade" size="1"/> + + <h3>March xx, 2010 - Release of SLF4J 1.5.11</h3> + + <p>Fixed <a href="http://bugzilla.slf4j.org/show_bug.cgi?id=168">bug + 168</a>. In case log4j-over-slf4j is used and a logback appender + requires a third party library which depends on log4j, the + <code>log(String FQCN, Priority p, Object msg, Throwable t)</code> + method in log4j-over-slf4j's Categotry class would throw an + <code>UnsupportedOperationException</code>. Problem reported by Seth + Call.</p> + + <hr noshade="noshade" size="1"/> <h3>December 3rd, 2009 - Release of SLF4J 1.5.10</h3> ----------------------------------------------------------------------- Summary of changes: .../src/main/java/org/apache/log4j/Category.java | 21 +--- slf4j-site/src/site/pages/index.html | 104 ++++++++++++++++++++ slf4j-site/src/site/pages/news.html | 13 +++ 3 files changed, 123 insertions(+), 15 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[Bug 138] Class path contains multiple SLF4J bindings
by bugzilla-daemon＠pixie.qos.ch 23 Feb '10

23 Feb '10

http://bugzilla.slf4j.org/show_bug.cgi?id=138 Dimo Velev <dimo.velev(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dimo.velev(a)gmail.com --- Comment #13 from Dimo Velev <dimo.velev(a)gmail.com> 2010-02-23 16:26:49 --- Hi, I also find it better to use a Set in this case instead of a List. The reason for this is that a Set better communicates the actual usage of the implementations-collection in this piece of code (LoggerFactory). When you see a List you automatically think of a collection which allows duplicates. Well, in this case I think that the implementation actually means that this is a collection which does not care for duplicates and this is expressed by a Set. Just my own opinion as someone reading the source code. Best regards, Dimo -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch, master, updated. v1.5.9.RC1-21-g25120e3
by git-noreply＠pixie.qos.ch 16 Feb '10

16 Feb '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 25120e32fd761df284df417b7ebfa1cb8560fba7 (commit) from 062725906b4c172542ff906ae84fdc031142ee47 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=25120e32fd761df284df417b7e… http://github.com/ceki/slf4j/commit/25120e32fd761df284df417b7ebfa1cb8560fba7 commit 25120e32fd761df284df417b7ebfa1cb8560fba7 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Feb 16 19:22:10 2010 +0100 Added a link to Thorbjørn's article on SLF4J. This should have been done long ago but somehow fell through the cracks. diff --git a/slf4j-site/src/site/pages/docs.html b/slf4j-site/src/site/pages/docs.html index 67154de..5d5dc62 100644 --- a/slf4j-site/src/site/pages/docs.html +++ b/slf4j-site/src/site/pages/docs.html @@ -46,6 +46,11 @@ <ul> <li> + <a + href="http://runjva.appspot.com/logging101/index.html">Logging + in Java with slf4j</a>, by Thorbjørn Ravn Andersen + </li> + <li> <a href="http://eclipsezone.com/articles/franey-logging/?source=archives">Universal Logger Plug-ins for RCP Applications</a>, by John J. Franey </li> ----------------------------------------------------------------------- Summary of changes: slf4j-site/src/site/pages/docs.html | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[Bug 31] Varargs for Logger methods
by bugzilla-daemon＠pixie.qos.ch 14 Feb '10

14 Feb '10

http://bugzilla.slf4j.org/show_bug.cgi?id=31 --- Comment #78 from Joern Huxhorn <joern(a)huxhorn.de> 2010-02-14 12:38:55 --- (In reply to comment #77) > I think that your approach with having the varargs logger in a completely > separate package is the right solution. Thanks. > I also think that the methods in the interface should be as simple as possible > while still conveying meaning. In other words the mandatory formating string > must be explicitly defined, but the exception cannot as it breaks the varargs > convention (to my understanding). > > I'd vote for a new Logger interface in a separate package (shipped separately > from slf4j-api too) providing only > > log.error(String, Object...) > log.warn(String, Object...) > log.info(String, Object...) > log.debug(String, Object...) My proposal defines some more methods. logger.log(Level, String, Object...) logger.log(Level, Marker, String, Object...) logger.log(Level, Message) logger.log(Level, Marker, Message) logger.log(Level, Message, Throwable) logger.log(Level, Marker, Message, Throwable) The same explicitly for each level, with the Level argument omitted, obviously. That way it's possible to create and use arbitrary other Message implementations, beside the default implementation that is used when (String, Object...) is called. The default formats exactly like the current SLF4J message format. > which then invokes the appropriate methods in the current slf4j API (unless > Logback implements these too natively). Simply looking at the last element to > see if it is a Throwable or not, should be enough? I think so, yes. It adheres to the POLA ( http://en.wikipedia.org/wiki/Principle_of_least_astonishment ) > My only concern is that it breaks the "log-where-I-came-from" mechanisms. This > is less important to me. > This shouldn't be a problem due to the LocationAwareLogger. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 31] Varargs for Logger methods
by bugzilla-daemon＠pixie.qos.ch 12 Feb '10

12 Feb '10

http://bugzilla.slf4j.org/show_bug.cgi?id=31 --- Comment #77 from Thorbjørn Ravn Andersen <thorbjoern(a)gmail.com> 2010-02-12 21:55:08 --- (In reply to comment #53) > I think that the following is counter-intuitive: > ("Pattern {} {}", new Throwable(), "Param1", "Param2") > This would be less counter-intuitive but not "compatible" to the current > ("message", new Throwable()) idiom: > (new Throwable(), "Pattern {} {}", "Param1", "Param2") > > Additionally, having less methods is indeed a plus in my books. > Adding an explicit Throwable would multiply the 2 log methods per level to 4 > methods. > Instead, I'd suggest to properly document the "last unused parameter is used as > Throwable" behavior properly. I think that your approach with having the varargs logger in a completely separate package is the right solution. I also think that the methods in the interface should be as simple as possible while still conveying meaning. In other words the mandatory formating string must be explicitly defined, but the exception cannot as it breaks the varargs convention (to my understanding). I'd vote for a new Logger interface in a separate package (shipped separately from slf4j-api too) providing only log.error(String, Object...) log.warn(String, Object...) log.info(String, Object...) log.debug(String, Object...) which then invokes the appropriate methods in the current slf4j API (unless Logback implements these too natively). Simply looking at the last element to see if it is a Throwable or not, should be enough? (This will also catch the oops-I-invoked-the-wrong-method). Otherwise log.error and log.errorException(String, Exception Object...) might be a good long term solution. My only concern is that it breaks the "log-where-I-came-from" mechanisms. This is less important to me. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch, master, updated. v1.5.9.RC1-20-g0627259
by git-noreply＠pixie.qos.ch 10 Feb '10

10 Feb '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 062725906b4c172542ff906ae84fdc031142ee47 (commit) from 65763d63df4bd33de35402f1f32c93a7b091b451 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=062725906b4c172542ff906ae8… http://github.com/ceki/slf4j/commit/062725906b4c172542ff906ae84fdc031142ee47 commit 062725906b4c172542ff906ae84fdc031142ee47 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Wed Feb 10 22:22:07 2010 +0100 - added a link to an SLF4J article by Baptiste Wicht in English diff --git a/slf4j-site/src/site/pages/docs.html b/slf4j-site/src/site/pages/docs.html index 10bfbab..67154de 100644 --- a/slf4j-site/src/site/pages/docs.html +++ b/slf4j-site/src/site/pages/docs.html @@ -44,6 +44,7 @@ <ul> + <li> <a href="http://eclipsezone.com/articles/franey-logging/?source=archives">Universal Logger Plug-ins for RCP Applications</a>, by John J. Franey @@ -62,18 +63,20 @@ <a href="slf4j-in-10-slides.ppt">SLF4J in 10 slides</a>, by Ceki Gülcü </li> - <li><a - href="http://www.devoxx.com:5080/player/main.html#state=state_player&id=357&slide…">SLF4J - and Logback projects</a>, by C. Gülcü and S. Pennec - (Jazoon presentation with audio). If the previous link does not - work, please try the <a - href="http://beta.parleys.com/share/parleysshare2.swf?pageId=357">back - up</a>. - </li> + <li> + <a + href="http://www.devoxx.com:5080/player/main.html#state=state_player&id=357&slide…">SLF4J + and Logback projects</a>, by C. Gülcü and S. Pennec + (Jazoon presentation with audio). If the previous link does not + work, please try the <a + href="http://beta.parleys.com/share/parleysshare2.swf?pageId=357">back + up</a>. + </li> - <li><a - href="http://day-to-day-stuff.blogspot.com/2007/10/announcement-version-99-does-n…"> - Version 99 Does Not Exist</a>, by Erik van Oosten + <li> + <a + href="http://day-to-day-stuff.blogspot.com/2007/10/announcement-version-99-does-n…"> + Version 99 Does Not Exist</a>, by Erik van Oosten </li> @@ -95,9 +98,15 @@ Dependencies in Spring </a> by Dave Syer </li> - <li><a - href="http://sharein.com/shares/111630-a-java-geek-thoughts-on-java-logging-and-s…">Logging: - should I wrap?</a> by Chris Wong + <li> + <a href="http://baptiste-wicht.developpez.com/tutorials/java/slf4j/">Logging with SLF4J</a> + by Baptiste Wicht + </li> + + <li> + <a + href="http://sharein.com/shares/111630-a-java-geek-thoughts-on-java-logging-and-s…">Logging: + should I wrap?</a> by Chris Wong </li> </ul> @@ -108,8 +117,12 @@ href="http://www.insideit.fr/post/2009/11/23/SLF4J-LOGBack">SLF4J & Logback : simplifiez-vous les logs</a> by Ludovic Meurillon </li> - <li><a - href="http://baptiste-wicht.developpez.com/tutoriels/java/slf4j/">Journalisation avec SLF4J</a> by Baptiste Wicht</li> + + <li> + <a + href="http://baptiste-wicht.developpez.com/tutoriels/java/slf4j/">Journalisation avec SLF4J + </a> by Baptiste Wicht + </li> </ul> ----------------------------------------------------------------------- Summary of changes: slf4j-site/src/site/pages/docs.html | 45 ++++++++++++++++++++++------------ 1 files changed, 29 insertions(+), 16 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch, master, updated. v1.5.9.RC1-19-g65763d6
by git-noreply＠pixie.qos.ch 09 Feb '10

09 Feb '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 65763d63df4bd33de35402f1f32c93a7b091b451 (commit) from 94da9e9b2c3a5df7438e00b40b25bf07d37c86f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=65763d63df4bd33de35402f1f3… http://github.com/ceki/slf4j/commit/65763d63df4bd33de35402f1f32c93a7b091b451 commit 65763d63df4bd33de35402f1f32c93a7b091b451 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Feb 9 10:27:34 2010 +0100 - added link to Baptiste Wicht's article on SLF4J diff --git a/slf4j-site/src/site/pages/docs.html b/slf4j-site/src/site/pages/docs.html index 83edf49..10bfbab 100644 --- a/slf4j-site/src/site/pages/docs.html +++ b/slf4j-site/src/site/pages/docs.html @@ -39,7 +39,7 @@ </li> </ul> - <h2>Articles</h2> + <h2>Articles, blogs & presentations</h2> @@ -101,13 +101,16 @@ </li> </ul> - <h4>In french</h4> + <h4>In French</h4> <ul> <li><a href="http://www.insideit.fr/post/2009/11/23/SLF4J-LOGBack">SLF4J - & LOGBack : simplifiez-vous les logs</a> by Ludovic Meurillon + & Logback : simplifiez-vous les logs</a> by Ludovic Meurillon </li> + <li><a + href="http://baptiste-wicht.developpez.com/tutoriels/java/slf4j/">Journalisation avec SLF4J</a> by Baptiste Wicht</li> + </ul> <h2>Conferences</h2> ----------------------------------------------------------------------- Summary of changes: slf4j-site/src/site/pages/docs.html | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0