February 2020 - slf4j-dev - mailman3.qos.ch

[qos-ch/slf4j] e2c29c: minor edit
by Ceki Gulcu 24 Feb '20

24 Feb '20

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: e2c29c81df6fb405a3c5a6dfd1cf28ba26a7c1d6 https://github.com/qos-ch/slf4j/commit/e2c29c81df6fb405a3c5a6dfd1cf28ba26a7… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2020-02-24 (Mon, 24 Feb 2020) Changed paths: M slf4j-site/src/site/pages/migrator.html Log Message: ----------- minor edit

1 0

SLF4J-421
by Jonathan Essex 20 Feb '20

20 Feb '20

https://jira.qos.ch/browse/SLF4J-421?page=com.atlassian.jira.plugin.system.… Does anyone have time to review/discuss my PR for SLF4J-421? It’s really a horrible bug as if you are outputting any JSON it tends to produce realistic-looking log messages which also happen to be utterly misleading. I went down a 2-day rabbit hole looking in totally the wrong place to resolve a problem because my log data was telling me that the application was doing something which was both wrong and plausible. In my view, XLogger is not fit for purpose at all and should be removed or marked deprecated until this issue is resolved. I couldn’t believe my eyes when I found this case has been open for over two years. Unfortunately now XLogger is thoroughly embedded in 8 of my components and the effort to replace it would be considerable. I have submitted a PR with a unit test, but the solution does require discussion, as to avoid making potentially breaking changes it seems necessary to add to the API of MessageFormatter. I have: 1) Added public methods to MessageFormatter which will ‘escape’ any formatting delimiters in the output message 2) Modified XLogger and LoggerWrapper to use the escaping versions of the MessageFormatter methods log.error("{},{}", foo, "[{}]") will now produce: foo,[\{}] instead of foo,[foo] I note that I don’t think it’s possible to create the exact desired behavior (output foo,[{}]) without changing the behavior of the standard message formatter methods to remove escape characters (so log.error(“\{}”,”a”) would produce {} instead of \{} ). This latter change is defensible but since it might alter existing behavior I thought it best left for now. Regards Jon. Thanks Jon

2 3

[JIRA] (SLF4J-413) Documentation - Link broken on MDC Page
by QOS.CH (JIRA) 17 Feb '20

17 Feb '20

[ https://jira.qos.ch/browse/SLF4J-413?page=com.atlassian.jira.plugin.system.… ] Mary Hayes commented on SLF4J-413: ---------------------------------- The file is present at [https://github.com/qos-ch/logback/blob/master/logback-examples/src/main/res…] Cloning repo and testing. > Documentation - Link broken on MDC Page > --------------------------------------- > > Key: SLF4J-413 > URL: https://jira.qos.ch/browse/SLF4J-413 > Project: SLF4J > Issue Type: Bug > Components: Unspecified > Reporter: Joerg Junge > Assignee: SLF4J developers list > Priority: Trivial > Labels: documentation > > On the Documentation Page: `Chapter 8: Mapped Diagnostic Context` > [https://logback.qos.ch/manual/mdc.html] > the Link to simpleMDC.xml is broken. > [http://github.com/qos-ch/logback/blob/master/logback-examples/src/main/java…] > Please reupload the file. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-435) Minor typo in FAQ
by QOS.CH (JIRA) 17 Feb '20

17 Feb '20

[ https://jira.qos.ch/browse/SLF4J-435?page=com.atlassian.jira.plugin.system.… ] Mary Hayes commented on SLF4J-435: ---------------------------------- File is here: [slf4j|https://github.com/qos-ch/slf4j]/[slf4j-site|https://github.com/qos-c… *Pull request: [https://github.com/qos-ch/slf4j/pull/204] is open since April, not merged yet.* > Minor typo in FAQ > ----------------- > > Key: SLF4J-435 > URL: https://jira.qos.ch/browse/SLF4J-435 > Project: SLF4J > Issue Type: Bug > Components: Unspecified > Environment: https://www.slf4j.org/faq.html > Reporter: Sam Mefford > Assignee: SLF4J developers list > Priority: Trivial > Fix For: 2.0.0-alpha2 > > > The last character in this paragraph appears to be incorrect: > {quote}SLF4J only cares about the _formatting anchor_, that is the '\{' character immediately followed by '}'. Thus, in case your message contains the '\{' or the '}' character, you do not have to do anything special unless the '}' character immediately follows '}'. > {quote} > Shouldn't it end with "immediately follows '\{'."? -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-435) Minor typo in FAQ
by QOS.CH (JIRA) 17 Feb '20

17 Feb '20

[ https://jira.qos.ch/browse/SLF4J-435?page=com.atlassian.jira.plugin.system.… ] Mary Hayes commented on SLF4J-435: ---------------------------------- Yes - Updated text before the example should read (without bold or colour): {quote}*Escaping the "\{}" pair* The "\{}" pair is called the _formatting anchor_. It serves to designate the location where arguments need to be substituted within the message pattern. SLF4J only cares about the _formatting anchor_, that is the '\{' character immediately followed by '}'. Thus, in case your message contains the '\{' or the '}' character, you do not have to do anything special unless the '}' character immediately follows '*{color:#d04437}\{{color}*'. For example, {quote} > Minor typo in FAQ > ----------------- > > Key: SLF4J-435 > URL: https://jira.qos.ch/browse/SLF4J-435 > Project: SLF4J > Issue Type: Bug > Components: Unspecified > Environment: https://www.slf4j.org/faq.html > Reporter: Sam Mefford > Assignee: SLF4J developers list > Priority: Trivial > Fix For: 2.0.0-alpha2 > > > The last character in this paragraph appears to be incorrect: > {quote}SLF4J only cares about the _formatting anchor_, that is the '\{' character immediately followed by '}'. Thus, in case your message contains the '\{' or the '}' character, you do not have to do anything special unless the '}' character immediately follows '}'. > {quote} > Shouldn't it end with "immediately follows '\{'."? -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-479) JUL-SLF4J Bridge - sourceMethod not logged
by QOS.CH (JIRA) 16 Feb '20

16 Feb '20

[ https://jira.qos.ch/browse/SLF4J-479?page=com.atlassian.jira.plugin.system.… ] Anton Pryamostanov commented on SLF4J-479: ------------------------------------------ Kind reminder. > JUL-SLF4J Bridge - sourceMethod not logged > ------------------------------------------ > > Key: SLF4J-479 > URL: https://jira.qos.ch/browse/SLF4J-479 > Project: SLF4J > Issue Type: Bug > Environment: JUL SLF4J Bridge 1.7.x > Reporter: Anton > Assignee: SLF4J developers list > > Consider an example from MSSQL JDBC Driver: > [https://github.com/microsoft/mssql-jdbc/blob/77f9f1086049e5ea4ff11fb5434fdd…] > {code:java} > loggerExternal.entering(getClassNameLogging(), "commit");{code} > > _Actual result_: The *sourceMethodName* ("commit") is not passed to the underlying SLF4J implementation, via JUL-SLF4J Bridge. > I.e. the sourceMethod is not logged in this case. > > _Expected result:_ JUL-SLF4J Bridge should pass sourceMethodName to SLF4J implementation. > Please also check if there are any other such attributes affected. > Suggested to fix in org.slf4j.bridge.SLF4JBridgeHandler. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

JDK 14 is now in the Release Candidate Phase
by Rory O'Donnell 10 Feb '20

10 Feb '20

Hi Ceki, *Per the JDK 14 schedule [1] , we are now in the Release Candidate Phase * The stabilization repository, jdk/jdk14, *is open for P1 bug fixes * per the JDK Release Process (JEP 3) [2]. All changes require approval via the Fix-Request Process [3]. For more details, see Mark Reinhold's email to jdk-dev mailing list [4] OpenJDK 14 EA build 36 is now available at http://jdk.java.net/14 * These early access, open source builds are provided under the GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce.html>. OpenJDK 15 EA build 9 is now available at http://jdk.java.net/15 * * * These early access, open source builds are provided under the GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce.html>. * Significant changes since the last availability email: o build 8 + JDK-8235783: DatagramSocket::disconnect should allow an implementation to throw UncheckedIOException + JDK-8237528: Inefficient compilation of Pattern Matching for instanceof # Reported by JaCoCo. o build 7 + JDK-8236105: DatagramSocket.send() and MulticastSocket.send() methods throw an IllegalArgumentException + JDK-8231422: Better serial filter handling + JDK-8227758: More valid PKIX processing + JDK-8230318: Better trust store usage + JDK-8234484: Add ability to configure third port for remote JMX Project Loom Early-Access Builds - Build 15-loom+3-20 (2020/1/27) * These early-access builds are provided under the GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce.html>. * These builds are intended for developers looking to "kick the tyres" and provide feedback on using the API or by sending bug reports. Warning: This build is based on an incomplete version of JDK 14 <http://openjdk.java.net/projects/jdk/14/>. Links to FOSDEM Videos that might be of interest: * https://twitter.com/OpenJDK/status/1225008387009785857 * https://twitter.com/OpenJDK/status/1225011154159833088 * https://twitter.com/OpenJDK/status/1225009792596488193 Regards, Rory [1] https://openjdk.java.net/projects/jdk/14/#Schedule [2] https://openjdk.java.net/jeps/3 [3] https://openjdk.java.net/jeps/3#Fix-Request-Process [4] https://mail.openjdk.java.net/pipermail/jdk-dev/2020-February/003885.html -- Rgds, Rory O'Donnell Quality Engineering Manager Oracle EMEA, Dublin, Ireland

1 0

[JIRA] (SLF4J-421) LoggerWrapper and subclasses perform argument substitution twice
by QOS.CH (JIRA) 09 Feb '20

09 Feb '20

[ https://jira.qos.ch/browse/SLF4J-421?page=com.atlassian.jira.plugin.system.… ] Jonathan Esssex commented on SLF4J-421: --------------------------------------- I just submitted a PR for this > LoggerWrapper and subclasses perform argument substitution twice > ----------------------------------------------------------------- > > Key: SLF4J-421 > URL: https://jira.qos.ch/browse/SLF4J-421 > Project: SLF4J > Issue Type: Bug > Components: slf4j-ext > Affects Versions: 1.7.x > Environment: Java 8; haven't tested with earlier versions or Java 9. > Reporter: Kristin Clemens > Assignee: SLF4J developers list > Labels: logging, substitution > Fix For: 2.0.0-alpha2 > > Attachments: log4j2.xml, ReproduceSlf4jExtBug.java, results.txt > > > If a String containing "{}" (alone or with other characters) is passed to a LoggerWrapper log method that takes a format string and arguments, or to a subclass method that follows the same pattern, a situation can occur where an argument is substituted into the place of the argument containing the substitution brackets. That argument may be another string preceding the string with brackets, or if the string with brackets is first, it may be that argument itself. > This also occurs with log methods following this pattern even when a string format message is not expected, such as with XLogger entry and exit methods or LoggerWrapper single argument methods. > It's hard to describe effectively, so I'll provide some examples and test cases to help. > {code:java|title=Brackets Second|borderStyle=solid} > log.error("{},{}", foo, "[{}]"); > // Expected > [ERROR] ReproduceSlf4jBug - foo,[{}] > // Actual > [ERROR] ReproduceSlf4jBug - foo,[foo] > {code} > {code:java|title=Brackets First|borderStyle=solid} > log.error("{},{}", "[{}]", foo); > // Expected > [ERROR] ReproduceSlf4jBug - [{}],foo > // Actual > [ERROR] ReproduceSlf4jBug - [[{}]],foo > {code} > *In the attached tests, a basic org.slf4j.Logger is tested with the same arguments to provide a reference.* -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-421) LoggerWrapper and subclasses perform argument substitution twice
by QOS.CH (JIRA) 09 Feb '20

09 Feb '20

[ https://jira.qos.ch/browse/SLF4J-421?page=com.atlassian.jira.plugin.system.… ] Jonathan Esssex commented on SLF4J-421: --------------------------------------- This is surely a colossal headache for anyone doing much work with Json in Java... > LoggerWrapper and subclasses perform argument substitution twice > ----------------------------------------------------------------- > > Key: SLF4J-421 > URL: https://jira.qos.ch/browse/SLF4J-421 > Project: SLF4J > Issue Type: Bug > Components: slf4j-ext > Affects Versions: 1.7.x > Environment: Java 8; haven't tested with earlier versions or Java 9. > Reporter: Kristin Clemens > Assignee: SLF4J developers list > Labels: logging, substitution > Attachments: log4j2.xml, ReproduceSlf4jExtBug.java, results.txt > > > If a String containing "{}" (alone or with other characters) is passed to a LoggerWrapper log method that takes a format string and arguments, or to a subclass method that follows the same pattern, a situation can occur where an argument is substituted into the place of the argument containing the substitution brackets. That argument may be another string preceding the string with brackets, or if the string with brackets is first, it may be that argument itself. > This also occurs with log methods following this pattern even when a string format message is not expected, such as with XLogger entry and exit methods or LoggerWrapper single argument methods. > It's hard to describe effectively, so I'll provide some examples and test cases to help. > {code:java|title=Brackets Second|borderStyle=solid} > log.error("{},{}", foo, "[{}]"); > // Expected > [ERROR] ReproduceSlf4jBug - foo,[{}] > // Actual > [ERROR] ReproduceSlf4jBug - foo,[foo] > {code} > {code:java|title=Brackets First|borderStyle=solid} > log.error("{},{}", "[{}]", foo); > // Expected > [ERROR] ReproduceSlf4jBug - [{}],foo > // Actual > [ERROR] ReproduceSlf4jBug - [[{}]],foo > {code} > *In the attached tests, a basic org.slf4j.Logger is tested with the same arguments to provide a reference.* -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-484) Do not mark alpha versions as "release" in maven
by QOS.CH (JIRA) 04 Feb '20

04 Feb '20

Janek created SLF4J-484: --------------------------- Summary: Do not mark alpha versions as "release" in maven Key: SLF4J-484 URL: https://jira.qos.ch/browse/SLF4J-484 Project: SLF4J Issue Type: Bug Components: slf4j-simple Reporter: Janek Assignee: SLF4J developers list Priority: Minor https://jcenter.bintray.com/org/slf4j/slf4j-simple/maven-metadata.xml Currently contains the following lines: {code:xml} <version>2.0.0-alpha1</version> <versioning> <latest>2.0.0-alpha1</latest> <release>2.0.0-alpha1</release> {code} But, if I am not misunderstanding maven versioning, it should actually be like this, so that the stable version is the default: {code:xml} <version>1.7.30</version> <versioning> <latest>2.0.0-alpha1</latest> <release>1.7.30</release> {code} I have so far only looked into slf4j-simple. but this might affect other dependencies as well. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0