July 2011 - slf4j-dev - mailman3.qos.ch

[Bug 186] New: [patch] Enhanced SimpleLogger implementation
by bugzilla-daemon＠pixie.qos.ch 12 Jun '12

12 Jun '12

http://bugzilla.slf4j.org/show_bug.cgi?id=186 Summary: [patch] Enhanced SimpleLogger implementation Product: SLF4J Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Implementations AssignedTo: slf4j-dev(a)qos.ch ReportedBy: cedrik.lime(a)gmail.com Created an attachment (id=70) --> (http://bugzilla.slf4j.org/attachment.cgi?id=70) New implementation of SimpleLogger I recently had to enhance SimpleLogger by back-porting some functionalities of commons-logging's SimpleLog into it. Namely, I have added the following: * optional configuration file; if none found, you get the exact same set of features as the currently released SimpleLogger. * enable to log more than the info log level * enable to set different log levels for different Loggers * enable to show/hide thread name * very primitive log messages customisation (about the same as commons-logging) Once again, the new code is totally compatible in behaviour and output with the currently released SimpleLogger. I also made it so that current users of commons-logging can upgrade to SLF4J very easily. Finally, I made sure to keep SimpleLogger as simple as possible: we already have fully-fledged logging frameworks, let's not re-invent one! I think this new implementation would enhance the value of SLF4J, while keeping a perfect retro-compatibility with previous versions. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 11

[Bug 219] New: Typo in error message
by bugzilla-daemon＠pixie.qos.ch 19 Apr '12

19 Apr '12

http://bugzilla.slf4j.org/show_bug.cgi?id=219 Summary: Typo in error message Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Windows NT Status: NEW Severity: blocker Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: cowwoc(a)bbs.darktech.org Replace "becasue" with "because" across the slf4j code-base. I got this specific error message: SLF4J: The following loggers will not work becasue they were created SLF4J: during the default configuration phase of the underlying logging system. SLF4J: See also http://www.slf4j.org/codes.html#substituteLogger -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 2

[Bug 166] New: please add OSGI informations to jul-to-slf4j-1.5.10.jar
by bugzilla-daemon＠pixie.qos.ch 02 Sep '11

02 Sep '11

http://bugzilla.slf4j.org/show_bug.cgi?id=166 Summary: please add OSGI informations to jul-to-slf4j-1.5.10.jar Product: SLF4J Version: 1.5.x Platform: All OS/Version: Mac OS X 10.3 Status: NEW Severity: normal Priority: P3 Component: Unspecified AssignedTo: slf4j-dev(a)qos.ch ReportedBy: ekke(a)ekkes-corner.org jul-to-slf4j-1.5.10.jar MANIFEST.MF is missing OSGI Informations ... Import-Package: org.slf4j;version="1.5.10", org.slf4j.spi;version="1.5.10" Export-Package: org.slf4j.bridge;version="1.5.10" ... so you have to wrap it by yourself or as workaround use the Bundle provided by SpringSource: http://www.springsource.com/repository/app/bundle/version/detail?name=com.s… ----- thx ekke -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

[Bug 228] New: java.lang.NoClassDefFoundError: org.slf4j.impl.StaticLoggerBinder
by bugzilla-daemon＠pixie.qos.ch 15 Aug '11

15 Aug '11

http://bugzilla.slf4j.org/show_bug.cgi?id=228 Summary: java.lang.NoClassDefFoundError: org.slf4j.impl.StaticLoggerBinder Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Windows NT Status: NEW Severity: normal Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: kevinth.fang(a)gmail.com This exception thrown when no binding package included in the classpath. I'm using 1.6.1 jar. I think above 1.6 the api jar should not throw this exception because it should use the NOP binding by default. I tried 2 jdks. for sun jdk 1.5 there is no such exceptions. But for ibm jdk 1.6 this exception is thrown. I think the logic in LoggerFactory used to decide the binding is not strong enough. It just search the substring "org/slf4j/impl/StaticLoggerBinder" in the exception message. Different jdks may throw different messages. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 5

[Bug 163] New: Copy & paste of LoggerFactory.getLogger
by bugzilla-daemon＠pixie.qos.ch 19 Jul '11

19 Jul '11

http://bugzilla.slf4j.org/show_bug.cgi?id=163 Summary: Copy & paste of LoggerFactory.getLogger Product: SLF4J Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: thomas.tom.mueller(a)gmail.com This is a feature request. Currently, when I create a new logger in a class, I copy & paste the following line from another class: private static Logger log = LoggerFactory.getLogger(AcmeImpl.class); Sometimes I forget to change the class name. SLF4J could help me here. I suggest to add a new method, so the class name is not required, so that I can copy & paste the line without having to remember that I have to change the class name. Also, it's a bit shorter: private static Logger log = LoggerFactory.getCallerClassLogger(); This is copy & paste friendly. The implementation is tricky, but trivial once you understand it: getCallerClassLogger() { return getLogger(new Error().getStackTrace()[1].getClassName()); } There is a project that tries to solve the copy & paste problem: http://code.google.com/p/morbok/ -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 40

[Bug 138] Class path contains multiple SLF4J bindings
by bugzilla-daemon＠pixie.qos.ch 11 Jul '11

11 Jul '11

http://bugzilla.slf4j.org/show_bug.cgi?id=138 Mike Watson <michael.f.watson(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.f.watson(a)gmail.com --- Comment #22 from Mike Watson <michael.f.watson(a)gmail.com> 2011-07-12 01:41:25 CEST --- +1 to change this to a set. Is it really such a big deal to fix this? As several people have commented, a Set fits better anyway and getting these warnings makes slf4j look flaky to the untrained eye. Multiple WAR EAR files are very common, as are custom classloading structures (e.g: we combine every module within an EAR into a single classloader). -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 225] New: log4j-over-slf4j Compatibility Enhancements: PropertyConfigurator, DOMConfigurator, NDC.
by bugzilla-daemon＠pixie.qos.ch 07 Jul '11

07 Jul '11

http://bugzilla.slf4j.org/show_bug.cgi?id=225 Summary: log4j-over-slf4j Compatibility Enhancements: PropertyConfigurator, DOMConfigurator, NDC. Product: SLF4J Version: 1.6.x Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P1 Component: log4j-over-slf4j AssignedTo: slf4j-dev(a)qos.ch ReportedBy: jmsteward(a)gmail.com I'm currently developing a new project for my employer and recently made the decision to replace log4j with slf4j & logback. However as close as I came to completing this replacement I have finally come to terms with its impracticability and will need to unfortunately undo my changes & revert to log4j. The reason is because we have a number of first-party reusable "component" libraries that have been around for a decade or so. My new project, like many many of our other projects, require some parts of these legacy components. Because of the sheer number of scattered projects dependent on these components I am absolutely unable to alter any of their code. So I setup my new project with slf4j-api-1.6.1.jar, slf4j-ext-1.6.1.jar, logback-classic-0.9.29.jar & logback-core-0.9.29.jar, and I setup the legacy components to use log4j-over-slf4j-1.6.1.jar, slf4j-api-1.6.1.jar & slf4j-ext-1.6.1.jar. PropertyConfigurator Issue: A class used by many other projects for universal logging configuration exists in one of these component libraries and it uses org.apache.log4j.PropertyConfigurator. Although my project does not use the aforementioned class, it does require other classes from the library in question. Per reading through slf4j documentation I understand PropertyConfigurator is intended not to be supported. I understand the decision not to support its functionality but it doesn't make much sense to me that it should prevent code from compiling. I just need to be able to compile this code using log4j-over-slf4j, whether or not PropertyConfigurator is fully functional is a non-issue as my project does not use it, though other projects do use it and log4j will likely indefinitely remain in their classpaths'. So I propose a "bare bones" class be created at org.apache.log4j.PropertyConfigurator within log4j-over-slf4j. While it doesn't affect me I think it makes sense for org.apache.log4j.xml.DOMConfigurator too. Although I do see that org.apache.log4j.xml.DOMConfigurator does exist in the slf4j repository. Is that a sign this is being addressed? NDC Issue: This is a similar issue, where NDC is used within a legacy component, but my project also relies on that legacy usage of NDC for its contents to ultimately be apart of the log's pattern. This is subsequently used for reporting purposes. I came across the bug, that I can now not locate, where org.slf4j.NDC was added to slf4j-ext built atop org.slf4j.MDC with some basic functionality. NDC compiled fine using log4j-over-slf4j so I thought I was in the clear. I went ahead and wrote a class extending ClassicConverter that emulates log4j's NDC pattern so my new project that was using logback could output the NDC contents that the legacy component was controlling through org.apache.log4j.NDC. Nothing outputted to my log from the NDC pattern. I determined my NdcConverter class, conversion rule, and pattern were all correct. The break is between log4j-over-slf4j's org.apache.log4j.NDC and slf4j-ext's org.slf4j.NDC. org.apache.log4j.NDC is purely "bare bones" with all the methods but nothing within them. It doesn't make sense NDC, also seemingly unofficially supported by slf4j, has functionality in slf4j-ext but not the legacy bridge log4j-over-slf4j. This should be resolved in a similar manner as log4j-over-slf4j's org.apache.log4j.MDC and slf4j-api's org.slf4j.MDC where the former's methods call the latter's methods. Or would it be better design for the org.apache.log4j classes (MDC & NDC) to extend their org.slf4j countparts? I found Bug 170 that dismisses this NDC idea due to ... "This would require a slf4j-ext dependency in log4j-over-slf4j. Because of that, log4j-over-slf4j would then require Java>=1.5." ... Has a log4j-over-slf4j-ext component been considered? Perhaps you could migrate the loosely supported items to such a component; e.g. org.apache.log4j.NDC, org.apache.log4j.PropertyConfigurator & org.apache.log4j.xml.DOMConfigurator. While I'm designing things to be portable and allow for our legacy libraries to be purged and switched out with brand new code, it is not a possibility any time soon. I require those libraries to get other more crucial parts of the project into production. So slf4j is not an option for me despite my preference for it. These scenarios are not unique to me and I hope slf4j addresses them so it can become a more realistic option for those transitioning out of legacy code bases. Happy trails. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 9

[GIT] SLF4J: Simple Logging Facade for Java branch, master, updated. v_1.6.1-35-g8a32939
by git-noreply＠pixie.qos.ch 07 Jul '11

07 Jul '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 8a329393cca7f5723e76ab87c77f6e9f0dc37c4f (commit) from d9e7175fb77832e2366a5755995bb14399f015fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=8a329393cca7f5723e76ab87c7… http://github.com/ceki/slf4j/commit/8a329393cca7f5723e76ab87c77f6e9f0dc37c4f commit 8a329393cca7f5723e76ab87c77f6e9f0dc37c4f Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Jul 7 22:27:13 2011 +0200 fix bug 225 diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/BasicConfigurator.java similarity index 56% copy from log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java copy to log4j-over-slf4j/src/main/java/org/apache/log4j/BasicConfigurator.java index a9570ac..6dd9d57 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/BasicConfigurator.java @@ -14,53 +14,18 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.log4j; -import java.util.Stack; - /** - * A bare-bones implementation of log4j's NDC which compiles and prevents run - * time exceptions. - * - * @since SLF4J 1.6.0 + * A minimal (nop) implementation of BasicConfigurator. */ - -public class NDC { - - public static void clear() { - } - - public static Stack cloneStack() { - return null; - } - - public static void inherit(Stack stack) { - } - - static public String get() { - return null; - } - - public static int getDepth() { - return 0; - } - - public static String pop() { - return ""; +public class BasicConfigurator { + public static void configure() { } - public static String peek() { - return ""; + public static void configure(Appender appender) { } - public static void push(String message) { + public static void resetConfiguration() { } - - static public void remove() { - } - - static public void setMaxDepth(int maxDepth) { - } - } diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java index a9570ac..a2d0451 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java @@ -17,18 +17,26 @@ package org.apache.log4j; +import org.slf4j.MDC; + import java.util.Stack; /** - * A bare-bones implementation of log4j's NDC which compiles and prevents run - * time exceptions. - * + * A log4j's NDC implemented in terms of SLF4J MDC primitives. + * * @since SLF4J 1.6.0 */ public class NDC { + public final static String PREFIX = "NDC"; + public static void clear() { + int depth = getDepth(); + for (int i = 0; i < depth; i++) { + String key = PREFIX + i; + MDC.remove(key); + } } public static Stack cloneStack() { @@ -43,21 +51,48 @@ public class NDC { } public static int getDepth() { - return 0; + int i = 0; + while (true) { + String val = MDC.get(PREFIX + i); + if (val != null) { + i++; + } else { + break; + } + } + return i; } public static String pop() { - return ""; + int next = getDepth(); + if (next == 0) { + return ""; + } + int last = next - 1; + String key = PREFIX + last; + String val = MDC.get(key); + MDC.remove(key); + return val; } public static String peek() { - return ""; + int next = getDepth(); + if (next == 0) { + return ""; + } + int last = next - 1; + String key = PREFIX + last; + String val = MDC.get(key); + return val; } public static void push(String message) { + int next = getDepth(); + MDC.put(PREFIX + next, message); } static public void remove() { + clear(); } static public void setMaxDepth(int maxDepth) { diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/PropertyConfigurator.java similarity index 52% copy from log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java copy to log4j-over-slf4j/src/main/java/org/apache/log4j/PropertyConfigurator.java index a9570ac..9c0dc7c 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/NDC.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/PropertyConfigurator.java @@ -14,53 +14,39 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.log4j; -import java.util.Stack; +import java.net.URL; +import java.util.Properties; + +import org.apache.log4j.spi.Configurator; +import org.apache.log4j.spi.LoggerRepository; /** - * A bare-bones implementation of log4j's NDC which compiles and prevents run - * time exceptions. - * - * @since SLF4J 1.6.0 + * An nop implementation of PropertyConfigurator. */ - -public class NDC { - - public static void clear() { +public class PropertyConfigurator implements Configurator { + public static void configure(Properties properties) { } - public static Stack cloneStack() { - return null; + public static void configure(String configFilename) { } - public static void inherit(Stack stack) { + public static void configure(java.net.URL configURL) { } - static public String get() { - return null; + public static void configureAndWatch(String configFilename) { } - public static int getDepth() { - return 0; + public static void configureAndWatch(String configFilename, long delay) { } - public static String pop() { - return ""; + public void doConfigure(Properties properties, LoggerRepository hierarchy) { } - public static String peek() { - return ""; + public void doConfigure(String configFileName, LoggerRepository hierarchy) { } - public static void push(String message) { + public void doConfigure(URL configURL, LoggerRepository hierarchy) { } - - static public void remove() { - } - - static public void setMaxDepth(int maxDepth) { - } - } diff --git a/log4j-over-slf4j/src/main/java/org/apache/log4j/xml/DOMConfigurator.java b/log4j-over-slf4j/src/main/java/org/apache/log4j/xml/DOMConfigurator.java index 177feae..0fbd019 100644 --- a/log4j-over-slf4j/src/main/java/org/apache/log4j/xml/DOMConfigurator.java +++ b/log4j-over-slf4j/src/main/java/org/apache/log4j/xml/DOMConfigurator.java @@ -19,14 +19,48 @@ import org.apache.log4j.spi.Configurator; import org.apache.log4j.spi.LoggerRepository; import javax.xml.parsers.FactoryConfigurationError; +import java.io.InputStream; +import java.io.Reader; import java.net.URL; +import java.util.Properties; +import org.w3c.dom.Element; + public class DOMConfigurator implements Configurator { - static public void configure(URL url) throws FactoryConfigurationError { - } + public static void configure(Element element) { + } + + public static void configure(String filename) throws FactoryConfigurationError { + } + + static public void configure(URL url) throws FactoryConfigurationError { + } + + static public void configureAndWatch(String configFilename) { + } + + public static void configureAndWatch(String configFilename, long delay) { + } + + public void doConfigure(Element element, LoggerRepository repository) { + } + + public void doConfigure(InputStream inputStream, LoggerRepository repository) throws FactoryConfigurationError { + } + + public void doConfigure(Reader reader, LoggerRepository repository) throws FactoryConfigurationError { + } + + public void doConfigure(String filename, LoggerRepository repository) { + } + + public void doConfigure(URL url, LoggerRepository repository) { + } + + public static String subst(String value, Properties props) { + return value; + } - public void doConfigure(URL url, LoggerRepository repository) { - } } diff --git a/log4j-over-slf4j/src/test/java/org/apache/log4j/NDCTest.java b/log4j-over-slf4j/src/test/java/org/apache/log4j/NDCTest.java new file mode 100644 index 0000000..adaab9d --- /dev/null +++ b/log4j-over-slf4j/src/test/java/org/apache/log4j/NDCTest.java @@ -0,0 +1,37 @@ +package org.apache.log4j; + +import junit.framework.TestCase; + +/** + * @author Ceki Gücü + */ +public class NDCTest extends TestCase { + + + public void setUp() { + assertEquals(0, NDC.getDepth()); + } + + public void tearDown() { + NDC.clear(); + } + + public void testSmoke() { + NDC.push("a"); + String back = NDC.pop(); + assertEquals("a", back); + } + + public void testPop() { + NDC.push("peek"); + String back = NDC.peek(); + assertEquals("peek", back); + } + + public void testClear() { + NDC.push("clear"); + NDC.clear(); + assertEquals(0, NDC.getDepth()); + } + +} diff --git a/slf4j-site/src/site/pages/news.html b/slf4j-site/src/site/pages/news.html index d42b4d4..a60a10e 100644 --- a/slf4j-site/src/site/pages/news.html +++ b/slf4j-site/src/site/pages/news.html @@ -29,6 +29,16 @@ <hr noshade="noshade" size="1"/> + <h3>, 2011 - Release of SLF4J 1.6.2</h3> + + <p>Added certain missing classes to the log4j-over-slf4j module as + requested in <a + href="http://bugzilla.slf4j.org/show_bug.cgi?id=225">bug 225</a> by + Josh Stewart. + </p> + + <hr noshade="noshade" size="1"/> + <h3>July 5th, 2010 - Release of SLF4J 1.6.1</h3> <p>Updated log4j dependency to version 1.2.16 and <a ----------------------------------------------------------------------- Summary of changes: .../log4j/{NDC.java => BasicConfigurator.java} | 45 ++----------------- .../src/main/java/org/apache/log4j/NDC.java | 47 +++++++++++++++++--- .../log4j/{NDC.java => PropertyConfigurator.java} | 44 ++++++------------ .../java/org/apache/log4j/xml/DOMConfigurator.java | 42 ++++++++++++++++-- .../src/test/java/org/apache/log4j/NDCTest.java | 37 +++++++++++++++ slf4j-site/src/site/pages/news.html | 10 ++++ 6 files changed, 146 insertions(+), 79 deletions(-) copy log4j-over-slf4j/src/main/java/org/apache/log4j/{NDC.java => BasicConfigurator.java} (56%) copy log4j-over-slf4j/src/main/java/org/apache/log4j/{NDC.java => PropertyConfigurator.java} (52%) create mode 100644 log4j-over-slf4j/src/test/java/org/apache/log4j/NDCTest.java hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[Bug 224] New: BasicMDCAdapter.getCopyOfContextMap can lead to ConcurrentModificationException
by bugzilla-daemon＠pixie.qos.ch 07 Jul '11

07 Jul '11

http://bugzilla.slf4j.org/show_bug.cgi?id=224 Summary: BasicMDCAdapter.getCopyOfContextMap can lead to ConcurrentModificationException Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: alex.boisvert(a)gmail.com As illustrated by this stacktrace, java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) at java.util.HashMap$EntryIterator.next(HashMap.java:834) at java.util.HashMap$EntryIterator.next(HashMap.java:832) at java.util.HashMap.putAllForCreate(HashMap.java:435) at java.util.HashMap.<init>(HashMap.java:225) at org.slf4j.helpers.BasicMDCAdapter.getCopyOfContextMap(BasicMDCAdapter.java:130) at org.slf4j.MDC.getCopyOfContextMap(MDC.java:176) at com.bizo.logging.SmtpHandler.publish(SmtpHandler.java:65) at java.util.logging.Logger.log(Logger.java:458) at java.util.logging.Logger.doLog(Logger.java:480) at java.util.logging.Logger.log(Logger.java:503) at java.util.logging.Logger.info(Logger.java:1022) it appears that if BasicMDCAdapter.getCopyOfContextMap() is called while the parent thread is mutating the context, a ConcurrentModificationException can be thrown. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 2