December 2012 - slf4j-dev - mailman3.qos.ch

[Bug 239] New: performance issue in MessageFormatter
by bugzilla-daemon＠pixie.qos.ch 09 Jun '13

09 Jun '13

http://bugzilla.slf4j.org/show_bug.cgi?id=239 Summary: performance issue in MessageFormatter Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: kite668(a)mail.ru 1. org.slf4j.helpers.MessageFormatter.arrayFormat uses localy thread-safe StringBuffer instead of StringBuilder. I think it can be safely replaced. 2. "deeplyAppendParameter(sbuf, argArray[L], new HashMap());" - this is called for EVERY argument, even if it isn't array. I think instance of HashMap shouldn't be created for every argument. You can pass null and initialize HashMap in deeplyAppendParameter only for object's arrays and if it's previous value is null. Also you can initialize this map with initial capacity = array's size. 3. It will be very good if method arrayFormat would receive StringBuilder instead of creating instance of result String. This is common and more fast solution. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 3

[Bug 227] New: org.apache.log4j.Layout mistakenly in org.apache.log4j.spi
by bugzilla-daemon＠pixie.qos.ch 07 Jun '13

07 Jun '13

http://bugzilla.slf4j.org/show_bug.cgi?id=227 Summary: org.apache.log4j.Layout mistakenly in org.apache.log4j.spi Product: SLF4J Version: 1.6.x Platform: All OS/Version: All Status: NEW Severity: blocker Priority: P1 Component: log4j-over-slf4j AssignedTo: slf4j-dev(a)qos.ch ReportedBy: jmsteward(a)gmail.com This may block development that should reference org.apache.log4j.Layout. Currently in the log4j-over-slf4j component Layout mistakenly exists at org.apache.log4j.spi and should be moved to org.apache.log4j. org.apache.log4j.Appender will need refactoring to remove the line "import org.apache.log4j.spi.Layout;". -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 4

[Bug 205] New: make multiple bindings check more intelligent
by bugzilla-daemon＠pixie.qos.ch 13 May '13

13 May '13

http://bugzilla.slf4j.org/show_bug.cgi?id=205 Summary: make multiple bindings check more intelligent Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Linux Status: NEW Severity: trivial Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: gsubes(a)gmail.com I'am using SLF4J in a setup of a software product line where multiple eclipse projects (as modules) are used with their own dependency management. so every module has its own copy of the logger binding jar. the modules have references to other modules (vie eclipse project references) and thus have multiple versions of the same logger binding in the classpath when tests are run etc. This results in always receiving this warning: SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/subes/Dokumente/Entwicklung/invesdwin/inv-webproxy/trunk/03_module/invesdwin-gemeinsam/lib/default/logback-classic-0.9.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/subes/Dokumente/Entwicklung/invesdwin/inv-webproxy/trunk/03_module/invesdwin-gemeinsam-integration/lib/default/logback-classic-0.9.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/subes/Dokumente/Entwicklung/invesdwin/inv-webproxy/trunk/03_module/invesdwin-gemeinsam-integration-ws/lib/default/logback-classic-0.9.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/subes/Dokumente/Entwicklung/invesdwin/inv-webproxy/trunk/03_module/invesdwin-gemeinsam-webserver/lib/default/logback-classic-0.9.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. -------------------------------- It would be nice if slf4j would check if the bindings actually have the same name and then ignore multiple jars of the same binding. the warning is made without a real reason in this particular case and should be more intelligent to allow such use cases. Or at least give me a hint on how to disable this warning on my own account. :) -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 4

[Bug 285] New: Misc slf4j-simple fixes and enhancements
by bugzilla-daemon＠qos.ch 18 Mar '13

18 Mar '13

http://bugzilla.slf4j.org/show_bug.cgi?id=285 Summary: Misc slf4j-simple fixes and enhancements Product: SLF4J Version: 1.6.x Platform: All OS/Version: All Status: NEW Severity: normal Priority: P1 Component: Implementations AssignedTo: slf4j-dev(a)qos.ch ReportedBy: cedrik.lime(a)gmail.com (Note: version should be 1.7.x, which is unavailable in Bugzilla) Recent 1.7.x versions of SLF4J inadvertently broke the ability to turn off a given logger (in SimpleLogger module). This following pull request fixes this, as well as the following minor points: Bug fixes ========= * regression: restore ability to completely turn off logging for a given logger (level "off") * bug fix: force output file (if any) to UTF-8 to avoid platform-dependent surprises while logging to a file Enhancements ============ * Java 5 syntax (less Eclipse warnings) * update documentation (including example simplelogger.properties file which was out of sync with recent 1.7.[1-2] changes) * add SimpleLoggerAccess class to enable to change SimpleLogger logger levels at runtime (used e.g. in a monitoring utility) You will find all of those in pull request 28: https://github.com/qos-ch/slf4j/pull/28 Thanks! -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 1

[Bug 212] New: MessageFormat. format throws Exception when attempting to parse parameters
by bugzilla-daemon＠pixie.qos.ch 13 Mar '13

13 Mar '13

http://bugzilla.slf4j.org/show_bug.cgi?id=212 Summary: MessageFormat.format throws Exception when attempting to parse parameters Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Mac OS X 10.3 Status: NEW Severity: blocker Priority: P1 Component: jul-to-slf4j AssignedTo: slf4j-dev(a)qos.ch ReportedBy: kristof.pelckmans(a)wondergraphs.com I am trying to bridge a LogRecord with a message that is the result of HashMap.toString(): {interface com.google.code.morphia.annotations.Id=(a)com.google.code.morphia.annotations.Id()} and get following exception Caused by: java.lang.IllegalArgumentException: can't parse argument number interface com.google.code.morphia.annotations.Id=(a)com.google.code.morphia.annotations.Id() at java.text.MessageFormat.makeFormat(MessageFormat.java:1339) at java.text.MessageFormat.applyPattern(MessageFormat.java:458) at java.text.MessageFormat.<init>(MessageFormat.java:350) at java.text.MessageFormat.format(MessageFormat.java:811) at org.slf4j.bridge.SLF4JBridgeHandler.getMessageI18N(SLF4JBridgeHandler.java:233) FIX: do not format since there are no parameters! if (params != null && params.length > 0) -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 1

[Bug 236] New: Use standard java.util.ServiceLoader for SLF4J Binding
by bugzilla-daemon＠pixie.qos.ch 25 Feb '13

25 Feb '13

http://bugzilla.slf4j.org/show_bug.cgi?id=236 Summary: Use standard java.util.ServiceLoader for SLF4J Binding Product: SLF4J Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: cronier.jy(a)gmail.com What about use ServiceLoader to find which binding to use? For JDK<1.6 compatibility, we can test Class.forName("java.util.ServiceLoader") and switch to an internal equivalent implementation of ServiceLoader. No need to have one (or multiple) StaticLoggerBinder. This ServiceLoader is used, for example, for JRE XSL implementation, or java.sql.Driver. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 10

[Bug 287] New: Beautification of error message in Logger.createChildByName()
by bugzilla-daemon＠qos.ch 20 Dec '12

20 Dec '12

http://bugzilla.slf4j.org/show_bug.cgi?id=287 Summary: Beautification of error message in Logger.createChildByName() Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Linux Status: NEW Severity: minor Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: d.tonhofer(a)m-plify.com Currently the following text is generated: throw new IllegalArgumentException("For logger [" + this.name + "] child name [" + childName + " passed as parameter, may not include '.' after index" + (this.name.length() + 1)); This is missing a ] and a " ", (I also would replace "index" by "position" and use CoreConstants.DOT) thus: throw new IllegalArgumentException("For logger [" + this.name + "], child name [" + childName + "] passed as parameter may not include the dot separator '" + CoreConstants.DOT + "' after position " + (this.name.length() + 1)); -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

2 4

[Bug 288] New: Problematic logger name splitting via Logger.getSeparatorIndexOf()
by bugzilla-daemon＠qos.ch 20 Dec '12

20 Dec '12

http://bugzilla.slf4j.org/show_bug.cgi?id=288 Summary: Problematic logger name splitting via Logger.getSeparatorIndexOf() Product: SLF4J Version: 1.6.x Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Core API AssignedTo: slf4j-dev(a)qos.ch ReportedBy: d.tonhofer(a)m-plify.com In the Logger class, the method getSeparatorIndexOf() is used to separate off child logger names (basically, to do String.split() on "name"). It looks for the occurrence of DOT or DOLLAR: --------------- static int getSeparatorIndexOf(String name, int fromIndex) { int i = name.indexOf(CoreConstants.DOT, fromIndex); if (i != -1) { return i; } else { return name.indexOf(CoreConstants.DOLLAR, fromIndex); } } --------------- LoggerContext.getLogger() uses the above to split a passed "name" String. The logic, however is peculiar. getSeparatorIndexOf() splits a String along the DOT. Unless that is impossible, in which case it splits it along the DOLLAR. Unfortunately, LoggerContext.getLogger() may then behave surprisingly The name "A.B.C$D" will give the Logger chain A -> A.B -> A.B.C -> A.B.C.D as expected The name "A.B$C.D" could give the Logger chain A -> A.B -> A.B.C -> A.B.C.D but construction will fail! Because: Decomposition via getSeparatorIndexOf() will yield A , B$C , D But construction of a Logger in LoggerContext.getLogger() named "B$C" will fail because that method checks whether decomposition is still possible; given "B$C" it will indeed find that decomposition is still possible, along the $ sign. It will thus throw. The problem occurs in case of Logger names like: "com.mplify.msgserver.ReceiverStickyPersistentStore$ReceiverStickyUpdateTransactionCallback.<clinit>" This was an acceptable name in 1.6 but causes an exception in 1.7.4 Splitting should probably be done with a modified function: static int getSeparatorIndexOf(String name, int fromIndex) { int i = name.indexOf(CoreConstants.DOT, fromIndex); int j = name.indexOf(CoreConstants.DOLLAR, fromIndex); if (i < 0) { return j; } else if (j < 0) { return i; } else { return (i < j) ? i : j; } } which splits along DOT and DOLLAR. Problem here: Properly recompositing the name from the logger chain will demand that one stores whether the preceding separator was DOT or DOLLAR. And are the names "A.B$C" and "A$B.C" actually equivalent? P.S. : Another problem: What about "A..B"? Should Logger.createChildByName(final String childName) not check that is not passed the empty string? Currently it does not. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 4

[qos-ch/slf4j] 8be3de: typo fix
by Ceki Gulcu 16 Dec '12

16 Dec '12

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 8be3de03609c6d19f2d5296311aeb1dde3a4f910 https://github.com/qos-ch/slf4j/commit/8be3de03609c6d19f2d5296311aeb1dde3a4… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-12-16 (Sun, 16 Dec 2012) Changed paths: M slf4j-site/src/site/pages/manual.html Log Message: ----------- typo fix

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch master updated. v_1.7.2-4-g8be3de0
by git-noreply＠pixie.qos.ch 16 Dec '12

16 Dec '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 8be3de03609c6d19f2d5296311aeb1dde3a4f910 (commit) from 30f8bf465e61bc127a14adc39243a9db52624ae2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=8be3de03609c6d19f2d5296311… http://github.com/ceki/slf4j/commit/8be3de03609c6d19f2d5296311aeb1dde3a4f910 commit 8be3de03609c6d19f2d5296311aeb1dde3a4f910 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sun Dec 16 22:47:44 2012 +0100 typo fix diff --git a/slf4j-site/src/site/pages/manual.html b/slf4j-site/src/site/pages/manual.html index 490bdb9..03c0888 100644 --- a/slf4j-site/src/site/pages/manual.html +++ b/slf4j-site/src/site/pages/manual.html @@ -45,7 +45,7 @@ <code>Object[]</code>. Thus, the Logger interface generated by the compiler is indistinguishable in 1.7.0 from its 1.6.0 counterpart. It follows that SLF4J version 1.7.0 is totally 100% - no-ifs-or-buts compatible with SLF4J version 1.6.x.q + no-ifs-or-buts compatible with SLF4J version 1.6.x. </p> <h3 class="doAnchor" name="hello_world">Hello World</h3> ----------------------------------------------------------------------- Summary of changes: slf4j-site/src/site/pages/manual.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0