June 2012 - slf4j-dev - mailman3.qos.ch

[Bug 261] JDK14: Loggers are not serializable
by bugzilla-daemon＠qos.ch 12 Jun '12

12 Jun '12

http://bugzilla.slf4j.org/show_bug.cgi?id=261 --- Comment #8 from Thorbjørn Ravn Andersen <thorbjoern(a)gmail.com> 2012-06-12 15:49:25 CEST --- (In reply to comment #7) > I would have merged from your repo had I known about it. This bug report received no attention. The work was done as a "Well, I need a solution until the bug report makes it to a proper release", and would have been reported in when this bug got attention to. > The logger field is final because once set by JDK14LoggerAdapter's constructor, > it can no longer be changed. (Serialization breaks this encapsulation but > that's a Java language problem.) > > The JDK14LoggerAdapter, as well as all the other logger adapters, are final > because it seemed like the reasonable thing to do. It does not make sense > extend an adapter... I was unclear in my wording. I was thinking of the JDK14LoggerAdapter. If you make classes final, it is impossible to alter their behaviour, e.g. in unit tests and when debugging. I suggest that it does not make sense to make any classes in a library final. -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 261] JDK14: Loggers are not serializable
by bugzilla-daemon＠qos.ch 12 Jun '12

12 Jun '12

http://bugzilla.slf4j.org/show_bug.cgi?id=261 --- Comment #7 from Ceki Gulcu <listid(a)qos.ch> 2012-06-12 15:06:00 CEST --- I would have merged from your repo had I known about it. The logger field is final because once set by JDK14LoggerAdapter's constructor, it can no longer be changed. (Serialization breaks this encapsulation but that's a Java language problem.) The JDK14LoggerAdapter, as well as all the other logger adapters, are final because it seemed like the reasonable thing to do. It does not make sense extend an adapter... -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 261] JDK14: Loggers are not serializable
by bugzilla-daemon＠qos.ch 12 Jun '12

12 Jun '12

http://bugzilla.slf4j.org/show_bug.cgi?id=261 --- Comment #6 from Thorbjørn Ravn Andersen <thorbjoern(a)gmail.com> 2012-06-12 14:55:32 CEST --- (In reply to comment #5) > In JDK14LoggerAdapter, changing the logger field > from > final java.util.logging.Logger logger; > to > transient final java.util.logging.Logger logger; > > seems to fix the problem. See also [1]. I agree. I did the same in https://github.com/ravn/slf4j/commit/28db3fc535eacde9c5f461710d28d6fc851d4a… and that has run in production for months. Why is the logger final? -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch master updated. v_1.6.6-5-gb3e4f22
by git-noreply＠pixie.qos.ch 12 Jun '12

12 Jun '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via b3e4f220b80c30c7bb9a462dde5aed17d90950eb (commit) from 2cf1b399928f7460277e5d057f8297e2e0551945 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=b3e4f220b80c30c7bb9a462dde… http://github.com/ceki/slf4j/commit/b3e4f220b80c30c7bb9a462dde5aed17d90950eb commit b3e4f220b80c30c7bb9a462dde5aed17d90950eb Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jun 12 14:52:22 2012 +0200 mention fixing bug 261 diff --git a/slf4j-site/src/site/pages/news.html b/slf4j-site/src/site/pages/news.html index f5b3c9d..88713a2 100644 --- a/slf4j-site/src/site/pages/news.html +++ b/slf4j-site/src/site/pages/news.html @@ -29,7 +29,17 @@ <hr noshade="noshade" size="1"/> - <h3>11th of June, 2012 of SLF4J 1.6.6</h3> + <h3>2012 - Release of SLF4J 1.6.7</h3> + + <p>The logger field (of type <code>java.util.logging.Logger</code>) + in <code>JDK14LoggerAdapter</code> is now marked as transient. This + fixes <a href="http://bugzilla.slf4j.org/show_bug.cgi?id=261">bug + #261</a>, a serialization problem reported by Thorbjørn Ravn + Andersen.</p> + + <hr noshade="noshade" size="1"/> + + <h3>11th of June, 2012 - Release of SLF4J 1.6.6</h3> <p>Source repository has been moved to <a href="https://github.com/qos-ch/slf4j">https://github.com/qos-ch/slf4j</a> ----------------------------------------------------------------------- Summary of changes: slf4j-site/src/site/pages/news.html | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[qos-ch/slf4j] b3e4f2: mention fixing bug 261
by Ceki Gulcu 12 Jun '12

12 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: b3e4f220b80c30c7bb9a462dde5aed17d90950eb https://github.com/qos-ch/slf4j/commit/b3e4f220b80c30c7bb9a462dde5aed17d909… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-12 (Tue, 12 Jun 2012) Changed paths: M slf4j-site/src/site/pages/news.html Log Message: ----------- mention fixing bug 261

1 0

[Bug 261] JDK14: Loggers are not serializable
by bugzilla-daemon＠qos.ch 12 Jun '12

12 Jun '12

http://bugzilla.slf4j.org/show_bug.cgi?id=261 Ceki Gulcu <listid(a)qos.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Ceki Gulcu <listid(a)qos.ch> 2012-06-12 14:47:01 CEST --- In JDK14LoggerAdapter, changing the logger field from final java.util.logging.Logger logger; to transient final java.util.logging.Logger logger; seems to fix the problem. See also [1]. Could you give it a try? [1] https://github.com/qos-ch/slf4j/commit/2cf1b399928f7460 -- Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch master updated. v_1.6.6-4-g2cf1b39
by git-noreply＠pixie.qos.ch 12 Jun '12

12 Jun '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 2cf1b399928f7460277e5d057f8297e2e0551945 (commit) from 6f3d29fdae82c872b61ed5356aab66571d000876 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=2cf1b399928f7460277e5d057f… http://github.com/ceki/slf4j/commit/2cf1b399928f7460277e5d057f8297e2e0551945 commit 2cf1b399928f7460277e5d057f8297e2e0551945 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jun 12 14:43:25 2012 +0200 fix bug #261 diff --git a/slf4j-jdk14/src/main/java/org/slf4j/impl/JDK14LoggerAdapter.java b/slf4j-jdk14/src/main/java/org/slf4j/impl/JDK14LoggerAdapter.java index 5e5f0d7..3c20c14 100644 --- a/slf4j-jdk14/src/main/java/org/slf4j/impl/JDK14LoggerAdapter.java +++ b/slf4j-jdk14/src/main/java/org/slf4j/impl/JDK14LoggerAdapter.java @@ -48,7 +48,7 @@ public final class JDK14LoggerAdapter extends MarkerIgnoringBase implements private static final long serialVersionUID = -8053026990503422791L; - final java.util.logging.Logger logger; + transient final java.util.logging.Logger logger; // WARN: JDK14LoggerAdapter constructor should have only package access so // that only JDK14LoggerFactory be able to create one. ----------------------------------------------------------------------- Summary of changes: .../java/org/slf4j/impl/JDK14LoggerAdapter.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[GIT] SLF4J: Simple Logging Facade for Java branch master updated. v_1.6.6-3-g6f3d29f
by git-noreply＠pixie.qos.ch 12 Jun '12

12 Jun '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SLF4J: Simple Logging Facade for Java". The branch, master has been updated via 6f3d29fdae82c872b61ed5356aab66571d000876 (commit) from c8365d5d33400723c5af4942c30fb85a2c5406f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=6f3d29fdae82c872b61ed5356a… http://github.com/ceki/slf4j/commit/6f3d29fdae82c872b61ed5356aab66571d000876 commit 6f3d29fdae82c872b61ed5356aab66571d000876 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Jun 12 14:42:50 2012 +0200 starting work on 1.6.7 diff --git a/integration/pom.xml b/integration/pom.xml index c5af965..14568d8 100644 --- a/integration/pom.xml +++ b/integration/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/jcl-over-slf4j/pom.xml b/jcl-over-slf4j/pom.xml index 77c77a2..52ee4e4 100644 --- a/jcl-over-slf4j/pom.xml +++ b/jcl-over-slf4j/pom.xml @@ -4,7 +4,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/jul-to-slf4j/pom.xml b/jul-to-slf4j/pom.xml index bf17a52..e3b2a6c 100644 --- a/jul-to-slf4j/pom.xml +++ b/jul-to-slf4j/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/log4j-over-slf4j/pom.xml b/log4j-over-slf4j/pom.xml index 4891a7b..7190825 100644 --- a/log4j-over-slf4j/pom.xml +++ b/log4j-over-slf4j/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/osgi-over-slf4j/pom.xml b/osgi-over-slf4j/pom.xml index b6a8715..dbd7316 100644 --- a/osgi-over-slf4j/pom.xml +++ b/osgi-over-slf4j/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/pom.xml b/pom.xml index 5333219..bb7470e 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> <packaging>pom</packaging> <name>SLF4J</name> diff --git a/slf4j-api/pom.xml b/slf4j-api/pom.xml index 383c69a..c39dfdc 100644 --- a/slf4j-api/pom.xml +++ b/slf4j-api/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-ext/pom.xml b/slf4j-ext/pom.xml index 991c29a..7bf0811 100644 --- a/slf4j-ext/pom.xml +++ b/slf4j-ext/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-jcl/pom.xml b/slf4j-jcl/pom.xml index 98c21ab..c30521c 100644 --- a/slf4j-jcl/pom.xml +++ b/slf4j-jcl/pom.xml @@ -3,7 +3,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-jdk14/pom.xml b/slf4j-jdk14/pom.xml index 9fa8df7..f17a31d 100644 --- a/slf4j-jdk14/pom.xml +++ b/slf4j-jdk14/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-log4j12/pom.xml b/slf4j-log4j12/pom.xml index c0bbf56..0d717f0 100644 --- a/slf4j-log4j12/pom.xml +++ b/slf4j-log4j12/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-migrator/pom.xml b/slf4j-migrator/pom.xml index 57807d7..622fb44 100644 --- a/slf4j-migrator/pom.xml +++ b/slf4j-migrator/pom.xml @@ -7,7 +7,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-nop/pom.xml b/slf4j-nop/pom.xml index 3b348f9..e28371d 100644 --- a/slf4j-nop/pom.xml +++ b/slf4j-nop/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-osgi-integration-test/pom.xml b/slf4j-osgi-integration-test/pom.xml index 1302ed8..f6c201f 100644 --- a/slf4j-osgi-integration-test/pom.xml +++ b/slf4j-osgi-integration-test/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-osgi-test-bundle/pom.xml b/slf4j-osgi-test-bundle/pom.xml index 808a517..5e522a0 100644 --- a/slf4j-osgi-test-bundle/pom.xml +++ b/slf4j-osgi-test-bundle/pom.xml @@ -6,7 +6,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-simple/pom.xml b/slf4j-simple/pom.xml index 757ebbd..059336a 100644 --- a/slf4j-simple/pom.xml +++ b/slf4j-simple/pom.xml @@ -4,7 +4,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/slf4j-site/pom.xml b/slf4j-site/pom.xml index 47646e5..ed14fc9 100644 --- a/slf4j-site/pom.xml +++ b/slf4j-site/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>org.slf4j</groupId> <artifactId>slf4j-parent</artifactId> - <version>1.6.6</version> + <version>1.6.7-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> ----------------------------------------------------------------------- Summary of changes: integration/pom.xml | 2 +- jcl-over-slf4j/pom.xml | 2 +- jul-to-slf4j/pom.xml | 2 +- log4j-over-slf4j/pom.xml | 2 +- osgi-over-slf4j/pom.xml | 2 +- pom.xml | 2 +- slf4j-api/pom.xml | 2 +- slf4j-ext/pom.xml | 2 +- slf4j-jcl/pom.xml | 2 +- slf4j-jdk14/pom.xml | 2 +- slf4j-log4j12/pom.xml | 2 +- slf4j-migrator/pom.xml | 2 +- slf4j-nop/pom.xml | 2 +- slf4j-osgi-integration-test/pom.xml | 2 +- slf4j-osgi-test-bundle/pom.xml | 2 +- slf4j-simple/pom.xml | 2 +- slf4j-site/pom.xml | 2 +- 17 files changed, 17 insertions(+), 17 deletions(-) hooks/post-receive -- SLF4J: Simple Logging Facade for Java

1 0

[qos-ch/slf4j] 2cf1b3: fix bug #261
by Ceki Gulcu 12 Jun '12

12 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 2cf1b399928f7460277e5d057f8297e2e0551945 https://github.com/qos-ch/slf4j/commit/2cf1b399928f7460277e5d057f8297e2e055… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-12 (Tue, 12 Jun 2012) Changed paths: M slf4j-jdk14/src/main/java/org/slf4j/impl/JDK14LoggerAdapter.java Log Message: ----------- fix bug #261

1 0

[qos-ch/slf4j] 6f3d29: starting work on 1.6.7
by Ceki Gulcu 12 Jun '12

12 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 6f3d29fdae82c872b61ed5356aab66571d000876 https://github.com/qos-ch/slf4j/commit/6f3d29fdae82c872b61ed5356aab66571d00… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-12 (Tue, 12 Jun 2012) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-osgi-integration-test/pom.xml M slf4j-osgi-test-bundle/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- starting work on 1.6.7

1 0