December 2014 - slf4j-dev - mailman3.qos.ch

Re: [slf4j-dev] [slf4j] indentation changes only (7a57f1a)
by Ceki Gülcü 13 Dec '14

13 Dec '14

Hi Alexander, For the time being, we are using the Eclipse formatting style file defined in $SLF4J_HOME/codeStyle.xml. For IntelliJ users, there is a IntelliJ plugin called "Eclipse Code Formatter" [1] capable of reading $SLF4J_HOME/codeStyle.xml. Supposedly IntelliJ 1.3 and later read Eclipse style files natively but I was unable to get it working. For the time being and in order to get on with the next release, I'd like to stick to the current 2 space indentation style. We can revisit the issue after 1.7.8 is released. Thus, I think that my recent initiative to change the formatting style was premature/ill advised. -- Ceki [1] https://plugins.jetbrains.com/plugin/?idea&id=6546 On 12/13/2014 0:06, adorokhine wrote: > Can you clarify what the code style is for slf4j? The LoggerFactory, for > instance, seems to use two spaces for indentation. > > —

1 0

[qos-ch/slf4j] ca1dbb: Fix tests which are no longer running.
by Ceki Gulcu 13 Dec '14

13 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: ca1dbbf65ef5293429c1329b523e7008a47b1964 https://github.com/qos-ch/slf4j/commit/ca1dbbf65ef5293429c1329b523e7008a47b… Author: Alexander Dorokhine <adorokhine(a)google.com> Date: 2014-12-12 (Fri, 12 Dec 2014) Changed paths: M slf4j-api/src/test/java/org/slf4j/helpers/MessageFormatterTest.java Log Message: ----------- Fix tests which are no longer running. Commit: c8cd020c3669a808d3842ef7b4d24de77300470f https://github.com/qos-ch/slf4j/commit/c8cd020c3669a808d3842ef7b4d24de77300… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M slf4j-api/src/test/java/org/slf4j/helpers/MessageFormatterTest.java Log Message: ----------- Merge pull request #94 from adorokhine/test Fix tests which are no longer running. Compare: https://github.com/qos-ch/slf4j/compare/7a57f1a08031...c8cd020c3669

1 0

new indentation style
by Ceki Gülcü 12 Dec '14

12 Dec '14

Hi All, I've added a new and experimental indentation style under .idea/codeStyleSettings.xml. Essentially it uses 4 spaces instead of 2 previously for indentation. It seems to me that 4 spaces are more common in the java world than 2. I've applied the new indentation to slf4j-api/src/main/java/org/slf4j/helpers/Util.java If there is support for this change, I'll apply the new style to the whole project. Your comments are welcome. -- Ceki

3 3

[qos-ch/slf4j] 7a57f1: indentation changes only
by Ceki Gulcu 09 Dec '14

09 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 7a57f1a0803116dfdd11a5e4fa2adaa1759e4d99 https://github.com/qos-ch/slf4j/commit/7a57f1a0803116dfdd11a5e4fa2adaa1759e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-09 (Tue, 09 Dec 2014) Changed paths: A .idea/codeStyleSettings.xml M slf4j-api/src/main/java/org/slf4j/helpers/Util.java Log Message: ----------- indentation changes only

1 0

[qos-ch/slf4j] 26b011: added Alexandre's name as author
by Ceki Gulcu 09 Dec '14

09 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 26b01116722ebdd3b2471a6579f9d5a6feda83e7 https://github.com/qos-ch/slf4j/commit/26b01116722ebdd3b2471a6579f9d5a6feda… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-09 (Tue, 09 Dec 2014) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java M slf4j-api/src/main/java/org/slf4j/helpers/Util.java M slf4j-simple/src/test/java/org/slf4j/AutoNamedLoggerFieldTrialTest.java Log Message: ----------- added Alexandre's name as author

1 0

[qos-ch/slf4j] 3a5063: minor typo fix
by Ceki Gulcu 09 Dec '14

09 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 3a506351d77b22c37f39f32ee97796ef81c9f195 https://github.com/qos-ch/slf4j/commit/3a506351d77b22c37f39f32ee97796ef81c9… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-09 (Tue, 09 Dec 2014) Changed paths: M slf4j-site/src/site/pages/migrator.html Log Message: ----------- minor typo fix

1 0

[qos-ch/slf4j] c52317: next version is 1.7.8-SNAPSHOT
by Ceki Gulcu 08 Dec '14

08 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: c52317aaef624ee253e6ecaf8861e1c43275808e https://github.com/qos-ch/slf4j/commit/c52317aaef624ee253e6ecaf8861e1c43275… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-08 (Mon, 08 Dec 2014) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-android/pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- next version is 1.7.8-SNAPSHOT

1 0

[qos-ch/slf4j] c0f583: allow for computed caller class to be a super-type...
by Ceki Gulcu 08 Dec '14

08 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: c0f5835dcd6fdf7f9e2224211ccf8fe6b98cd7c7 https://github.com/qos-ch/slf4j/commit/c0f5835dcd6fdf7f9e2224211ccf8fe6b98c… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-08 (Mon, 08 Dec 2014) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java M slf4j-api/src/main/java/org/slf4j/helpers/Util.java M slf4j-simple/src/test/java/org/slf4j/AutoNamedLoggerFieldTrialTest.java A slf4j-simple/src/test/java/org/slf4j/ShapeTest.java A slf4j-simple/src/test/java/org/slf4j/shape/ShapeBase.java A slf4j-simple/src/test/java/org/slf4j/shape/Square.java Log Message: ----------- allow for computed caller class to be a super-type of class passed as parameter to LoggerFactory.getLogger(Class)

1 0

[qos-ch/slf4j] 97f96c: A field trial for the automatically named logger.
by Ceki Gulcu 08 Dec '14

08 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 97f96c5ad52259c2e620370309cf129b7ba30f54 https://github.com/qos-ch/slf4j/commit/97f96c5ad52259c2e620370309cf129b7ba3… Author: Alexander Dorokhine <adorokhine(a)google.com> Date: 2014-12-07 (Sun, 07 Dec 2014) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java M slf4j-api/src/main/java/org/slf4j/helpers/Util.java A slf4j-simple/src/test/java/org/slf4j/AutoNamedLoggerFieldTrialTest.java Log Message: ----------- A field trial for the automatically named logger. Can be enabled with -Dorg.slf4j.LoggerFactory.autoNamedLoggerFieldTrial=true. Prints an error (and stacktrace) to stderr when a mismatch between custom and automatic logger names is detected. Commit: 90735dfb849eac2587043270af00f35b48ad3e4d https://github.com/qos-ch/slf4j/commit/90735dfb849eac2587043270af00f35b48ad… Author: Alexander Dorokhine <adorokhine(a)google.com> Date: 2014-12-07 (Sun, 07 Dec 2014) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java Log Message: ----------- Remove stack trace from the field trial mismatch message. Commit: ff3462db2e92f494aa20241cbf3531b748709484 https://github.com/qos-ch/slf4j/commit/ff3462db2e92f494aa20241cbf3531b74870… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-08 (Mon, 08 Dec 2014) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java M slf4j-api/src/main/java/org/slf4j/helpers/Util.java A slf4j-simple/src/test/java/org/slf4j/AutoNamedLoggerFieldTrialTest.java Log Message: ----------- Merge pull request #92 from adorokhine/getlogger_field_study A field trial for the automatically named logger. Compare: https://github.com/qos-ch/slf4j/compare/e2ac06c0b27c...ff3462db2e92

1 0

[Bug 133] Add ability to log at a dynamic level
by bugzilla-daemon＠qos.ch 04 Dec '14

04 Dec '14

http://bugzilla.slf4j.org/show_bug.cgi?id=133 Andrew Swan <andrew.i.swan(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.i.swan(a)gmail.com --- Comment #15 from Andrew Swan <andrew.i.swan(a)gmail.com> --- Robert Elliott put it perfectly in comment 4 (and very politely, considering the unjustified allegations of hackery against him). For every person like me who comes here to "vote" for this feature, there are 100* more who find it missing and simply work around it quietly, which is sad. Problems should be fixed once for the benefit of all. What's the reluctance on the part of the maintainers? It can't be the implementation, given that a patch has been supplied? *Numbers may vary slightly from reality. -- You are receiving this mail because: You are the assignee for the bug.

1 0