January 2019 - slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-192) Need ability to shutdown loggers and flush appenders
by QOS.CH (JIRA) 03 Jan '19

03 Jan '19

[ https://jira.qos.ch/browse/SLF4J-192?page=com.atlassian.jira.plugin.system.… ] James Howe commented on SLF4J-192: ---------------------------------- bq. why anyone would oppose such part of an API Because SLF4J is an API for *libraries* to use, not applications. No library should be managing application shutdown, just as no library should be managing application configuration. > Need ability to shutdown loggers and flush appenders > ---------------------------------------------------- > > Key: SLF4J-192 > URL: https://jira.qos.ch/browse/SLF4J-192 > Project: SLF4J > Issue Type: Improvement > Components: Core API > Affects Versions: 1.6.x > Environment: Operating System: All > Platform: All > Reporter: Michael Schall > Assignee: SLF4J developers list > > There needs to be a way to shutdown logging and flush async appenders so when a process is closing, all log events are written before the process is closed. > Should ILoggerFactory have a shutdown or stop method? It could shutdown whatever logging back end I'm using? > For log4j it would call - org.apache.log4j.LogManager.getLoggerRepository().shutdown(); > For logback it would call - loggerContext.stop() > Other back ends - ??? > This is required to allow me to not reference logging back ends explicitly in my code to shutdown successfully without losing events. > Discussion about this is happening on the user list at - > http://www.qos.ch/pipermail/logback-user/2010-September/001816.html -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-192) Need ability to shutdown loggers and flush appenders
by QOS.CH (JIRA) 03 Jan '19

03 Jan '19

[ https://jira.qos.ch/browse/SLF4J-192?page=com.atlassian.jira.plugin.system.… ] Ondrej Zizka commented on SLF4J-192: ------------------------------------ One thing I don't understand: Quite a lot of people know how they would use such notification in the logger implementation. Some people don't. Well - those who do would use it, those who don't would not use it. What's the big deal? It's not cluttering the API since releasing the resources, and distributing the notification about when to do it, is inherent part of Java APIs since Java decision to get rid of destructors. I really wonder why anyone would oppose such part of an API. > Need ability to shutdown loggers and flush appenders > ---------------------------------------------------- > > Key: SLF4J-192 > URL: https://jira.qos.ch/browse/SLF4J-192 > Project: SLF4J > Issue Type: Improvement > Components: Core API > Affects Versions: 1.6.x > Environment: Operating System: All > Platform: All > Reporter: Michael Schall > Assignee: SLF4J developers list > > There needs to be a way to shutdown logging and flush async appenders so when a process is closing, all log events are written before the process is closed. > Should ILoggerFactory have a shutdown or stop method? It could shutdown whatever logging back end I'm using? > For log4j it would call - org.apache.log4j.LogManager.getLoggerRepository().shutdown(); > For logback it would call - loggerContext.stop() > Other back ends - ??? > This is required to allow me to not reference logging back ends explicitly in my code to shutdown successfully without losing events. > Discussion about this is happening on the user list at - > http://www.qos.ch/pipermail/logback-user/2010-September/001816.html -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-192) Need ability to shutdown loggers and flush appenders
by QOS.CH (JIRA) 03 Jan '19

03 Jan '19

[ https://jira.qos.ch/browse/SLF4J-192?page=com.atlassian.jira.plugin.system.… ] Ondrej Zizka commented on SLF4J-192: ------------------------------------ The point of having a method in an interface is that the implementation have different way to handle some event, and you want to abstractly notify these implementations about the event. Some implementations do nothing, so they have a no-op implementation. Other implementations may need to release some resources. I hope I helped you to understand the purpose of interfaces. > Need ability to shutdown loggers and flush appenders > ---------------------------------------------------- > > Key: SLF4J-192 > URL: https://jira.qos.ch/browse/SLF4J-192 > Project: SLF4J > Issue Type: Improvement > Components: Core API > Affects Versions: 1.6.x > Environment: Operating System: All > Platform: All > Reporter: Michael Schall > Assignee: SLF4J developers list > > There needs to be a way to shutdown logging and flush async appenders so when a process is closing, all log events are written before the process is closed. > Should ILoggerFactory have a shutdown or stop method? It could shutdown whatever logging back end I'm using? > For log4j it would call - org.apache.log4j.LogManager.getLoggerRepository().shutdown(); > For logback it would call - loggerContext.stop() > Other back ends - ??? > This is required to allow me to not reference logging back ends explicitly in my code to shutdown successfully without losing events. > Discussion about this is happening on the user list at - > http://www.qos.ch/pipermail/logback-user/2010-September/001816.html -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-192) Need ability to shutdown loggers and flush appenders
by QOS.CH (JIRA) 02 Jan '19

02 Jan '19

[ https://jira.qos.ch/browse/SLF4J-192?page=com.atlassian.jira.plugin.system.… ] Joachim Durchholz commented on SLF4J-192: ----------------------------------------- What's the point of having a shutdown method in the facade? Facades are about concentrating the dependency to the backend in one place - or at least no more places than you can count on one hand. Since shutdown would replace a single call with a single call, it's not saving you anything here. It _is_ giving you a small O(1) benefit in that it defines a standard shutdown point; OTOH I find that logging tends to require some application-specific setup and teardown anyway; there's simply no point in adding such a function. I think what would be worth thinking about is a single point that handles application setup _and_ shutdown code. Since there are typically dependencies between the two, that would be helpful. However, that's application-specific. I tend to have a LoggingManagement class that does the setup, and registers a shutdown hook. Plus it deals with those libraries that have non-SLF4J logging, whether because legacy or because the library designer does not want to use SLF4J (I live with both cases). So, from my perspective, SLF4J isn't even the right place to organize setup and teardown, things are too application-specific. > Need ability to shutdown loggers and flush appenders > ---------------------------------------------------- > > Key: SLF4J-192 > URL: https://jira.qos.ch/browse/SLF4J-192 > Project: SLF4J > Issue Type: Improvement > Components: Core API > Affects Versions: 1.6.x > Environment: Operating System: All > Platform: All > Reporter: Michael Schall > Assignee: SLF4J developers list > > There needs to be a way to shutdown logging and flush async appenders so when a process is closing, all log events are written before the process is closed. > Should ILoggerFactory have a shutdown or stop method? It could shutdown whatever logging back end I'm using? > For log4j it would call - org.apache.log4j.LogManager.getLoggerRepository().shutdown(); > For logback it would call - loggerContext.stop() > Other back ends - ??? > This is required to allow me to not reference logging back ends explicitly in my code to shutdown successfully without losing events. > Discussion about this is happening on the user list at - > http://www.qos.ch/pipermail/logback-user/2010-September/001816.html -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-192) Need ability to shutdown loggers and flush appenders
by QOS.CH (JIRA) 02 Jan '19

02 Jan '19

[ https://jira.qos.ch/browse/SLF4J-192?page=com.atlassian.jira.plugin.system.… ] Andrea Santi commented on SLF4J-192: ------------------------------------ I understand that SL4J general idea is about having a simple facede library. It is true that I have a file configuring the real logging framework used behind SLF4J (log4j2 in my case) and the related backend dependency (this is inevitable). However, this is the only touching point to the underlying logging framework: all the rest is managed by SLF4J. This is not bad and totally in accordance with the idea of the facade: with the effort of a little setup the extra-complexity of the underlying logging framework is hidden. It's like having a wall separating the two worlds. I really would love things to remain like that! Having a "shutdown" method in the SLF4J interface is not going to change the nature of the facade: most of the logging framework have this feature and it is trivial to implement a sort of "nop" method for logging frameworks not having this functionality. "*If I am building a code dependency on the underlying logger, why even use SLF4J?"* --> I intended this sentence that I quoted *not* as _"I have an additional dependency in my project"_ but something like _"If I have to write in my class some framework-specific code then I can just get rid of SLF4J and use directly the specific logging framework"_. The idea of using SLF4J should be that I don't rely on framework-specific code right? These are just my two cents... > Need ability to shutdown loggers and flush appenders > ---------------------------------------------------- > > Key: SLF4J-192 > URL: https://jira.qos.ch/browse/SLF4J-192 > Project: SLF4J > Issue Type: Improvement > Components: Core API > Affects Versions: 1.6.x > Environment: Operating System: All > Platform: All > Reporter: Michael Schall > Assignee: SLF4J developers list > > There needs to be a way to shutdown logging and flush async appenders so when a process is closing, all log events are written before the process is closed. > Should ILoggerFactory have a shutdown or stop method? It could shutdown whatever logging back end I'm using? > For log4j it would call - org.apache.log4j.LogManager.getLoggerRepository().shutdown(); > For logback it would call - loggerContext.stop() > Other back ends - ??? > This is required to allow me to not reference logging back ends explicitly in my code to shutdown successfully without losing events. > Discussion about this is happening on the user list at - > http://www.qos.ch/pipermail/logback-user/2010-September/001816.html -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0