July 2021 - slf4j-dev - mailman3.qos.ch

[JIRA] Updates for SLF4J-387: Implement putAll and putAllClosable
by QOS.CH (JIRA) 09 Jul '21

09 Jul '21

SLF4J / SLF4J-387 [In Progress] Implement putAll and putAllClosable ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-387 ============================== 1 comment ------------------------------ Daniel Raniz Raneland on 09/Jul/21 4:54 PM No, that would not work since the goal is to do {{try (Closeable temp = MDC.putAllCloseable(myEntries)) {}} {{ // Do stuff}} {{ }}} And that requires a single {{Closeable}} since try-with-resources doesn't work with a collection. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-515: write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple
by QOS.CH (JIRA) 09 Jul '21

09 Jul '21

SLF4J / SLF4J-515 [In Progress] write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-515 ============================== 1 comment ------------------------------ Ceki Gülcü on 09/Jul/21 10:05 AM [~tibor17] Given your feedback I have made further changes. Let me know if you have further comments. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[qos-ch/slf4j] f91024: version should have a SNAPSHOT suffix at this stage
by Ceki Gulcu 09 Jul '21

09 Jul '21

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: f91024f676b3b1dd4adf5a01a6dabd23c39f6a6b https://github.com/qos-ch/slf4j/commit/f91024f676b3b1dd4adf5a01a6dabd23c39f… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2021-07-09 (Fri, 09 Jul 2021) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- version should have a SNAPSHOT suffix at this stage Signed-off-by: Ceki Gulcu <ceki(a)qos.ch>

1 0

[qos-ch/slf4j] 28e079: align with changes in the 1.7 branch
by Ceki Gulcu 09 Jul '21

09 Jul '21

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 28e07908a2249ca88582306b6528967835120418 https://github.com/qos-ch/slf4j/commit/28e07908a2249ca88582306b652896783512… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2021-07-09 (Fri, 09 Jul 2021) Changed paths: M slf4j-simple/src/main/java/org/slf4j/simple/SimpleLogger.java M slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/MultithereadedExecutionTest.java M slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/StateCheckingPrintStream.java Log Message: ----------- align with changes in the 1.7 branch Signed-off-by: Ceki Gulcu <ceki(a)qos.ch>

1 0

[qos-ch/slf4j] e4fd94: improvements to SLF4J-515
by Ceki Gulcu 09 Jul '21

09 Jul '21

Branch: refs/heads/1.7-maintenance Home: https://github.com/qos-ch/slf4j Commit: e4fd9494628bdf0e0a300d0fc3f89ae3ba5c503f https://github.com/qos-ch/slf4j/commit/e4fd9494628bdf0e0a300d0fc3f89ae3ba5c… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2021-07-09 (Fri, 09 Jul 2021) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java M slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/MultithereadedExecutionTest.java M slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/StateCheckingPrintStream.java Log Message: ----------- improvements to SLF4J-515 Signed-off-by: Ceki Gulcu <ceki(a)qos.ch>

1 0

[JIRA] Updates for SLF4J-515: write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple
by QOS.CH (JIRA) 09 Jul '21

09 Jul '21

SLF4J / SLF4J-515 [In Progress] write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-515 ============================== 1 comment ------------------------------ Tibor Digaňa on 09/Jul/21 1:56 AM The internal lock in PrintStream is not documented in the Javadoc. And if someone follows the pattern I mentioned above and if someone picks up the PrintStream lock and reorders two locks then he broke many IT principles and made it intentionally and moved one lock from slf4j to PrintStream and vice versa which is so big and drastic change that he must be aware that he is doing something very nonstandard. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-515: write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple
by QOS.CH (JIRA) 08 Jul '21

08 Jul '21

SLF4J / SLF4J-515 [In Progress] write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple ============================== Here's what changed in this issue in the last few minutes. There are 2 comments. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-515 ============================== 2 comments ------------------------------ Tibor Digaňa on 09/Jul/21 12:25 AM Deadlock never happens with one lock, that's impossible. The deadlock with two contra locks Mutexx happens only with the following pattern and you do not have it in your code: {code:java} M1: synchronized(lockX) { synchronized(lockY) { } }{code} {code:java} M2: synchronized(lockY) { synchronized(lockX) { } }{code} ------------------------------ Ceki Gülcü on 09/Jul/21 12:31 AM [~tibor17] As you mention, deadlocks are quite unlikely unless someone invokes a logging method from within a PrintStream. Unlikely but someone might be using their own implementation of PrintStream... ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[qos-ch/slf4j] b6fb6e: changes after feedback from Tibor Digana
by Ceki Gulcu 08 Jul '21

08 Jul '21

Branch: refs/heads/1.7-maintenance Home: https://github.com/qos-ch/slf4j Commit: b6fb6e3b1d7ebab666c65661080ee691650a3f9e https://github.com/qos-ch/slf4j/commit/b6fb6e3b1d7ebab666c65661080ee691650a… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2021-07-09 (Fri, 09 Jul 2021) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java M slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/MultithereadedExecutionTest.java M slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/StateCheckingPrintStream.java Log Message: ----------- changes after feedback from Tibor Digana Signed-off-by: Ceki Gulcu <ceki(a)qos.ch>

1 0

[JIRA] Updates for SLF4J-515: write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple
by QOS.CH (JIRA) 08 Jul '21

08 Jul '21

SLF4J / SLF4J-515 [In Progress] write(StringBuilder buf, Throwable t) should be synchronized in slf4j-simple ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-515 ============================== 1 comment ------------------------------ Ceki Gülcü on 08/Jul/21 11:43 PM [~tibor17] I have added a {{ReentrantLock.tryLock(200, TimeUnit.MILLISECONDS)} call in the {{SimpleLogger.write(StringBuffer, Throwable)}} method. The idea is to allow for ordered outputs but avoid deadlocks. Please let me know if this works for you. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[qos-ch/slf4j] 816da3: fixing SLF4J-515
by Ceki Gulcu 08 Jul '21

08 Jul '21

Branch: refs/heads/1.7-maintenance Home: https://github.com/qos-ch/slf4j Commit: 816da3d85710fc3810c292bd82a8e70a9ed159b2 https://github.com/qos-ch/slf4j/commit/816da3d85710fc3810c292bd82a8e70a9ed1… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2021-07-08 (Thu, 08 Jul 2021) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java A slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/MultithereadedExecutionTest.java A slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/StateCheckingPrintStream.java Log Message: ----------- fixing SLF4J-515 Signed-off-by: Ceki Gulcu <ceki(a)qos.ch>

1 0