- slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-407) Jigsaw modules contain clashing package
by QOS.CH (JIRA) 22 Mar '18

22 Mar '18

[ https://jira.qos.ch/browse/SLF4J-407?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-407: ---------------------------------- In case there are multiple providers available on the module-path, slf4j-api, more precisely org.slf4j.LoggerFactory emits a warning message and picks up the first provider. Here is an example. {code} > java -p target/classes\;lib/slf4j-api-1.8.0-beta2.jar\;lib/slf4j-simple-1.8.0-beta2.jar\;lib/slf4j-jdk14-1.8.0-beta2.jar -m org.foo/pkg.Main SLF4J: Class path contains multiple SLF4J providers. SLF4J: Found provider [org.slf4j.simple.SimpleServiceProvider@59f99ea] SLF4J: Found provider [org.slf4j.jul.JULServiceProvider@27efef64] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual provider is of type [org.slf4j.simple.SimpleServiceProvider@59f99ea] [main] INFO Main - hello {code} > Jigsaw modules contain clashing package > --------------------------------------- > > Key: SLF4J-407 > URL: https://jira.qos.ch/browse/SLF4J-407 > Project: SLF4J > Issue Type: Bug > Components: Implementations > Affects Versions: 1.8.0-alpha2 > Reporter: Stephen Colebourne > Assignee: Ceki Gülcü > Fix For: 1.8.0-beta3 > > > Looking at the slf4j-jdk14 and slf4j-nop artifacts, they both appear to contain the package `org.slf4j.impl`. Jigsaw will refuse to load two modules that contain the same package, so this will be a problem. > I know that SLF4J does not intend users to load both of these modules at the same time. But the current setup means that it will be the JPMS runtime that rejects it, meaning that there is no chance for SLF4J to output a helpful message (as I believe it does today). > The solution to this would appear to be to move the `org.slf4j.impl` package to `org.slf4j.jul.impl` and `org.slf4j.nop.impl`. As the impl package is not exported, this should not affect any user code (except code that would have been affected anyway). > I imagine this affects other slf4j artifacts. > I also note that [this module-info.java|https://github.com/qos-ch/slf4j/blob/1_8_0-SNAPSHOT/slf4j-…] exports the `org.slf4j.jul` package, which seems unnecessary (simple and nop do not export their package). > See [here|http://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html] for more information on naming. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

MDC works with twitter scala Future but not CompletableFuture
by Dean Hiller 22 Mar '18

22 Mar '18

Has anyone requested the jdk to add Local.java to CompletableFuture.java so that context can be transferred through the .thenApply and .thenCompose methods. ie. can we make MDC work in java-land with CompletableFutures? (it works in scala land with twitter scala Future by swapping the MDC out for the below thing I describe) let me go into more detail here. We use twitter Future.scala which knows about Local.scala and Local.scala "acts" like a ThreadLocal. I say acts because when you do future.map/flatMap(in java that is thenApply/thenCompose), it transfers the threadlocal through to the next executing function. soooo, long story short, in twitter servers, I can say MDC.put("requestId", someRequestId) and it works over the .map/.flatMap. This is not possible in java!!!!! ahhhhh.... and I wrote a whole webserver in java with CompletableFutures before I found this out https://github.com/deanhiller/webpieces ps. their response was that it would be a global. Sure, but I am practical and it solves a huge many platform problems like MDC, and some in my server where I don't know the customers code(and I had to hack around not having a Local type thing available :( ). Another reason they elude to is some methods they don't know how to handle Local in those cases(yup, well scala had the same thing but it managed to implement it because it was too important and now java is behind :( ). Anyways, it would be nice if others spoke up before they realize they need it for the MDC to keep working. thanks, Dean

2 3

[qos-ch/slf4j] 1c713e: cater for JDK 10 and later
by Ceki Gulcu 22 Mar '18

22 Mar '18

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 1c713e7c1042ca1fcba550df79a4ad7fce055211 https://github.com/qos-ch/slf4j/commit/1c713e7c1042ca1fcba550df79a4ad7fce05… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-03-22 (Thu, 22 Mar 2018) Changed paths: M pom.xml Log Message: ----------- cater for JDK 10 and later

1 0

[qos-ch/slf4j] 74b099: cater for JDK 10
by Ceki Gulcu 22 Mar '18

22 Mar '18

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 74b0999f9513d340f50832d0bf59ccb2d2cdbfee https://github.com/qos-ch/slf4j/commit/74b0999f9513d340f50832d0bf59ccb2d2cd… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-03-22 (Thu, 22 Mar 2018) Changed paths: M pom.xml M slf4j-site/src/site/pages/news.html Log Message: ----------- cater for JDK 10

1 0

[qos-ch/slf4j] c85e3e: Reslove compile error: 'javac: invalid flag: -s', ...
by Ceki Gulcu 22 Mar '18

22 Mar '18

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: c85e3e2e9c5e21a41193db5cde77146bb30ebdbd https://github.com/qos-ch/slf4j/commit/c85e3e2e9c5e21a41193db5cde77146bb30e… Author: zhoujinze <zhoujinze(a)gmail.com> Date: 2018-03-22 (Thu, 22 Mar 2018) Changed paths: M pom.xml Log Message: ----------- Reslove compile error: 'javac: invalid flag: -s', when exist 1.5 toolchain Commit: 39824d8c8bb4c2c7ceedf286b4f1b90e0229ac7a https://github.com/qos-ch/slf4j/commit/39824d8c8bb4c2c7ceedf286b4f1b90e0229… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-03-22 (Thu, 22 Mar 2018) Changed paths: M pom.xml Log Message: ----------- Merge pull request #195 from Oseenix/compile_error_when_1.5_exsist Reslove compile error: 'javac: invalid flag: -s', when exist 1.5 tool… Compare: https://github.com/qos-ch/slf4j/compare/c960e8630cdf...39824d8c8bb4

1 0

[qos-ch/slf4j] c960e8: start work on 1.8.0-beta3
by Ceki Gulcu 21 Mar '18

21 Mar '18

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: c960e8630cdf0ec4a6c5ea687ebe536e9e43ab68 https://github.com/qos-ch/slf4j/commit/c960e8630cdf0ec4a6c5ea687ebe536e9e43… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-03-21 (Wed, 21 Mar 2018) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- start work on 1.8.0-beta3

1 0

[qos-ch/slf4j]
by ceki 21 Mar '18

21 Mar '18

Branch: refs/tags/v_1.8.0_beta2 Home: https://github.com/qos-ch/slf4j

1 0

[qos-ch/slf4j] 26731d: it's beta not bata
by Ceki Gulcu 21 Mar '18

21 Mar '18

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 26731d281940483d8777a8a7a4146329a28496aa https://github.com/qos-ch/slf4j/commit/26731d281940483d8777a8a7a4146329a284… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-03-21 (Wed, 21 Mar 2018) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- it's beta not bata

1 0

[JIRA] (SLF4J-411) EventRecodingLogger.debug(String) logs at TRACE
by QOS.CH (JIRA) 21 Mar '18

21 Mar '18

[ https://jira.qos.ch/browse/SLF4J-411?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-411. ------------------------------ Resolution: Fixed Fixed in [commit d7d1710|https://github.com/qos-ch/slf4j/commit/d7d1710d99afa65] > EventRecodingLogger.debug(String) logs at TRACE > ----------------------------------------------- > > Key: SLF4J-411 > URL: https://jira.qos.ch/browse/SLF4J-411 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.8.0-alpha2 > Reporter: Doug Roper > Assignee: Ceki Gülcü > Priority: Minor > Fix For: 1.8.0-beta2 > > > [https://github.com/qos-ch/slf4j/blob/v_1.8.0-alpha2/slf4j-api/src/main/java…] > {code:java} > public void debug(String msg) { > recordEvent(Level.TRACE, msg, null, null); > } > {code} > Expected result: debug method logs at debug. > Actual result: debug method logs at trace. > Seems like a copy-paste bug. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] 64d5b7: news on SLF4J-411
by Ceki Gulcu 21 Mar '18

21 Mar '18

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 64d5b7d83e2769fb56bd70120a8ff112777480d9 https://github.com/qos-ch/slf4j/commit/64d5b7d83e2769fb56bd70120a8ff1127774… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-03-21 (Wed, 21 Mar 2018) Changed paths: M slf4j-site/src/site/pages/news.html Log Message: ----------- news on SLF4J-411

1 0