- slf4j-dev - mailman3.qos.ch

[qos-ch/slf4j] 7f7eec: use correct version for site plugin (this fixes th...
by Ceki Gulcu 13 Dec '14

13 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 7f7eeca501216b7dbb7f8fe14ecfe7aeef868fd5 https://github.com/qos-ch/slf4j/commit/7f7eeca501216b7dbb7f8fe14ecfe7aeef86… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M slf4j-site/pom.xml Log Message: ----------- use correct version for site plugin (this fixes the build for site:site

1 0

[qos-ch/slf4j] d9f79d: revert indentation changes in LoggerFactory, modif...
by Ceki Gulcu 13 Dec '14

13 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: d9f79d3bda3fcc35b0951ba9411a22bc0b1d1c45 https://github.com/qos-ch/slf4j/commit/d9f79d3bda3fcc35b0951ba9411a22bc0b1d… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M codeStyle.xml M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java Log Message: ----------- revert indentation changes in LoggerFactory, modify codeStyle.xml to match existing code style as much as possible

1 0

[qos-ch/slf4j] b8b7aa: use 2 space indentation in IntelliJ formatter
by Ceki Gulcu 13 Dec '14

13 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: b8b7aaf44d7bb7ecb897ff4327ce8f353d4aeefe https://github.com/qos-ch/slf4j/commit/b8b7aaf44d7bb7ecb897ff4327ce8f353d4a… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M .idea/codeStyleSettings.xml Log Message: ----------- use 2 space indentation in IntelliJ formatter

1 0

[qos-ch/slf4j] 67c07b: move modelVersion tag to the top, reformat pom.xml...
by Ceki Gulcu 13 Dec '14

13 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 67c07b7129af8d1291b2539d3fee88d6cb1226a3 https://github.com/qos-ch/slf4j/commit/67c07b7129af8d1291b2539d3fee88d6cb12… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- move modelVersion tag to the top, reformat pom.xml files Commit: 08d05cb80597f2241b6b292301119d8bd33253dc https://github.com/qos-ch/slf4j/commit/08d05cb80597f2241b6b292301119d8bd332… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M slf4j-api/src/test/java/org/slf4j/helpers/MessageFormatterTest.java Log Message: ----------- Merge branch 'master' of github.com:qos-ch/slf4j Compare: https://github.com/qos-ch/slf4j/compare/c8cd020c3669...08d05cb80597

1 0

Re: [slf4j-dev] [slf4j] indentation changes only (7a57f1a)
by Ceki Gülcü 13 Dec '14

13 Dec '14

Hi Alexander, For the time being, we are using the Eclipse formatting style file defined in $SLF4J_HOME/codeStyle.xml. For IntelliJ users, there is a IntelliJ plugin called "Eclipse Code Formatter" [1] capable of reading $SLF4J_HOME/codeStyle.xml. Supposedly IntelliJ 1.3 and later read Eclipse style files natively but I was unable to get it working. For the time being and in order to get on with the next release, I'd like to stick to the current 2 space indentation style. We can revisit the issue after 1.7.8 is released. Thus, I think that my recent initiative to change the formatting style was premature/ill advised. -- Ceki [1] https://plugins.jetbrains.com/plugin/?idea&id=6546 On 12/13/2014 0:06, adorokhine wrote: > Can you clarify what the code style is for slf4j? The LoggerFactory, for > instance, seems to use two spaces for indentation. > > —

1 0

[qos-ch/slf4j] ca1dbb: Fix tests which are no longer running.
by Ceki Gulcu 13 Dec '14

13 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: ca1dbbf65ef5293429c1329b523e7008a47b1964 https://github.com/qos-ch/slf4j/commit/ca1dbbf65ef5293429c1329b523e7008a47b… Author: Alexander Dorokhine <adorokhine(a)google.com> Date: 2014-12-12 (Fri, 12 Dec 2014) Changed paths: M slf4j-api/src/test/java/org/slf4j/helpers/MessageFormatterTest.java Log Message: ----------- Fix tests which are no longer running. Commit: c8cd020c3669a808d3842ef7b4d24de77300470f https://github.com/qos-ch/slf4j/commit/c8cd020c3669a808d3842ef7b4d24de77300… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-13 (Sat, 13 Dec 2014) Changed paths: M slf4j-api/src/test/java/org/slf4j/helpers/MessageFormatterTest.java Log Message: ----------- Merge pull request #94 from adorokhine/test Fix tests which are no longer running. Compare: https://github.com/qos-ch/slf4j/compare/7a57f1a08031...c8cd020c3669

1 0

new indentation style
by Ceki Gülcü 12 Dec '14

12 Dec '14

Hi All, I've added a new and experimental indentation style under .idea/codeStyleSettings.xml. Essentially it uses 4 spaces instead of 2 previously for indentation. It seems to me that 4 spaces are more common in the java world than 2. I've applied the new indentation to slf4j-api/src/main/java/org/slf4j/helpers/Util.java If there is support for this change, I'll apply the new style to the whole project. Your comments are welcome. -- Ceki

3 3

[qos-ch/slf4j] 7a57f1: indentation changes only
by Ceki Gulcu 09 Dec '14

09 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 7a57f1a0803116dfdd11a5e4fa2adaa1759e4d99 https://github.com/qos-ch/slf4j/commit/7a57f1a0803116dfdd11a5e4fa2adaa1759e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-09 (Tue, 09 Dec 2014) Changed paths: A .idea/codeStyleSettings.xml M slf4j-api/src/main/java/org/slf4j/helpers/Util.java Log Message: ----------- indentation changes only

1 0

[qos-ch/slf4j] 26b011: added Alexandre's name as author
by Ceki Gulcu 09 Dec '14

09 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 26b01116722ebdd3b2471a6579f9d5a6feda83e7 https://github.com/qos-ch/slf4j/commit/26b01116722ebdd3b2471a6579f9d5a6feda… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-09 (Tue, 09 Dec 2014) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java M slf4j-api/src/main/java/org/slf4j/helpers/Util.java M slf4j-simple/src/test/java/org/slf4j/AutoNamedLoggerFieldTrialTest.java Log Message: ----------- added Alexandre's name as author

1 0

[qos-ch/slf4j] 3a5063: minor typo fix
by Ceki Gulcu 09 Dec '14

09 Dec '14

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 3a506351d77b22c37f39f32ee97796ef81c9f195 https://github.com/qos-ch/slf4j/commit/3a506351d77b22c37f39f32ee97796ef81c9… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2014-12-09 (Tue, 09 Dec 2014) Changed paths: M slf4j-site/src/site/pages/migrator.html Log Message: ----------- minor typo fix

1 0