- slf4j-dev - mailman3.qos.ch

[JIRA] Updates for SLF4J-124: Add ability to log at a dynamic level
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-124 [In Progress] Add ability to log at a dynamic level ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-124 ============================== 1 comment ------------------------------ Adrian Shum on 16/Dec/21 12:35 AM with the convention of atDebug() atInfo() etc, it will look more fluent for calling makeLogingEventBuilder "at()", so code will look like: {code:java} logger.at(level).log(message); {code} ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-526: Idea for fluent API improvement
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-526 [Open] Idea for fluent API improvement ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-526 ============================== 1 comment ------------------------------ Adrian Shum on 16/Dec/21 12:24 AM In current fluent API, the only place we could provide the message is at log(), which needs to happen at the last in the call chain. That's precisely why I am suggesting a new "message()" method for the builder to provide message before args, and an empty log() to mark the end of call chain ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-527: restore safe JNDI lookup
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-527 [Open] restore safe JNDI lookup ============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-527 ============================== Issue created ------------------------------ Ceki Gülcü created this issue on 15/Dec/21 11:47 PM Summary: restore safe JNDI lookup Issue Type: Bug Assignee: SLF4J developers list Created: 15/Dec/21 11:47 PM Priority: Major Reporter: Ceki Gülcü Description: We can restore local java JNDI lookup, as this both safe and intended usage. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-526: Idea for fluent API improvement
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-526 [Open] Idea for fluent API improvement ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-526 ============================== 1 comment ------------------------------ Ceki Gülcü on 15/Dec/21 10:11 PM The documentation indeed suggests to write the arguments first. This is not mandated in code. As for arg() instead of addArgument(), we see if others chime in. ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-526: Idea for fluent API improvement
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-526 [Open] Idea for fluent API improvement ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-526 ============================== 1 comment ------------------------------ Adrian Shum on 15/Dec/21 9:55 PM My main concern is, when we write / read code for logging, intuition is to write the message first, and then provide the arguments. The existing fluent api is suggesting the other way round: as you could only provide the message in log(), arguments provided by addArgument() will come before the message, and arguments provided with log() will come after the message, making the code being a headache to read. another concern is addArgument() is too verbose, calling it arg() is going to equally maintainable but more enjoyable to write/read ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-499: Add property to log thread id
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-499 [Open] Add property to log thread id ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-499 ============================== 1 comment ------------------------------ Michael Osipov on 15/Dec/21 9:27 PM Yes, opt in only. Make it short "[tid=nnn]". ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-499: Add property to log thread id
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-499 [Open] Add property to log thread id ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-499 ============================== 1 comment ------------------------------ Ceki Gülcü on 15/Dec/21 9:00 PM Sounds good. Optional and disabled by default, yes? ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[JIRA] Updates for SLF4J-526: Idea for fluent API improvement
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-526 [Open] Idea for fluent API improvement ============================== Here's what changed in this issue in the last few minutes. There is 1 comment. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-526 ============================== 1 comment ------------------------------ Ceki Gülcü on 15/Dec/21 9:06 AM Only the *at*XXX() method needs to come first and *log()* has to come last. Otherwise order does not matter. Have you observed otherwise? ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0

[qos-ch/slf4j] ce15e7: less drama
by Ceki Gülcü 15 Dec '21

15 Dec '21

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: ce15e71dd890061915f36277df2716e626f9ea70 https://github.com/qos-ch/slf4j/commit/ce15e71dd890061915f36277df2716e626f9… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2021-12-15 (Wed, 15 Dec 2021) Changed paths: M pom.xml M slf4j-api/pom.xml M slf4j-api/src/main/java9/module-info.java M slf4j-site/src/site/pages/bug-reporting.html M slf4j-site/src/site/pages/css/site.css M slf4j-site/src/site/pages/log4shell.html M slf4j-site/src/site/pages/news.html M slf4j-site/src/site/pages/templates/left.js Log Message: ----------- less drama

1 0

[JIRA] Updates for SLF4J-526: Idea for fluent API improvement
by QOS.CH (JIRA) 15 Dec '21

15 Dec '21

SLF4J / SLF4J-526 [Open] Idea for fluent API improvement ============================== Here's what changed in this issue in the last few minutes. This issue has been created This issue is now assigned to you. View or comment on issue using this link https://jira.qos.ch/browse/SLF4J-526 ============================== Issue created ------------------------------ Adrian Shum created this issue on 15/Dec/21 1:09 AM Summary: Idea for fluent API improvement Issue Type: Improvement Assignee: SLF4J developers list Created: 15/Dec/21 1:09 AM Priority: Major Reporter: Adrian Shum Description: I found current Fluent API design a bit hard to read for two reasons: * method names are too verbose * Slightly counter-intuitive to have arguments before the log message Especially the second issue, people (at least for me) found it hard to read as I need to twist my mind to find corresponding arguments before and after the message. imho it looks a bit better to provide alternatives like this (totally fine to keep the original form) {code:java} logger.atDebug() .message("Temperature of {} rise from {} to {}", country) .arg(oldTemp).arg(newTemp).log(); // equivalent to logger.atDebug() .addArgument(country).addArgument(oldTemp).addArgument(newTemp) .log("Temperature of {} rise from {} to {}"); // Compare to the old-style logger.debug("Temperature of {} rise from {} to {}", country, oldTemp, newTemp); {code} ============================== This message was sent by Atlassian Jira (v8.8.0#808000-sha1:e2c7e59)

1 0