- logback-dev - mailman3.qos.ch

svn commit: r1896 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern
by noreply.ceki＠qos.ch 28 Oct '08

28 Oct '08

Author: ceki Date: Tue Oct 28 17:54:42 2008 New Revision: 1896 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java Log: Add comment in relation to LBCLASSIC-36 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/DateConverter.java Tue Oct 28 17:54:42 2008 @@ -62,6 +62,9 @@ return timesmapStr; } else { lastTimestamp = timestamp; + // SimpleDateFormat is not thread safe. However, since + // the AppenderBase.doAppend is synchronized, we are should be + // OK. See also http://jira.qos.ch/browse/LBCLASSIC-36 timesmapStr = simpleFormat.format(new Date(timestamp)); return timesmapStr; }

1 0

[JIRA] Reopened: (LBCLASSIC-36) Synchronization of SimpleDateFormat object in DateConverter
by Ceki Gulcu (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-36?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu reopened LBCLASSIC-36: --------------------------------- Assignee: Ceki Gulcu (was: Logback dev list) Ralph, Are you sure SimpleDateFormat is still horribly slow? I believe that it has been significantly improved in more recent JDKs. As for moving to Joda time, I'll wait for JSR-310 to finalize. > Synchronization of SimpleDateFormat object in DateConverter > ----------------------------------------------------------- > > Key: LBCLASSIC-36 > URL: http://jira.qos.ch/browse/LBCLASSIC-36 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Anders Hammar > Assignee: Ceki Gulcu > Attachments: DateConverter_patch.java > > > According to the API documentation of SimpleDateFormat, date formats are not synchronized and it is recommended to create separate format instances for each thread. > However, a possibly simpler (mer efficient) solution would be to synchronize on the SimpleDateFormat object in the convert() method to prevent two threads to access it concurrently. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Closed: (LBCORE-39) StopWatchTest fails in Germany.
by Ceki Gulcu (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCORE-39?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu closed LBCORE-39. ---------------------------- OK. Thank you. > StopWatchTest fails in Germany. > ------------------------------- > > Key: LBCORE-39 > URL: http://jira.qos.ch/browse/LBCORE-39 > Project: logback-core > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Logback dev list > Attachments: StopWatchTestPatch.patch > > > StopWatchTest must also use a DecimalFormat to check the 6.000 seconds. DecimalFormat is using DecimalFormatSymbols(Locale.getDefault()) by default so the string contained is "6,000 seconds." in Germany. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCLASSIC-75) Synchronization of SimpleDateFormat object in DateConverter
by Ralph Goers (JIRA) 28 Oct '08

28 Oct '08

Synchronization of SimpleDateFormat object in DateConverter ----------------------------------------------------------- Key: LBCLASSIC-75 URL: http://jira.qos.ch/browse/LBCLASSIC-75 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: unspecified Environment: Operating System: All Platform: All Reporter: Ralph Goers Assignee: Logback dev list According to the API documentation of SimpleDateFormat, date formats are not synchronized and it is recommended to create separate format instances for each thread. However, a possibly simpler (mer efficient) solution would be to synchronize on the SimpleDateFormat object in the convert() method to prevent two threads to access it concurrently. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Commented: (LBCORE-39) StopWatchTest fails in Germany.
by Joern Huxhorn (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCORE-39?page=com.atlassian.jira.plugin.system.i… ] Joern Huxhorn commented on LBCORE-39: ------------------------------------- I could build the latest slf4j-trunk so the problem seems to be gone. > StopWatchTest fails in Germany. > ------------------------------- > > Key: LBCORE-39 > URL: http://jira.qos.ch/browse/LBCORE-39 > Project: logback-core > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Joern Huxhorn > Assignee: Logback dev list > Attachments: StopWatchTestPatch.patch > > > StopWatchTest must also use a DecimalFormat to check the 6.000 seconds. DecimalFormat is using DecimalFormatSymbols(Locale.getDefault()) by default so the string contained is "6,000 seconds." in Germany. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Closed: (LBCORE-1) Appender interface managing Layouts?
by Ceki Gulcu (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCORE-1?page=com.atlassian.jira.plugin.system.is… ] Ceki Gulcu closed LBCORE-1. --------------------------- > Appender interface managing Layouts? > ------------------------------------ > > Key: LBCORE-1 > URL: http://jira.qos.ch/browse/LBCORE-1 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Sébastien Pennec > Assignee: Logback dev list > Fix For: unspecified > > > Why does the c.p.l.core.Appender interface includes a getter and a setter for Layout? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCORE-1) Appender interface managing Layouts?
by Ceki Gulcu (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCORE-1?page=com.atlassian.jira.plugin.system.is… ] Ceki Gulcu resolved LBCORE-1. ----------------------------- Fix Version/s: unspecified Resolution: Duplicate Duplicates LBCORE-56 > Appender interface managing Layouts? > ------------------------------------ > > Key: LBCORE-1 > URL: http://jira.qos.ch/browse/LBCORE-1 > Project: logback-core > Issue Type: Bug > Components: Appender > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Sébastien Pennec > Assignee: Logback dev list > Fix For: unspecified > > > Why does the c.p.l.core.Appender interface includes a getter and a setter for Layout? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-33) unregistering in the jmx plugin
by Joern Huxhorn (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCLASSIC-33?page=com.atlassian.jira.plugin.syste… ] Joern Huxhorn commented on LBCLASSIC-33: ---------------------------------------- I just checked this with a simple hello-world-webapp using tomcat 6.0.18. With <jmxConfigurator/> contained in logback.xml the classloader of the webapp will never be garbage-collected on re- or undeploy. All classes of the webapp remain in the heap dump. If I remove <jmxConfigurator/> the webapp is unloaded properly. This is quite bad... See also: http://blogs.sun.com/fkieviet/entry/classloader_leaks_the_dreaded_java http://blogs.sun.com/fkieviet/entry/how_to_fix_the_dreaded http://blogs.sun.com/sundararajan/entry/querying_java_heap_with_oql http://blogs.sun.com/sundararajan/entry/jhat_s_javascript_interface > unregistering in the jmx plugin > ------------------------------- > > Key: LBCLASSIC-33 > URL: http://jira.qos.ch/browse/LBCLASSIC-33 > Project: logback-classic > Issue Type: Bug > Components: Other > Affects Versions: unspecified > Environment: Operating System: All > Platform: All > Reporter: Hontvári József > Assignee: Logback dev list > > I started using the JMX plugin of login, and I wondered how should I > shut it down when a web application is restarted. I haven't found a > function which unregisters the Configurator MBean. This object holds a > reference (through ContextAwareBase) to a Context. I am afraid that not > unregistering it causes a memory leak when a web application is restarted. > There should be a way to shutdown the JMX plugin. Or more generally an API to shut down the Logback system in its entirety: flush buffers, close files etc. It must be decided what to do if a log request arrives when or after logback is shutting down. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCORE-37) Clean up a typo in SizeBasedRollingTest.java
by Ceki Gulcu (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCORE-37?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu resolved LBCORE-37. ------------------------------ Fix Version/s: unspecified Resolution: Fixed Hello Matt, This problem has been fixed in an earlier version of logback. > Clean up a typo in SizeBasedRollingTest.java > -------------------------------------------- > > Key: LBCORE-37 > URL: http://jira.qos.ch/browse/LBCORE-37 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: All > Reporter: Matt Fowles > Assignee: Logback dev list > Fix For: unspecified > > Attachments: rolling2.diff, unit-test-typo.diff > > > This patch just fixes a typo in a unit test. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Closed: (LBCORE-37) Clean up a typo in SizeBasedRollingTest.java
by Ceki Gulcu (JIRA) 28 Oct '08

28 Oct '08

[ http://jira.qos.ch/browse/LBCORE-37?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu closed LBCORE-37. ---------------------------- > Clean up a typo in SizeBasedRollingTest.java > -------------------------------------------- > > Key: LBCORE-37 > URL: http://jira.qos.ch/browse/LBCORE-37 > Project: logback-core > Issue Type: Bug > Components: Rolling > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: All > Reporter: Matt Fowles > Assignee: Logback dev list > Fix For: unspecified > > Attachments: rolling2.diff, unit-test-typo.diff > > > This patch just fixes a typo in a unit test. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0