February 2017 - slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- SLF4J-395 created > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-395) add a configuration for System.out/err cache
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

Hervé Boutemy created SLF4J-395: ----------------------------------- Summary: add a configuration for System.out/err cache Key: SLF4J-395 URL: https://jira.qos.ch/browse/SLF4J-395 Project: SLF4J Issue Type: Improvement Components: slf4j-simple Affects Versions: 1.7.24 Environment: in SLF4J-389, having slf4j simple provider caching System.out and System.err was though as a bug, annoying some people in their integration where they prefer not caching and benefitting from code changing System.out/err value to change slf4j simple output In Maven, this cache is more seen as a feature, that prevents changing Maven output location in a plugin that would play with System.out/err for integrating some code: Maven is an open world, I didn't find such a plugin, but it may exist and the new not-caching slf4j simple would more been seen as a bug for us. In fact, caching is not per se a bug: it's a feature that can be useful to disable (or the oposite, to enable when you want it) Please add a configuration to enable/disable caching: I don't know if caching should be enable by default or not, it depends on what you consider the default behaviour of slf4j simple provider for years Reporter: Hervé Boutemy Assignee: SLF4J developers list -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-389: ---------------------------------- [~hboutemy] can you please create a jira issue requesting a configuration parameter for System.out/err cache? > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- back to SLF4J-389, which I didn't have time to report until now: for normal uses, such "non caching" of System.out and System.err won't cause grief to normal Maven use But if a plugin does play with System.out or System.err (for example when invoking some code that relies on System.out and System.err), the new bahaviour will cause issues: until now, the plugin didn't impact Maven output, but if caching in slf4j-simple has been disabled, the change will be visible Is it possible to add a configuration to enable System.out/err cache? I don't think one behaviour or the other is really the right one: it's a choice that has to be done locally when integrating > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- [~ceki] SLF4J-394 created > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-394) add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

Hervé Boutemy created SLF4J-394: ----------------------------------- Summary: add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider Key: SLF4J-394 URL: https://jira.qos.ch/browse/SLF4J-394 Project: SLF4J Issue Type: Improvement Components: slf4j-simple Affects Versions: 1.7.24 Environment: Apache Maven created a Groovy monkey patch to extract such renderThrowable() and renderLevel() and being able to override these methods in a local provider, which is essentially slf4j-simple with a little rendering improvement see [https://git-wip-us.apache.org/repos/asf/maven/?p=maven.git;a=blob;f=maven-s…] Having these changes directly in slf4j simple provider should not change much things, and would avoid us the Groovy patch dependency: the provider will still be required, since we can't have 2 providers in the classpath, and adding real extension/configuration to slf4j simple is much more complex Reporter: Hervé Boutemy Assignee: SLF4J developers list -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] e5ce0d: start work on 1.7.25-SNAPSHOT
by Ceki Gulcu 24 Feb '17

24 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: e5ce0d5e41a47133b2a5d7fd4cb5e8ab9bf44073 https://github.com/qos-ch/slf4j/commit/e5ce0d5e41a47133b2a5d7fd4cb5e8ab9bf4… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-android/pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- start work on 1.7.25-SNAPSHOT

1 0

[qos-ch/slf4j]
by ceki 24 Feb '17

24 Feb '17

Branch: refs/tags/v_1.7.24 Home: https://github.com/qos-ch/slf4j

1 0

[JIRA] (SLF4J-388) Set slf4j.detectLoggerNameMismatch to true
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-388?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-388. ------------------------------ Resolution: Won't Fix Enabling logger name mismatch detection would have a performance impact on unsuspecting users. > Set slf4j.detectLoggerNameMismatch to true > ------------------------------------------ > > Key: SLF4J-388 > URL: https://jira.qos.ch/browse/SLF4J-388 > Project: SLF4J > Issue Type: New Feature > Reporter: Ceki Gülcü > Assignee: SLF4J developers list > Fix For: 1.7.24 > > > We wish to enable slf4j.detectLoggerNameMismatch feature to pave the route for parameterless LoggerFactory.getLogger method. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-390) FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-390?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-390. ------------------------------ Resolution: Not a bug > FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception > ------------------------------------------------------------------------------------- > > Key: SLF4J-390 > URL: https://jira.qos.ch/browse/SLF4J-390 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.22 > Reporter: Andreas Sewe > Assignee: Ceki Gülcü > Priority: Minor > Fix For: 1.7.24 > > > I have a hard time triaging an {{IllegalStateException}} thrown by {{LoggerFactory.getILoggerFactory}} that has been reported by a user ([Eclipse Bug 510487|https://bugs.eclipse.org/bugs/show_bug.cgi?id=510487] as the root exception is not wrapped by the {{IllegalStateException}}: [https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] > AFAICT, that exception is only logged to the console ([https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] This makes error reports sent by an automatic error reporting system (like the one employed for the Eclipse IDE) less useful, as the crucial information won't be included automatically. > Hence, it would be great if SLF4J could hold onto the {{Throwable}} for a bit and than wrap it in the final {{IllegalStateException}}. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0