February 2017 - slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-390) FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-390?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü reopened SLF4J-390: ------------------------------ > FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception > ------------------------------------------------------------------------------------- > > Key: SLF4J-390 > URL: https://jira.qos.ch/browse/SLF4J-390 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.22 > Reporter: Andreas Sewe > Assignee: Ceki Gülcü > Priority: Minor > Fix For: 1.7.24 > > > I have a hard time triaging an {{IllegalStateException}} thrown by {{LoggerFactory.getILoggerFactory}} that has been reported by a user ([Eclipse Bug 510487|https://bugs.eclipse.org/bugs/show_bug.cgi?id=510487] as the root exception is not wrapped by the {{IllegalStateException}}: [https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] > AFAICT, that exception is only logged to the console ([https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] This makes error reports sent by an automatic error reporting system (like the one employed for the Eclipse IDE) less useful, as the crucial information won't be included automatically. > Hence, it would be great if SLF4J could hold onto the {{Throwable}} for a bit and than wrap it in the final {{IllegalStateException}}. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-390) FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-390?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-390: ---------------------------------- After thinking about this problem quite a bit, I feel that changing more code in org.slf4j.LoggerFactory to accommodate this particular case would do more harm than good. > FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception > ------------------------------------------------------------------------------------- > > Key: SLF4J-390 > URL: https://jira.qos.ch/browse/SLF4J-390 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.22 > Reporter: Andreas Sewe > Assignee: Ceki Gülcü > Priority: Minor > Fix For: 1.7.24 > > > I have a hard time triaging an {{IllegalStateException}} thrown by {{LoggerFactory.getILoggerFactory}} that has been reported by a user ([Eclipse Bug 510487|https://bugs.eclipse.org/bugs/show_bug.cgi?id=510487] as the root exception is not wrapped by the {{IllegalStateException}}: [https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] > AFAICT, that exception is only logged to the console ([https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] This makes error reports sent by an automatic error reporting system (like the one employed for the Eclipse IDE) less useful, as the crucial information won't be included automatically. > Hence, it would be great if SLF4J could hold onto the {{Throwable}} for a bit and than wrap it in the final {{IllegalStateException}}. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] e49d59: mark final fields as final
by Ceki Gulcu 24 Feb '17

24 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: e49d591fc6f3e4f1517edb7ac56f2ca62b4660ce https://github.com/qos-ch/slf4j/commit/e49d591fc6f3e4f1517edb7ac56f2ca62b46… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M slf4j-api/src/main/java/org/slf4j/LoggerFactory.java Log Message: ----------- mark final fields as final

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-389: ---------------------------------- Hi [~hboutemy], Thank you for your explanations. My offer was to allow two extension points via {{renderThrowable()}} and {{renderLevel()}} methods saving the trouble of monkey patching and slightly improving the {{SimpleLogger}} code in the process. If you are interested in this limited refactoring, please create a separate JIRA issue. I'd be happy to follow through. Configuration is a different matter with a much larger scope. :) > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] 1e715a: prepare release 1.7.24
by Ceki Gulcu 24 Feb '17

24 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 1e715a79b5ded4b6f33f757bde4ef2a257019afe https://github.com/qos-ch/slf4j/commit/1e715a79b5ded4b6f33f757bde4ef2a25701… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-android/pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- prepare release 1.7.24

1 0

[JIRA] (SLF4J-390) FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-390?page=com.atlassian.jira.plugin.system.… ] Andreas Sewe commented on SLF4J-390: ------------------------------------ That’s a helpful hint; the original exception was reported to the [Automated Error Reporting tool|https://www.ctrlflow.com/automated-error-reporting/] server employed at Eclipse in the form of [this incident|[https://dev.eclipse.org/recommenders/community/aeri/v2/#!/submiss…] Alas, there is *no* separate incident for the original exception – either because the user didn’t consent to sending it or (more likely) because this first error didn’t hit the Eclipse Error Log but was swallowed somewhere along the way. Hence, having all the context available in a single Throwable is IMHO still preferable. > FAILED_INITIALIZATION case in LoggerFactory.getILoggerFactory swallows root exception > ------------------------------------------------------------------------------------- > > Key: SLF4J-390 > URL: https://jira.qos.ch/browse/SLF4J-390 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.22 > Reporter: Andreas Sewe > Assignee: Ceki Gülcü > Priority: Minor > Fix For: 1.7.24 > > > I have a hard time triaging an {{IllegalStateException}} thrown by {{LoggerFactory.getILoggerFactory}} that has been reported by a user ([Eclipse Bug 510487|https://bugs.eclipse.org/bugs/show_bug.cgi?id=510487] as the root exception is not wrapped by the {{IllegalStateException}}: [https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] > AFAICT, that exception is only logged to the console ([https://github.com/qos-ch/slf4j/blob/v_1.7.22/slf4j-api/src/main/java/org/s…] This makes error reports sent by an automatic error reporting system (like the one employed for the Eclipse IDE) less useful, as the crucial information won't be included automatically. > Hence, it would be great if SLF4J could hold onto the {{Throwable}} for a bit and than wrap it in the final {{IllegalStateException}}. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 24 Feb '17

24 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- Hi Ceki, Thanks for your attention: in fact, after doing this, I thought I could contribute a patch that would be useful for others. But here is what prevented me to do so. Yes, having the 2 methods in Slf4jSimpleLogger could be of help, to drop the patch part: if you can do it, it can help a little bit, since I'll be able to remove the Groovy script But I think this won't avoid us to create a separate slf4j maven-slf4j-provider artifact that shades original slf4j-simple-provider, since we can't have 2 slf4j provider artifacts in one classpath without having a conclict. IIUC, to just have a little Maven extension on top of original slf4j-simple-provider, there is a configuration/extension layer that has to be in place: it's more than the simple addition of these 2 methods. IIUC, this configuration/extension layer is one of the features that is available into gossip provider: if slf4j-simple can add such a feature, yes, it would avoid Maven to create this specific shaded artifact, but slf4j-simple would be less simple, which AFAIK is not really your strategy > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] cfa8f7: avoid syncronization
by Ceki Gulcu 23 Feb '17

23 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: cfa8f7519b9e47e4f0b5c9e16754166bb09919fd https://github.com/qos-ch/slf4j/commit/cfa8f7519b9e47e4f0b5c9e16754166bb099… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-24 (Fri, 24 Feb 2017) Changed paths: M slf4j-api/src/main/java/org/slf4j/helpers/BasicMarker.java Log Message: ----------- avoid syncronization

1 0

[JIRA] (SLF4J-385) add source links to javadocs
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-385?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-385. ------------------------------ Resolution: Fixed fixed in https://github.com/qos-ch/slf4j/commit/9e441fe9f99b1 > add source links to javadocs > ---------------------------- > > Key: SLF4J-385 > URL: https://jira.qos.ch/browse/SLF4J-385 > Project: SLF4J > Issue Type: Bug > Components: Unspecified > Affects Versions: 1.7.22 > Reporter: Ceki Gülcü > Assignee: Ceki Gülcü > Fix For: 1.7.24 > > > Add source links to javadocs. remove xref tags -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] 9e441f: fix SLF4J-385
by Ceki Gulcu 23 Feb '17

23 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 9e441fe9f99b13943cd6b98a3608a39806e69b6c https://github.com/qos-ch/slf4j/commit/9e441fe9f99b13943cd6b98a3608a39806e6… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M pom.xml Log Message: ----------- fix SLF4J-385

1 0