- slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-395) add a configuration for System.out/err cache
by QOS.CH (JIRA) 27 Feb '17

27 Feb '17

[ https://jira.qos.ch/browse/SLF4J-395?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-395. ------------------------------ Resolution: Fixed [~hboutemy] Fixed in commit [4a8c16635c|https://github.com/qos-ch/slf4j/commit/4a8c16635c] Many of the configuration parameters moved to {{SimpleLoggerConfiguration}} class. However, this change should be transparent to users. If not, ping me. Please verify and close. > add a configuration for System.out/err cache > -------------------------------------------- > > Key: SLF4J-395 > URL: https://jira.qos.ch/browse/SLF4J-395 > Project: SLF4J > Issue Type: Improvement > Components: slf4j-simple > Affects Versions: 1.7.24 > Environment: Apache Maven > Reporter: Hervé Boutemy > Assignee: Ceki Gülcü > Fix For: 1.7.25 > > > in -SLF4J-389-, having slf4j simple provider caching System.out and System.err was though as a bug, annoying some people in their integration where they prefer not caching and benefitting from code changing System.out/err value to change slf4j simple output > In Maven, this cache is more seen as a feature, that prevents changing Maven output location in a plugin that would play with System.out/err for integrating some code: Maven is an open world, I didn't find such a plugin, but it may exist and the new not-caching slf4j simple would more been seen as a bug for us. > > In fact, caching is not per se a bug: it's a feature that can be useful to disable (or the oposite, to enable when you want it) > Please add a configuration to enable/disable caching: I don't know if caching should be enabled by default or not, it depends on what you consider the default behaviour of slf4j simple provider for years -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] 4a8c16: fix SLF4J-395
by Ceki Gulcu 27 Feb '17

27 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 4a8c16635cf59a88521fdcbba74735244dec9f6b https://github.com/qos-ch/slf4j/commit/4a8c16635cf59a88521fdcbba74735244dec… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/OutputChoice.java M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java A slf4j-simple/src/main/java/org/slf4j/impl/SimpleLoggerConfiguration.java M slf4j-simple/src/test/java/org/slf4j/impl/SimpleLoggerTest.java Log Message: ----------- fix SLF4J-395 Commit: 97472ca10ae82c3244f5c8e6d6fea5847cb90731 https://github.com/qos-ch/slf4j/commit/97472ca10ae82c3244f5c8e6d6fea5847cb9… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-27 (Mon, 27 Feb 2017) Changed paths: M integration/src/test/java/org/slf4j/test_osgi/FelixHost.java Log Message: ----------- fix deprecation issues Compare: https://github.com/qos-ch/slf4j/compare/509c3444ac72...97472ca10ae8

1 0

[JIRA] (SLF4J-394) add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-394?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-394. ------------------------------ Resolution: Fixed > add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider > --------------------------------------------------------------------------------------------------------- > > Key: SLF4J-394 > URL: https://jira.qos.ch/browse/SLF4J-394 > Project: SLF4J > Issue Type: Improvement > Components: slf4j-simple > Affects Versions: 1.7.24 > Environment: Apache Maven 3.5 with maven-slf4j-provider http://maven.apache.org/ref/3-LATEST/maven-slf4j-provider/ > Reporter: Hervé Boutemy > Assignee: Ceki Gülcü > Fix For: 1.7.25 > > > Apache Maven created a Groovy monkey patch to extract such renderThrowable() and renderLevel() and being able to override these methods in a local provider, which is essentially slf4j-simple with a little rendering improvement > see [https://git-wip-us.apache.org/repos/asf/maven/?p=maven.git;a=blob;f=maven-s…] > Having these changes directly in slf4j simple provider should not change much things, and would avoid us the Groovy patch dependency: the provider will still be required, since we can't have 2 providers in the classpath, and adding real extension/configuration to slf4j simple is much more complex -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-394) add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-394?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-394: ---------------------------------- Fixed in [commit 509c3444ac7| https://github.com/qos-ch/slf4j/commit/509c3444ac7] Note the method name {{writeThrowable}}. [~hboutemy] Please let me know if it works for you. > add renderThrowable() and renderLevel() protected methods + mark LOG_LEVEL_* protected in simple provider > --------------------------------------------------------------------------------------------------------- > > Key: SLF4J-394 > URL: https://jira.qos.ch/browse/SLF4J-394 > Project: SLF4J > Issue Type: Improvement > Components: slf4j-simple > Affects Versions: 1.7.24 > Environment: Apache Maven 3.5 with maven-slf4j-provider http://maven.apache.org/ref/3-LATEST/maven-slf4j-provider/ > Reporter: Hervé Boutemy > Assignee: Ceki Gülcü > Fix For: 1.7.25 > > > Apache Maven created a Groovy monkey patch to extract such renderThrowable() and renderLevel() and being able to override these methods in a local provider, which is essentially slf4j-simple with a little rendering improvement > see [https://git-wip-us.apache.org/repos/asf/maven/?p=maven.git;a=blob;f=maven-s…] > Having these changes directly in slf4j simple provider should not change much things, and would avoid us the Groovy patch dependency: the provider will still be required, since we can't have 2 providers in the classpath, and adding real extension/configuration to slf4j simple is much more complex -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] 898e22: type fix
by Ceki Gulcu 26 Feb '17

26 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 898e22225909c4c84ef4885b6d346ca0a8565e38 https://github.com/qos-ch/slf4j/commit/898e22225909c4c84ef4885b6d346ca0a856… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M slf4j-site/src/site/pages/news.html Log Message: ----------- type fix Commit: 509c3444ac72913309999367782055fb40cbe184 https://github.com/qos-ch/slf4j/commit/509c3444ac72913309999367782055fb40cb… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java Log Message: ----------- fix SLF4J-394 Compare: https://github.com/qos-ch/slf4j/compare/e5ce0d5e41a4...509c3444ac72

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- SLF4J-395 created > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-395) add a configuration for System.out/err cache
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

Hervé Boutemy created SLF4J-395: ----------------------------------- Summary: add a configuration for System.out/err cache Key: SLF4J-395 URL: https://jira.qos.ch/browse/SLF4J-395 Project: SLF4J Issue Type: Improvement Components: slf4j-simple Affects Versions: 1.7.24 Environment: in SLF4J-389, having slf4j simple provider caching System.out and System.err was though as a bug, annoying some people in their integration where they prefer not caching and benefitting from code changing System.out/err value to change slf4j simple output In Maven, this cache is more seen as a feature, that prevents changing Maven output location in a plugin that would play with System.out/err for integrating some code: Maven is an open world, I didn't find such a plugin, but it may exist and the new not-caching slf4j simple would more been seen as a bug for us. In fact, caching is not per se a bug: it's a feature that can be useful to disable (or the oposite, to enable when you want it) Please add a configuration to enable/disable caching: I don't know if caching should be enable by default or not, it depends on what you consider the default behaviour of slf4j simple provider for years Reporter: Hervé Boutemy Assignee: SLF4J developers list -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-389: ---------------------------------- [~hboutemy] can you please create a jira issue requesting a configuration parameter for System.out/err cache? > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- back to SLF4J-389, which I didn't have time to report until now: for normal uses, such "non caching" of System.out and System.err won't cause grief to normal Maven use But if a plugin does play with System.out or System.err (for example when invoking some code that relies on System.out and System.err), the new bahaviour will cause issues: until now, the plugin didn't impact Maven output, but if caching in slf4j-simple has been disabled, the change will be visible Is it possible to add a configuration to enable System.out/err cache? I don't think one behaviour or the other is really the right one: it's a choice that has to be done locally when integrating > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 26 Feb '17

26 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Hervé Boutemy commented on SLF4J-389: ------------------------------------- [~ceki] SLF4J-394 created > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0