- slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-240) BasicMarker.hasReferences() causes a performance bottleneck
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-240?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-240. ------------------------------ Resolution: Fixed Fixed in commit [c6e1c3d495|https://github.com/qos-ch/slf4j/commit/c6e1c3d495d19c636aa9] > BasicMarker.hasReferences() causes a performance bottleneck > ----------------------------------------------------------- > > Key: SLF4J-240 > URL: https://jira.qos.ch/browse/SLF4J-240 > Project: SLF4J > Issue Type: Bug > Components: Core API > Affects Versions: 1.6.x > Environment: Operating System: Linux > Platform: Other > Reporter: Ralph Goers > Assignee: Ceki Gülcü > Fix For: 1.7.24 > > Attachments: BasicMarker.jpg > > > We have a MarkerFilter declared as a TurboFilter. During performance testing it was discovered that this is a significant bottleneck due to the method being synchronized. I've attached a screenshot from YourKit that shows that 47% of the time is being spent in this method. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] c6e1c3: fix SLF4J-240
by Ceki Gulcu 23 Feb '17

23 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: c6e1c3d495d19c636aa923f012235b48e2878d9e https://github.com/qos-ch/slf4j/commit/c6e1c3d495d19c636aa923f012235b48e287… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M slf4j-api/src/main/java/org/slf4j/helpers/BasicMarker.java M slf4j-site/src/site/pages/news.html Log Message: ----------- fix SLF4J-240

1 0

[JIRA] (SLF4J-298) Support for JCL 1.1.3
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-298?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-298. ------------------------------ Resolution: Duplicate Fix Version/s: 1.7.24 Fixed by virtue of SLF4J-383 > Support for JCL 1.1.3 > --------------------- > > Key: SLF4J-298 > URL: https://jira.qos.ch/browse/SLF4J-298 > Project: SLF4J > Issue Type: Sub-task > Components: jcl-over-slf4j > Affects Versions: 1.7.x > Environment: Operating System: All > Platform: PC > Reporter: wolle5050 > Assignee: SLF4J developers list > Fix For: 1.7.24 > > > Add support of the Apache Commons Logging version 1.1.3. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-383) Support for JCL 1.2
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-383?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-383. ------------------------------ Resolution: Fixed Fixed i n commit [f3dc4dd8a|https://github.com/qos-ch/slf4j/commit/f3dc4dd8a3274] > Support for JCL 1.2 > ------------------- > > Key: SLF4J-383 > URL: https://jira.qos.ch/browse/SLF4J-383 > Project: SLF4J > Issue Type: Bug > Components: jcl-over-slf4j > Affects Versions: 1.7.21 > Environment: OSGI > Reporter: Florian Kolbe > Assignee: Ceki Gülcü > Fix For: 1.7.24 > > > Similar to SLF4J-298, support for JCL 1.2 (which exists since 2014) > See https://commons.apache.org/proper/commons-logging/changes-report.html#a1.2 > As an example, commons-vfs2 2.1 imports commons-logging 1.2 > see http://repo1.maven.org/maven2/org/apache/commons/commons-vfs2/2.1/commons-v… > Example for a failing tycho build > {noformat} > [ERROR] Internal error: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from org.apache.commons.vfs 2.1.0 to package org.apache.commons.logging [1.2.0,2.0.0).; No solution found because the problem is unsatisfiable.] -> [Help 1] > org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from org.apache.commons.vfs 2.1.0 to package org.apache.commons.logging [1.2.0,2.0.0).; No solution found because the problem is unsatisfiable.] > {noformat} -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/slf4j] f3dc4d: fix SLF4J-383
by Ceki Gulcu 23 Feb '17

23 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: f3dc4dd8a32741951458eaa0605c37bd6e716e9c https://github.com/qos-ch/slf4j/commit/f3dc4dd8a32741951458eaa0605c37bd6e71… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: M jcl-over-slf4j/pom.xml M jcl-over-slf4j/src/main/resources/META-INF/MANIFEST.MF M pom.xml M slf4j-site/src/site/pages/news.html Log Message: ----------- fix SLF4J-383

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Michael Osipov commented on SLF4J-389: -------------------------------------- Hi Ceki, thanks for the information. I have forwarded this to Hervé Boutemy who wrote the patched provider. He will join the conversation shortly and share his opinion. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-389: ---------------------------------- Hi [~michael-o] Just had a look at [monkey patched slf4j-simple provider|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=94b…] Wouldn't be easier of the renderThrowable and renderLevel method were already available in SimpleLogger? It's seems like a trivial change on this end. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-383) Support for JCL 1.2
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-383?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-383: ---------------------------------- [~hazendaz] Only a SNAPSHOT version of SLF4J was JDK 1.6 for a couple of days. > Support for JCL 1.2 > ------------------- > > Key: SLF4J-383 > URL: https://jira.qos.ch/browse/SLF4J-383 > Project: SLF4J > Issue Type: Bug > Components: jcl-over-slf4j > Affects Versions: 1.7.21 > Environment: OSGI > Reporter: Florian Kolbe > Assignee: Ceki Gülcü > Fix For: 1.7.24 > > > Similar to SLF4J-298, support for JCL 1.2 (which exists since 2014) > See https://commons.apache.org/proper/commons-logging/changes-report.html#a1.2 > As an example, commons-vfs2 2.1 imports commons-logging 1.2 > see http://repo1.maven.org/maven2/org/apache/commons/commons-vfs2/2.1/commons-v… > Example for a failing tycho build > {noformat} > [ERROR] Internal error: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from org.apache.commons.vfs 2.1.0 to package org.apache.commons.logging [1.2.0,2.0.0).; No solution found because the problem is unsatisfiable.] -> [Help 1] > org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from org.apache.commons.vfs 2.1.0 to package org.apache.commons.logging [1.2.0,2.0.0).; No solution found because the problem is unsatisfiable.] > {noformat} -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-369) Make slf4j-ext usage of CAL10N as optional depedency
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-369?page=com.atlassian.jira.plugin.system.… ] Matej Spiller-Muys commented on SLF4J-369: ------------------------------------------ Separate issue was reported inside cal10n: CAL-48. Problem is because cal10n (and slf4j-ext) is doing something in addition during compile process on EVERY project that has dependency on it. If everything goes well, you don't see any issue. And you don't get any error. Well perhaps just a bit longer compilation phases. But due to CAL-48 bug you got busted jar and successful build!!! If you want cal10n compiler phase in you project, well then you should include it in your application yourself (like documentation states). I want to have build process under full control and don't want logger library to be more that it is supposed to (like checking translation in MY project). > Make slf4j-ext usage of CAL10N as optional depedency > ---------------------------------------------------- > > Key: SLF4J-369 > URL: https://jira.qos.ch/browse/SLF4J-369 > Project: SLF4J > Issue Type: Bug > Components: slf4j-ext > Reporter: Matej Spiller-Muys > Assignee: SLF4J developers list > Priority: Critical > Fix For: 1.7.24 > > > I came across this issue because there is bug in CAL10N code (filled separately) that is crashing the compiler. But the reason for this issue is different. Slf4j-ext contains different extensions. In my case we are not even using features from cal10n, but because of slf4j-ext it is now scanning and checking my code regardless (from 0.8). Make slf4j-ext usage of CAL10N as optional dependency. > from manual: > In order to use CAL10N in a project, all you need is to add cal10n-api-0.8.1.jar onto your project's class path. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-373) SLF4J: Class path contains multiple SLF4J bindings
by QOS.CH (JIRA) 23 Feb '17

23 Feb '17

[ https://jira.qos.ch/browse/SLF4J-373?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü resolved SLF4J-373. ------------------------------ Resolution: Not a bug Please read https://www.slf4j.org/codes.html#multiple_bindings > SLF4J: Class path contains multiple SLF4J bindings > -------------------------------------------------- > > Key: SLF4J-373 > URL: https://jira.qos.ch/browse/SLF4J-373 > Project: SLF4J > Issue Type: Bug > Components: Unspecified > Affects Versions: 1.7.x > Reporter: Pu Yi He > Assignee: SLF4J developers list > > In our project, there is one warning message as below when to use slf4j-1.7.5, how to resolve this issue? > - project dependency: > <dependency name="slf4j-1.7.5" type="jar" version="1.7.5"/> > this will include slf4j-api-1.7.5.jar and slf4j-log4j12-1.7.5.jar > <dependency name="hystrix" type="jar" /> > this will include slf4j-api-1.7.5.jar and slf4j-jdk14-1.7.5.jar > - warning message: > WARNING: Couldn't load build resource bundle. Build timestamp will be inaccurate *** > SLF4J: Class path contains multiple SLF4J bindings. > SLF4J: Found binding in [wsjar:file:/xxx.ear/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in [wsjar:file:/xxx.ear/slf4j-jdk14-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]* > SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0