- slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 13 Jan '17

13 Jan '17

[ http://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.i… ] Ceki Gulcu commented on SLF4J-389: ---------------------------------- [~ipolevoy] Sorry, but no date has been set yet for this release. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: http://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gulcu > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v6.4.12#64027)

1 0

QOS.CH Jira username is your email address
by Ceki Gulcu 13 Jan '17

13 Jan '17

Dear SLF4J developers list , On the QOS.CH Jira instance issues can be browsed by anonymous users, that is without logging in. The Jira web-page for a given issue will contain the user name of the reporter as well as the user names for all those who commented on the issue. Thus, web-crawlers will be able to see user names on our Jira instance. This is acceptable as long as user names do not contain sensitive data. However, given that your user name matches your email address on the QOS.CH Jira instance, we fear that your email address may leak to anonymous web-crawlers (who can see your Jira user name). Please note that many other publicly accessible Jira installations suffer from the exact same problem. Modifying your user name so as to make it different than your email address should stop the aforementioned data leakage. Unfortunately, you cannot change your user name on your own. Only the Jira administrator can change it. In light of the above, if you decide to change your Jira user name, please let me know the user name of your choice by replying to this message. Best regards, -- Ceki Gülcü

1 0

[qos-ch/slf4j] 7df8af: SLF4J-389 - added a test
by Ceki Gulcu 11 Jan '17

11 Jan '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 7df8afcb22dd25fd156b4336ba4ade4f85014a4d https://github.com/qos-ch/slf4j/commit/7df8afcb22dd25fd156b4336ba4ade4f8501… Author: Igor Polevoy <igor(a)expresspigeon.com> Date: 2017-01-11 (Wed, 11 Jan 2017) Changed paths: M slf4j-simple/src/test/java/org/slf4j/impl/SimpleLoggerTest.java Log Message: ----------- SLF4J-389 - added a test Commit: 1ddc1f72d1281af6cad5956ed8736ad5114fa62f https://github.com/qos-ch/slf4j/commit/1ddc1f72d1281af6cad5956ed8736ad5114f… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-01-11 (Wed, 11 Jan 2017) Changed paths: M slf4j-simple/src/test/java/org/slf4j/impl/SimpleLoggerTest.java Log Message: ----------- Merge pull request #169 from ipolevoy/master SLF4J-389 - added a test Compare: https://github.com/qos-ch/slf4j/compare/b8b881b7395e...1ddc1f72d128

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by Igor Polevoy (JIRA) 11 Jan '17

11 Jan '17

1 0

[qos-ch/slf4j] b8b881: follow java conventions for enums
by Ceki Gulcu 11 Jan '17

11 Jan '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: b8b881b7395ead1d2316a740b6a633b3ed16e994 https://github.com/qos-ch/slf4j/commit/b8b881b7395ead1d2316a740b6a633b3ed16… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-01-11 (Wed, 11 Jan 2017) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/OutputChoice.java M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java Log Message: ----------- follow java conventions for enums

1 0

SimpleLogger prints to the latest value of System.out
by Ceki Gülcü 11 Jan '17

11 Jan '17

Hello all, In issue SLF4J-389 [1] user Igor Polevoy observed that once initialized, SimpleLogger always used the same reference to System.out (or System.err). He feels that this can interfere in test where System.out is modified in order to capture log output. Commit 69be5f7f [2] ensures that SimpleLogger prints to the latest value of System.out. Please let me know if this may be an issue for you. Best regards, -- Ceki [1] http://jira.qos.ch/browse/SLF4J-389 [2] https://github.com/qos-ch/slf4j/commit/69be5f7f9875

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by Ceki Gulcu (JIRA) 11 Jan '17

11 Jan '17

1 0

[qos-ch/slf4j] 69be5f: fix SLF4J-389
by Ceki Gulcu 11 Jan '17

11 Jan '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 69be5f7f9875347ed0feb54577bff3b1bb9063a0 https://github.com/qos-ch/slf4j/commit/69be5f7f9875347ed0feb54577bff3b1bb90… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-01-11 (Wed, 11 Jan 2017) Changed paths: A slf4j-simple/src/main/java/org/slf4j/impl/OutputChoice.java M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java Log Message: ----------- fix SLF4J-389

1 0

[qos-ch/slf4j] d0d953: update year, remove external project references
by Ceki Gulcu 11 Jan '17

11 Jan '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: d0d9536dc9bf2468aa9e379d1bc644e1e5ed3cca https://github.com/qos-ch/slf4j/commit/d0d9536dc9bf2468aa9e379d1bc644e1e5ed… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-01-11 (Wed, 11 Jan 2017) Changed paths: M slf4j-simple/src/main/java/org/slf4j/impl/SimpleLogger.java M slf4j-site/src/site/pages/index.html M slf4j-site/src/site/pages/license.html M slf4j-site/src/site/pages/templates/footer.js Log Message: ----------- update year, remove external project references

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by Igor Polevoy (JIRA) 07 Jan '17

07 Jan '17

1 0