- slf4j-dev - mailman3.qos.ch

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 16 Feb '17

16 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Michael Osipov commented on SLF4J-389: -------------------------------------- First of all, we use a modified version of the [Simple Provider|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=94b…] Maven itself doesn't do it, but likely other plugins and especially Surefire when testing or forking VMs. I will also test 1.7.23 against Surefire master. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 15 Feb '17

15 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-389: ---------------------------------- Thanks for the IT link. Glad to hear that the integration tests pass. Is it customary for Maven plugins to re-assign System.out/err? If not, there is nothing to worry about. However, if re-assignment of those streams is common, I'd worry regardless of the test results. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 15 Feb '17

15 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Michael Osipov commented on SLF4J-389: -------------------------------------- Looks promising with the ITs: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/slf4j-1.7.23/1/ > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 15 Feb '17

15 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Michael Osipov commented on SLF4J-389: -------------------------------------- Indeed you did. I will run our ITs against it and see wether there is a failure. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 15 Feb '17

15 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Ceki Gülcü commented on SLF4J-389: ---------------------------------- Hi [~michael-o], On January 111th, I have posted [a message on the maven-dev mailing list|http://markmail.org/message/5x2dpmy3szzfiv5k] inquiring whether this change could have any effect on Maven. There was no response to this message. To answer your question, there's a possibility that Maven would be affected if if a given plugin modifies the value of System.out or System.err and further assumes that Maven’s log output will be directed to the old value of the stream. I can't say for sure. In any case, if Maven is affected, the old behavior can be re-introduced as a configuration option. Please let me know what you think. > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (SLF4J-389) SimpleLogger caches System.err and System.out
by QOS.CH (JIRA) 15 Feb '17

15 Feb '17

[ https://jira.qos.ch/browse/SLF4J-389?page=com.atlassian.jira.plugin.system.… ] Michael Osipov commented on SLF4J-389: -------------------------------------- [~ceki], are there any implictions for Maven since we use the Simple Provider as default? Should be upgrade or are we OK with 1.7.22? > SimpleLogger caches System.err and System.out > --------------------------------------------- > > Key: SLF4J-389 > URL: https://jira.qos.ch/browse/SLF4J-389 > Project: SLF4J > Issue Type: Bug > Affects Versions: 1.7.x > Reporter: Igor Polevoy > Assignee: Ceki Gülcü > Fix For: 1.7.23 > > > We usually use SimpleLogger in tests, and some other binding when running in production. > In some cases, our tests depend on log values logged through the logger during a test. > Unfortunately between version 1.7.0 and 1.7.1 this ability has been removed, since the SimpleLogger now caches the system stream in a static initialiser. > Here is the code that broke this approach: > https://github.com/qos-ch/slf4j/commit/996ccc7ca507994465c069554954ecb01890… > Basically, we would write a test: > {quote}PrintStream err = System.err; > PrintStream temp = new PrintStream(some buffer here); > System.err = temp; > // run tests > System.err = err; > // here we assert that the temp stream contains values we expect{quote} > Unfortunately SimpleLogger now caches the system stream and never releases it, meaning swapping the streams to catch the output is not possible. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

Release of SLF4J version 1.7.23
by Ceki Gülcü 14 Feb '17

14 Feb '17

Hello all, I am happy to announce the immediate availability of SLF4J version 1.7.23, a maintenance release fixing bugs with no new features. It fixes a log4j issue with Java 9. Please refer to the the news page for more details on this release: http://www.slf4j.org/news.html The relevant artifacts should hit the Maven central repository within the next few hours. As of version 1.7.9, SLF4J can automatically detect and report mismatches between the class where a logger is defined and the logger name. This cool feature was contributed by Alexander Dorokhine. I join the undoubtedly many SLF4J users in thanking Alexander for his great work. For more details on this feature see: http://www.slf4j.org/codes.html#loggerNameMismatch The 1.7.x series: The Simple Logging Facade for Java or (SLF4J) serves as a simple facade or abstraction for various logging frameworks, e.g. java.util.logging, log4j and logback, allowing the end user to plug in the desired logging framework at deployment time. The 1.7.x series adds varargs support in Logger methods. Compared to previous versions, 1.7.5 significantly improves logger retrieval times. Users are highly encouraged to migrate to SLF4J 1.7.5 or later. Binary compatibility: Mixing mixing different versions of slf4j-api.jar and SLF4J binding can cause problems. For example, if you are using slf4j-api-1.7.1.jar, then you should also use slf4j-simple-1.7.1.jar, using slf4j-simple-1.5.5.jar will not work. From the client's perspective all versions of slf4j-api are compatible. Client code compiled with slf4j-api-N.jar will run perfectly fine with slf4j-api-M.jar for any N and M. You only need to ensure that the version of your binding matches that of the slf4j-api.jar. You do not have to worry about the version of slf4j-api.jar used to compile a given dependency in your project. You can always use *any* version of slf4j-api.jar, and as long as the version of slf4j-api.jar and its binding match, you should be fine. At initialization time, if SLF4J suspects that there may be an api vs. binding version mismatch problem, it will emit a warning about the suspected mismatch. Version 1.7.x series takes compatibility one step further so that slf4j-api and SLF4J bindings can be freely mixed with artifacts from the 1.6.x or 1.7.x series. In other words, when running under JDK 1.5 or later, version 1.7.x is totally 100% no-ifs-or-buts compatible with the 1.6.x series. Downloading SLF4J: You can download SLF4J, including full source code, class files and documentation on our download page: http://www.slf4j.org/download.html Announcement mailing list: You can receive SLF4J related announcements by subscribing to the SLF4J announce mailing list. To subscribe to QOS.ch announce list, please visit the following URL. http://www.qos.ch/mailman/listinfo/announce You may also receive announcements via twitter: https://twitter.com/qos_ch Enjoy, -- Ceki Gülcü

1 0

[qos-ch/slf4j] d82a2e: start work on 1.7.24-SNAPSHOT
by Ceki Gulcu 14 Feb '17

14 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: d82a2e9ab7aad93efefbb65a94a56a02e97ea3e8 https://github.com/qos-ch/slf4j/commit/d82a2e9ab7aad93efefbb65a94a56a02e97e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M integration/pom.xml M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-android/pom.xml M slf4j-api/pom.xml M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml Log Message: ----------- start work on 1.7.24-SNAPSHOT

1 0

[qos-ch/slf4j]
by ceki 14 Feb '17

14 Feb '17

Branch: refs/tags/v_1.7.23 Home: https://github.com/qos-ch/slf4j

1 0

[qos-ch/slf4j] 5c8222: release 1.7.23
by Ceki Gulcu 14 Feb '17

14 Feb '17

Branch: refs/heads/master Home: https://github.com/qos-ch/slf4j Commit: 5c822203c9c334d8e4e5451e716f38c2fd4202c5 https://github.com/qos-ch/slf4j/commit/5c822203c9c334d8e4e5451e716f38c2fd42… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-02-14 (Tue, 14 Feb 2017) Changed paths: M integration/pom.xml M integration/src/test/java/org/slf4j/test_osgi/BundleTest.java M jcl-over-slf4j/pom.xml M jul-to-slf4j/pom.xml M log4j-over-slf4j/pom.xml M osgi-over-slf4j/pom.xml M pom.xml M slf4j-android/pom.xml M slf4j-api/pom.xml M slf4j-api/src/main/java/org/slf4j/helpers/Util.java R slf4j-api/src/test/java/org/slf4j/helpers/UtilVersionTest.java M slf4j-ext/pom.xml M slf4j-jcl/pom.xml M slf4j-jdk14/pom.xml M slf4j-log4j12/pom.xml M slf4j-log4j12/src/main/java/org/slf4j/impl/Log4jMDCAdapter.java A slf4j-log4j12/src/main/java/org/slf4j/impl/VersionUtil.java M slf4j-log4j12/src/test/java/org/apache/log4j/MDCFriendTest.java A slf4j-log4j12/src/test/java/org/slf4j/impl/UtilVersionTest.java M slf4j-migrator/pom.xml M slf4j-nop/pom.xml M slf4j-simple/pom.xml M slf4j-site/pom.xml M slf4j-site/src/site/pages/news.html Log Message: ----------- release 1.7.23

1 0